linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Prarit Bhargava <prarit@redhat.com>
To: linux-pci@vger.kernel.org
Cc: Prarit Bhargava <prarit@redhat.com>, Myron Stowe <mstowe@redhat.com>
Subject: [PATCH] pci, add FW_BUG warning to pci= kernel option
Date: Sat,  1 Nov 2014 14:11:19 -0400	[thread overview]
Message-ID: <1414865479-25792-1-git-send-email-prarit@redhat.com> (raw)

The kernel should boot PCI without the use of kernel parameters.  Display
a FW_BUG warning when pci= is used.

Cc: Myron Stowe <mstowe@redhat.com>
Cc: linux-pci@vger.kernel.org
Signed-off-by: Prarit Bhargava <prarit@redhat.com>
---
 drivers/pci/pci.c |    2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
index 625a4ac..5172060b 100644
--- a/drivers/pci/pci.c
+++ b/drivers/pci/pci.c
@@ -4515,6 +4515,8 @@ static int __init pci_setup(char *str)
 		}
 		str = k;
 	}
+	add_taint(TAINT_FIRMWARE_WORKAROUND, LOCKDEP_STILL_OK);
+	pr_crit(FW_BUG "The PCI configuration has been overridden thorugh the use of pci=.  Please report the issue you are attempting to resolve to your hardware vendor.\n");
 	return 0;
 }
 early_param("pci", pci_setup);
-- 
1.7.9.3


             reply	other threads:[~2014-11-01 18:11 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-01 18:11 Prarit Bhargava [this message]
2014-11-11  3:59 ` [PATCH] pci, add FW_BUG warning to pci= kernel option Bjorn Helgaas
2014-11-17 23:42   ` Bjorn Helgaas
2014-11-18 12:42     ` Prarit Bhargava
2014-11-18 14:00       ` Bjorn Helgaas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1414865479-25792-1-git-send-email-prarit@redhat.com \
    --to=prarit@redhat.com \
    --cc=linux-pci@vger.kernel.org \
    --cc=mstowe@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).