From: Lucas Stach <l.stach@pengutronix.de>
To: Sean Cross <xobs@kosagi.com>
Cc: Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Shawn Guo <shawn.guo@freescale.com>,
Bjorn Helgaas <bhelgaas@google.com>,
devicetree@vger.kernel.org, Richard Zhu <r65037@freescale.com>,
Grant Likely <grant.likely@linaro.org>,
linux-pci@vger.kernel.org, bunnie@kosagi.com
Subject: Re: [PATCH 2/2] ARM: dts: imx6q: add Novena board
Date: Fri, 19 Dec 2014 11:32:59 +0100 [thread overview]
Message-ID: <1418985179.2558.3.camel@pengutronix.de> (raw)
In-Reply-To: <1418976617-833-3-git-send-email-xobs@kosagi.com>
Am Freitag, den 19.12.2014, 16:10 +0800 schrieb Sean Cross:
> Novena is an open-hardware laptop/desktop/bare board.
>
> See http://www.kosagi.com/w/index.php?title=Novena_Main_Page
>
> This device tree contains additional nodes for FPGA support.
>
I only skimmed the DT for now.
There are lots of occurrences of the "kosagi" vendor prefix, which is is
not documented right now. Please add it to
Documentation/devicetree/bindings/vendor-prefixes.txt first.
> Signed-off-by: Sean Cross <xobs@kosagi.com>
> ---
> arch/arm/boot/dts/Makefile | 1 +
> arch/arm/boot/dts/imx6q-novena.dts | 893 +++++++++++++++++++++++++++++++++++++
> 2 files changed, 894 insertions(+)
> create mode 100644 arch/arm/boot/dts/imx6q-novena.dts
>
> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> index 38c89ca..b2b4770 100644
> --- a/arch/arm/boot/dts/Makefile
> +++ b/arch/arm/boot/dts/Makefile
> @@ -234,6 +234,7 @@ dtb-$(CONFIG_ARCH_MXC) += \
> imx6q-gw552x.dtb \
> imx6q-hummingboard.dtb \
> imx6q-nitrogen6x.dtb \
> + imx6q-novena.dtb \
> imx6q-phytec-pbab01.dtb \
> imx6q-rex-pro.dtb \
> imx6q-sabreauto.dtb \
> diff --git a/arch/arm/boot/dts/imx6q-novena.dts b/arch/arm/boot/dts/imx6q-novena.dts
> new file mode 100644
> index 0000000..143b3bd
> --- /dev/null
> +++ b/arch/arm/boot/dts/imx6q-novena.dts
> @@ -0,0 +1,893 @@
[...]
> + fpga@1 {
> + compatible = "kosagi,novena-fpga";
This is missing a proper binding documentation.
> +
> + spi-max-frequency = <30000000>;
> + reg = <1>;
> +
> + pinctrl-names = "default", "state-eim", "state-gpio";
> + pinctrl-0 = <&pinctrl_fpga_gpio>;
> + pinctrl-1 = <&pinctrl_fpga_eim>;
> + pinctrl-2 = <&pinctrl_fpga_gpio>;
> + clocks = <&clks IMX6QDL_CLK_LVDS2_SEL>, <&clks IMX6QDL_CLK_LVDS2_GATE>, <&clks IMX6QDL_CLK_ENET_REF>, <&clks IMX6QDL_CLK_EIM_SLOW>;
> + clock-names = "lvds", "lvds-switch", "lvds-parent", "eim-slow";
> + reset-switch = <&gpio1 17 GPIO_ACTIVE_HIGH>;
> + power-switch = <&gpio5 7 GPIO_ACTIVE_HIGH>;
Custom property names without vendor namespacing. Also I don't know what
they should do without the binding.
> +
> + kosagi,weim-cs0-timing = <0x31910BBF 0x00001000 0x09014000
> + 0x00000000 0x09080800 0x00000000>;
> + kosagi,weim-cs1-timing = <0x81910CBF 0x00001000 0x07001000
> + 0x00000200 0x02040400 0x00000000>;
> + kosagi,weim-cs-mapping = <2>;
> + };
> +};
> +
[...]
> +&ldb {
> + fsl,dual-channel;
> + status = "okay";
> + lvds-channel@0 {
> + fsl,data-mapping = "jeida";
> + fsl,data-width = <24>;
> + status = "okay";
> + display-timings {
> + 1920x1080p60 {
> + clock-frequency = <148500000>;
> + hactive = <1920>;
> + vactive = <1080>;
> + hback-porch = <148>;
> + hfront-porch = <88>;
> + hsync-len = <44>;
> + vback-porch = <36>;
> + vfront-porch = <4>;
> + vsync-len = <5>;
> + hsync-active = <1>;
> + vsync-active = <1>;
> + };
> + };
Please don't use this for new devicetrees. Add a proper panel driver
instead. Looks like this panel can be represented with the simple-panel
driver.
Regards,
Lucas
--
Pengutronix e.K. | Lucas Stach |
Industrial Linux Solutions | http://www.pengutronix.de/ |
prev parent reply other threads:[~2014-12-19 10:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-19 8:10 [PATCH 0/2] Add support for kosagi novena Sean Cross
2014-12-19 8:10 ` [PATCH 1/2] PCI: imx6: Add power-supply support Sean Cross
2014-12-19 10:19 ` Lucas Stach
2014-12-19 8:10 ` [PATCH 2/2] ARM: dts: imx6q: add Novena board Sean Cross
2014-12-19 10:32 ` Lucas Stach [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1418985179.2558.3.camel@pengutronix.de \
--to=l.stach@pengutronix.de \
--cc=bhelgaas@google.com \
--cc=bunnie@kosagi.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=grant.likely@linaro.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-pci@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=r65037@freescale.com \
--cc=robh+dt@kernel.org \
--cc=shawn.guo@freescale.com \
--cc=xobs@kosagi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).