From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com ([209.132.183.28]:38630 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751313AbbAMP2d (ORCPT ); Tue, 13 Jan 2015 10:28:33 -0500 Message-ID: <1421162910.6130.144.camel@redhat.com> Subject: Re: [PATCH] pci: Add ACS quirk for Emulex NICs From: Alex Williamson To: Sathya Perla Cc: linux-pci@vger.kernel.org Date: Tue, 13 Jan 2015 08:28:30 -0700 In-Reply-To: <1421130143-4391-1-git-send-email-sathya.perla@emulex.com> References: <1421130143-4391-1-git-send-email-sathya.perla@emulex.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Sender: linux-pci-owner@vger.kernel.org List-ID: On Tue, 2015-01-13 at 01:22 -0500, Sathya Perla wrote: > From: Vasundhara Volam > > As Skyhawk and BE3-R (both multi-function devices) don't advertise the > PCI-ACS capability, the vfio driver places all the functions of these > devices in a single IOMMU group. Attaching (via PCI-passthru)two different > Skyhawk/BE3-R partitions (nPAR, Flex etc PFs) using vfio, to different > guests doesn't work as vfio only allows functions in *different* IOMMU > groups to be assigned to different guests. > > As peer-to-peer access between PFs in Skyhawk/BE3-R is not possible, > we can treat them as "fully isolated" even though the device doesn't > advertise ACS. So, this patch adds a PCI quirk for Skyhawk and BE3-R > chips to fix this problem. > > Signed-off-by: Vasundhara Volam > Signed-off-by: Sathya Perla > --- > drivers/pci/quirks.c | 2 ++ > 1 file changed, 2 insertions(+) Acked-by: Alex Williamson > diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c > index ed6f89b..3d24629 100644 > --- a/drivers/pci/quirks.c > +++ b/drivers/pci/quirks.c > @@ -3713,6 +3713,8 @@ static const struct pci_dev_acs_enabled { > { PCI_VENDOR_ID_INTEL, 0x1551, pci_quirk_mf_endpoint_acs }, > { PCI_VENDOR_ID_INTEL, 0x1558, pci_quirk_mf_endpoint_acs }, > { PCI_VENDOR_ID_INTEL, PCI_ANY_ID, pci_quirk_intel_pch_acs }, > + { 0x19a2, 0x710, pci_quirk_mf_endpoint_acs }, /* Emulex BE3-R */ > + { 0x10df, 0x720, pci_quirk_mf_endpoint_acs }, /* Emulex Skyhawk-R */ > { 0 } > }; >