From: Marc Zyngier <marc.zyngier@arm.com>
To: Thomas Gleixner <tglx@linutronix.de>,
Jiang Liu <jiang.liu@linux.intel.com>,
Bjorn Helgaas <bhelgaas@google.com>
Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Andre Przywara <andre.przywara@arm.com>,
<linux-pci@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: [PATCH] PCI: Fix pcibios_update_irq misuse of irq number
Date: Wed, 28 Jan 2015 14:51:23 +0000 [thread overview]
Message-ID: <1422456683-797-1-git-send-email-marc.zyngier@arm.com> (raw)
pcibios_update_irq writes an irq number into the config space
of a given PCI device, but ignores the fact that this number
is a virtual interrupt number, which might be a very different
value from what the underlying hardware is using.
The obvious fix is to fetch the HW interrupt number from the
corresponding irq_data structure. This is slightly complicated
by the fact that this interrupt might be services by a stacked
domain.
This has been tested on KVM with kvmtool.
Reported-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Tested-by: Andre Przywara <andre.przywara@arm.com>
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
---
drivers/pci/setup-irq.c | 12 ++++++++++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/drivers/pci/setup-irq.c b/drivers/pci/setup-irq.c
index 4e2d595..828cbc9 100644
--- a/drivers/pci/setup-irq.c
+++ b/drivers/pci/setup-irq.c
@@ -15,11 +15,19 @@
#include <linux/errno.h>
#include <linux/ioport.h>
#include <linux/cache.h>
+#include <linux/irq.h>
void __weak pcibios_update_irq(struct pci_dev *dev, int irq)
{
- dev_dbg(&dev->dev, "assigning IRQ %02d\n", irq);
- pci_write_config_byte(dev, PCI_INTERRUPT_LINE, irq);
+ struct irq_data *d;
+
+ d = irq_get_irq_data(irq);
+#ifdef CONFIG_IRQ_DOMAIN_HIERARCHY
+ while (d->parent_data)
+ d = d->parent_data;
+#endif
+ dev_dbg(&dev->dev, "assigning IRQ %02ld\n", d->hwirq);
+ pci_write_config_byte(dev, PCI_INTERRUPT_LINE, d->hwirq);
}
static void pdev_fixup_irq(struct pci_dev *dev,
--
2.1.4
next reply other threads:[~2015-01-28 20:48 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-28 14:51 Marc Zyngier [this message]
2015-01-28 15:21 ` [PATCH] PCI: Fix pcibios_update_irq misuse of irq number Jiang Liu
2015-01-28 15:27 ` Marc Zyngier
2015-01-28 15:43 ` Bjorn Helgaas
2015-02-02 16:15 ` Marc Zyngier
2015-02-02 16:22 ` Bjorn Helgaas
2015-02-02 15:57 ` Bjorn Helgaas
2015-02-02 16:06 ` Jiang Liu
2015-02-02 16:23 ` Marc Zyngier
2015-02-02 16:33 ` Russell King - ARM Linux
2015-02-02 18:08 ` Marc Zyngier
2015-02-02 18:20 ` Russell King - ARM Linux
2015-02-02 17:02 ` Arnd Bergmann
2015-02-03 10:38 ` Marc Zyngier
2015-02-03 11:31 ` Arnd Bergmann
2015-02-03 11:37 ` Marc Zyngier
2015-02-03 12:57 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1422456683-797-1-git-send-email-marc.zyngier@arm.com \
--to=marc.zyngier@arm.com \
--cc=andre.przywara@arm.com \
--cc=bhelgaas@google.com \
--cc=jiang.liu@linux.intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).