From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from e23smtp01.au.ibm.com ([202.81.31.143]:54461 "EHLO e23smtp01.au.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752606AbbBTCmh (ORCPT ); Thu, 19 Feb 2015 21:42:37 -0500 Received: from /spool/local by e23smtp01.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 20 Feb 2015 12:42:34 +1000 Received: from d23relay09.au.ibm.com (d23relay09.au.ibm.com [9.185.63.181]) by d23dlp01.au.ibm.com (Postfix) with ESMTP id B23082CE804E for ; Fri, 20 Feb 2015 13:42:32 +1100 (EST) Received: from d23av02.au.ibm.com (d23av02.au.ibm.com [9.190.235.138]) by d23relay09.au.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id t1K2gOGu33685730 for ; Fri, 20 Feb 2015 13:42:32 +1100 Received: from d23av02.au.ibm.com (localhost [127.0.0.1]) by d23av02.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id t1K2fwZJ002984 for ; Fri, 20 Feb 2015 13:41:59 +1100 Message-ID: <1424400095.27448.7.camel@au1.ibm.com> Subject: Re: [PATCH V11 06/17] powerpc/pci: Add PCI resource alignment documentation From: Benjamin Herrenschmidt To: Bjorn Helgaas Cc: Wei Yang , gwshan@linux.vnet.ibm.com, linux-pci@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Date: Fri, 20 Feb 2015 13:41:35 +1100 In-Reply-To: <20150220005621.GA21131@google.com> References: <20150113180502.GC2776@google.com> <1421288887-7765-1-git-send-email-weiyang@linux.vnet.ibm.com> <1421288887-7765-7-git-send-email-weiyang@linux.vnet.ibm.com> <20150204234433.GC11271@google.com> <1423530151.4924.73.camel@au1.ibm.com> <20150220005621.GA21131@google.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Sender: linux-pci-owner@vger.kernel.org List-ID: On Thu, 2015-02-19 at 18:56 -0600, Bjorn Helgaas wrote: > So there are the two windows of CPU address space that are routed to the > PHB. And the PHB contains one M32 window and sixteen M64 windows. What > happens if the PHB receives an access to something that was in one of the > two CPU address space windows, but is not contained in M32 or one of the > M64 windows? Some kind of error, I don't know which one at this point, possibly fatal (checkstop or similar) or maybe a fence of the PHB. Don't do it :-) > If that is an error or is non-sensical, then the only windows relevant to > PCI would be the M32 and M64 windows, and we could just ignore the > top-level two windows. Right. In fact we pretty much hard wire that one of the top level is small and used for M32 with a fixed layout and the other is big and used for all M64's. We use one of the M64 to cover it entirely, which is our "base" set of segments for allocating busses/BARs, and then we use the remaining M64's overlaid on top of that first one for things like SR-IOV. > I squashed all my doc updates into the original and pushed it here: > > https://git.kernel.org/cgit/linux/kernel/git/helgaas/pci.git/commit/?h=pci/virtualization&id=5449d1a812d561bafe0d458132ef356765505507 > > If I made it say something wrong, a patch would be the best way to fix it. Thanks, I'll have a look Cheers, Ben.