From: Wei Yang <weiyang@linux.vnet.ibm.com>
To: bhelgaas@google.com, benh@au1.ibm.com, gwshan@linux.vnet.ibm.com
Cc: linux-pci@vger.kernel.org, linuxppc-dev@lists.ozlabs.org
Subject: [PATCH V15 03/21] PCI: Print more info in sriov_enable() error message
Date: Wed, 25 Mar 2015 13:44:39 +0800 [thread overview]
Message-ID: <1427262297-5694-4-git-send-email-weiyang@linux.vnet.ibm.com> (raw)
In-Reply-To: <1427262297-5694-1-git-send-email-weiyang@linux.vnet.ibm.com>
From: Bjorn Helgaas <bhelgaas@google.com>
If we don't have space for all the bus numbers required to enable VFs,
print the largest bus number required and the range available.
No functional change; improved error message only.
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Acked-by: Wei Yang <weiyang@linux.vnet.ibm.com>
---
drivers/pci/iov.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/pci/iov.c b/drivers/pci/iov.c
index 4b3a4ea..c4c33ea 100644
--- a/drivers/pci/iov.c
+++ b/drivers/pci/iov.c
@@ -180,6 +180,7 @@ static int sriov_enable(struct pci_dev *dev, int nr_virtfn)
struct pci_dev *pdev;
struct pci_sriov *iov = dev->sriov;
int bars = 0;
+ u8 bus;
if (!nr_virtfn)
return 0;
@@ -216,8 +217,10 @@ static int sriov_enable(struct pci_dev *dev, int nr_virtfn)
iov->offset = offset;
iov->stride = stride;
- if (virtfn_bus(dev, nr_virtfn - 1) > dev->bus->busn_res.end) {
- dev_err(&dev->dev, "SR-IOV: bus number out of range\n");
+ bus = virtfn_bus(dev, nr_virtfn - 1);
+ if (bus > dev->bus->busn_res.end) {
+ dev_err(&dev->dev, "can't enable %d VFs (bus %02x out of range of %pR)\n",
+ nr_virtfn, bus, &dev->bus->busn_res);
return -ENOMEM;
}
--
1.7.9.5
next prev parent reply other threads:[~2015-03-25 5:49 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-25 5:44 [PATCH V15 00/21] Enable SRIOV on POWER8 Wei Yang
2015-03-25 5:44 ` [PATCH V15 01/21] powerpc/pci: Refactor pci_dn Wei Yang
2015-03-25 5:44 ` [PATCH V15 02/21] powerpc/powernv: Use pci_dn, not device_node, in PCI config accessor Wei Yang
2015-03-25 5:44 ` Wei Yang [this message]
2015-03-25 5:44 ` [PATCH V15 04/21] PCI: Print PF SR-IOV resource that contains all VF(n) BAR space Wei Yang
2015-03-25 5:44 ` [PATCH V15 05/21] PCI: Keep individual VF BAR size in struct pci_sriov Wei Yang
2015-03-25 5:44 ` [PATCH V15 06/21] PCI: Index IOV resources in the conventional style Wei Yang
2015-03-25 5:44 ` [PATCH V15 07/21] PCI: Refresh First VF Offset and VF Stride when updating NumVFs Wei Yang
2015-03-25 5:44 ` [PATCH V15 08/21] PCI: Calculate maximum number of buses required for VFs Wei Yang
2015-03-25 5:44 ` [PATCH V15 09/21] PCI: Export pci_iov_virtfn_bus() and pci_iov_virtfn_devfn() Wei Yang
2015-03-25 5:44 ` [PATCH V15 10/21] PCI: Add pcibios_sriov_enable() and pcibios_sriov_disable() Wei Yang
2015-03-25 5:44 ` [PATCH V15 11/21] PCI: Add pcibios_iov_resource_alignment() interface Wei Yang
2015-03-25 5:44 ` [PATCH V15 12/21] PCI: Consider additional PF's IOV BAR alignment in sizing and assigning Wei Yang
2015-03-25 5:44 ` [PATCH V15 13/21] powerpc/pci: Don't unset PCI resources for VFs Wei Yang
2015-03-25 5:44 ` [PATCH V15 14/21] powerpc/powernv: Allocate struct pnv_ioda_pe iommu_table dynamically Wei Yang
2015-03-25 5:44 ` [PATCH V15 15/21] powerpc/powernv: Reserve additional space for IOV BAR according to the number of total_pe Wei Yang
2015-03-25 5:44 ` [PATCH V15 16/21] powerpc/powernv: Implement pcibios_iov_resource_alignment() on powernv Wei Yang
2015-03-25 5:44 ` [PATCH V15 17/21] powerpc/powernv: Shift VF resource with an offset Wei Yang
2015-03-25 5:44 ` [PATCH V15 18/21] powerpc/powernv: Reserve additional space for IOV BAR, with m64_per_iov supported Wei Yang
2015-03-25 5:44 ` [PATCH V15 19/21] powerpc/powernv: Group VF PE when IOV BAR is big on PHB3 Wei Yang
2015-03-25 5:44 ` [PATCH V15 20/21] powerpc/pci: Remove unused struct pci_dn.pcidev field Wei Yang
2015-03-25 5:44 ` [PATCH V15 21/21] powerpc/pci: Add PCI resource alignment documentation Wei Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1427262297-5694-4-git-send-email-weiyang@linux.vnet.ibm.com \
--to=weiyang@linux.vnet.ibm.com \
--cc=benh@au1.ibm.com \
--cc=bhelgaas@google.com \
--cc=gwshan@linux.vnet.ibm.com \
--cc=linux-pci@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).