linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Wei Yang <weiyang@linux.vnet.ibm.com>
To: bhelgaas@google.com, benh@au1.ibm.com, gwshan@linux.vnet.ibm.com
Cc: linux-pci@vger.kernel.org, linuxppc-dev@lists.ozlabs.org
Subject: [PATCH V16 01/20] PCI: Print more info in sriov_enable() error message
Date: Wed, 25 Mar 2015 16:23:42 +0800	[thread overview]
Message-ID: <1427271841-28749-2-git-send-email-weiyang@linux.vnet.ibm.com> (raw)
In-Reply-To: <1427271841-28749-1-git-send-email-weiyang@linux.vnet.ibm.com>

From: Bjorn Helgaas <bhelgaas@google.com>

If we don't have space for all the bus numbers required to enable VFs,
print the largest bus number required and the range available.

No functional change; improved error message only.

Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Acked-by: Wei Yang <weiyang@linux.vnet.ibm.com>
---
 drivers/pci/iov.c |    7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/drivers/pci/iov.c b/drivers/pci/iov.c
index 4b3a4ea..c4c33ea 100644
--- a/drivers/pci/iov.c
+++ b/drivers/pci/iov.c
@@ -180,6 +180,7 @@ static int sriov_enable(struct pci_dev *dev, int nr_virtfn)
 	struct pci_dev *pdev;
 	struct pci_sriov *iov = dev->sriov;
 	int bars = 0;
+	u8 bus;
 
 	if (!nr_virtfn)
 		return 0;
@@ -216,8 +217,10 @@ static int sriov_enable(struct pci_dev *dev, int nr_virtfn)
 	iov->offset = offset;
 	iov->stride = stride;
 
-	if (virtfn_bus(dev, nr_virtfn - 1) > dev->bus->busn_res.end) {
-		dev_err(&dev->dev, "SR-IOV: bus number out of range\n");
+	bus = virtfn_bus(dev, nr_virtfn - 1);
+	if (bus > dev->bus->busn_res.end) {
+		dev_err(&dev->dev, "can't enable %d VFs (bus %02x out of range of %pR)\n",
+			nr_virtfn, bus, &dev->bus->busn_res);
 		return -ENOMEM;
 	}
 
-- 
1.7.9.5


  reply	other threads:[~2015-03-25  8:25 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-25  8:23 [PATCH V16 00/20] Enable SRIOV on POWER8 Wei Yang
2015-03-25  8:23 ` Wei Yang [this message]
2015-03-25  8:23 ` [PATCH V16 02/20] PCI: Print PF SR-IOV resource that contains all VF(n) BAR space Wei Yang
2015-03-25  8:23 ` [PATCH V16 03/20] PCI: Keep individual VF BAR size in struct pci_sriov Wei Yang
2015-03-25  8:23 ` [PATCH V16 04/20] PCI: Index IOV resources in the conventional style Wei Yang
2015-03-25  8:23 ` [PATCH V16 05/20] PCI: Refresh First VF Offset and VF Stride when updating NumVFs Wei Yang
2015-03-25  8:23 ` [PATCH V16 06/20] PCI: Calculate maximum number of buses required for VFs Wei Yang
2015-03-25  8:23 ` [PATCH V16 07/20] PCI: Export pci_iov_virtfn_bus() and pci_iov_virtfn_devfn() Wei Yang
2015-03-25  8:23 ` [PATCH V16 08/20] PCI: Add pcibios_sriov_enable() and pcibios_sriov_disable() Wei Yang
2015-03-25  8:23 ` [PATCH V16 09/20] PCI: Add pcibios_iov_resource_alignment() interface Wei Yang
2015-03-25  8:23 ` [PATCH V16 10/20] PCI: Consider additional PF's IOV BAR alignment in sizing and assigning Wei Yang
2015-03-25  8:23 ` [PATCH V16 11/20] powerpc/pci: Create pci_dn for VFs Wei Yang
2015-03-25  8:23 ` [PATCH V16 12/20] powerpc/pci: Don't unset PCI resources " Wei Yang
2015-03-25  8:23 ` [PATCH V16 13/20] powerpc/powernv: Allocate struct pnv_ioda_pe iommu_table dynamically Wei Yang
2015-03-25  8:23 ` [PATCH V16 14/20] powerpc/powernv: Reserve additional space for IOV BAR according to the number of total_pe Wei Yang
2015-03-25  8:23 ` [PATCH V16 15/20] powerpc/powernv: Implement pcibios_iov_resource_alignment() on powernv Wei Yang
2015-03-25  8:23 ` [PATCH V16 16/20] powerpc/powernv: Shift VF resource with an offset Wei Yang
2015-03-25  8:23 ` [PATCH V16 17/20] powerpc/powernv: Reserve additional space for IOV BAR, with m64_per_iov supported Wei Yang
2015-03-25  8:23 ` [PATCH V16 18/20] powerpc/powernv: Group VF PE when IOV BAR is big on PHB3 Wei Yang
2015-03-25  8:24 ` [PATCH V16 19/20] powerpc/pci: Remove unused struct pci_dn.pcidev field Wei Yang
2015-03-25  8:24 ` [PATCH V16 20/20] powerpc/pci: Add PCI resource alignment documentation Wei Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1427271841-28749-2-git-send-email-weiyang@linux.vnet.ibm.com \
    --to=weiyang@linux.vnet.ibm.com \
    --cc=benh@au1.ibm.com \
    --cc=bhelgaas@google.com \
    --cc=gwshan@linux.vnet.ibm.com \
    --cc=linux-pci@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).