linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2 0/6] pci.h/pci_ids.h related cleanups
@ 2015-03-30 10:59 Michael S. Tsirkin
  2015-03-30 10:59 ` [PATCH v2 1/6] crypto/ccp: drop linux/pci dependencies Michael S. Tsirkin
                   ` (5 more replies)
  0 siblings, 6 replies; 9+ messages in thread
From: Michael S. Tsirkin @ 2015-03-30 10:59 UTC (permalink / raw)
  To: linux-kernel; +Cc: Bjorn Helgaas, linux-pci

A bunch of drivers pull in linux/pci.h or linux/pci_ids.h without actually
using any PCI APIs.

Clean this up, drop the includes.

These patches were split out from bigger pci_ids.h exporting patchset.

I think the pci tree is easiest to use for these changes.
Please review, and consider for 4.1.

Changes from v1:
	patches are unchanged
	drop amd patch - applied on driver specific tree
	added acks for brcm80211

Michael S. Tsirkin (6):
  crypto/ccp: drop linux/pci dependencies
  input/serio: drop pci_ids dependency
  media/fintek: drop pci_ids dependency
  brcm80211: drop pci dependency
  brcm80211: drop pci_ids include
  staging/olpc: drop pci dependencies

 drivers/crypto/ccp/ccp-ops.c                     | 2 --
 drivers/input/serio/gscps2.c                     | 1 -
 drivers/media/rc/fintek-cir.c                    | 1 -
 drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c | 2 --
 drivers/net/wireless/brcm80211/brcmfmac/sdio.c   | 1 -
 drivers/staging/olpc_dcon/olpc_dcon.c            | 2 --
 6 files changed, 9 deletions(-)

-- 
MST


^ permalink raw reply	[flat|nested] 9+ messages in thread

* [PATCH v2 1/6] crypto/ccp: drop linux/pci dependencies
  2015-03-30 10:59 [PATCH v2 0/6] pci.h/pci_ids.h related cleanups Michael S. Tsirkin
@ 2015-03-30 10:59 ` Michael S. Tsirkin
  2015-03-30 10:59 ` [PATCH v2 2/6] input/serio: drop pci_ids dependency Michael S. Tsirkin
                   ` (4 subsequent siblings)
  5 siblings, 0 replies; 9+ messages in thread
From: Michael S. Tsirkin @ 2015-03-30 10:59 UTC (permalink / raw)
  To: linux-kernel
  Cc: Bjorn Helgaas, linux-pci, Tom Lendacky, Herbert Xu,
	David S. Miller, linux-crypto

pci code is in ccp-pci.c, don't include pci
headers from ccp/ccp-ops.c.

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
 drivers/crypto/ccp/ccp-ops.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/crypto/ccp/ccp-ops.c b/drivers/crypto/ccp/ccp-ops.c
index 8729364..3da1140 100644
--- a/drivers/crypto/ccp/ccp-ops.c
+++ b/drivers/crypto/ccp/ccp-ops.c
@@ -12,8 +12,6 @@
 
 #include <linux/module.h>
 #include <linux/kernel.h>
-#include <linux/pci.h>
-#include <linux/pci_ids.h>
 #include <linux/kthread.h>
 #include <linux/sched.h>
 #include <linux/interrupt.h>
-- 
MST


^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [PATCH v2 2/6] input/serio: drop pci_ids dependency
  2015-03-30 10:59 [PATCH v2 0/6] pci.h/pci_ids.h related cleanups Michael S. Tsirkin
  2015-03-30 10:59 ` [PATCH v2 1/6] crypto/ccp: drop linux/pci dependencies Michael S. Tsirkin
@ 2015-03-30 10:59 ` Michael S. Tsirkin
  2015-04-06 16:24   ` Dmitry Torokhov
  2015-03-30 10:59 ` [PATCH v2 3/6] media/fintek: " Michael S. Tsirkin
                   ` (3 subsequent siblings)
  5 siblings, 1 reply; 9+ messages in thread
From: Michael S. Tsirkin @ 2015-03-30 10:59 UTC (permalink / raw)
  To: linux-kernel
  Cc: Bjorn Helgaas, linux-pci, James E.J. Bottomley, Helge Deller,
	Dmitry Torokhov, linux-parisc, linux-input

This driver does not use any PCI IDs, don't include
the pci_ids.h header.

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
 drivers/input/serio/gscps2.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/input/serio/gscps2.c b/drivers/input/serio/gscps2.c
index 94ab494..ecba666 100644
--- a/drivers/input/serio/gscps2.c
+++ b/drivers/input/serio/gscps2.c
@@ -31,7 +31,6 @@
 #include <linux/spinlock.h>
 #include <linux/delay.h>
 #include <linux/ioport.h>
-#include <linux/pci_ids.h>
 
 #include <asm/irq.h>
 #include <asm/io.h>
-- 
MST


^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [PATCH v2 3/6] media/fintek: drop pci_ids dependency
  2015-03-30 10:59 [PATCH v2 0/6] pci.h/pci_ids.h related cleanups Michael S. Tsirkin
  2015-03-30 10:59 ` [PATCH v2 1/6] crypto/ccp: drop linux/pci dependencies Michael S. Tsirkin
  2015-03-30 10:59 ` [PATCH v2 2/6] input/serio: drop pci_ids dependency Michael S. Tsirkin
@ 2015-03-30 10:59 ` Michael S. Tsirkin
  2015-03-30 12:17   ` Mauro Carvalho Chehab
  2015-03-30 10:59 ` [PATCH v2 4/6] brcm80211: drop pci dependency Michael S. Tsirkin
                   ` (2 subsequent siblings)
  5 siblings, 1 reply; 9+ messages in thread
From: Michael S. Tsirkin @ 2015-03-30 10:59 UTC (permalink / raw)
  To: linux-kernel
  Cc: Bjorn Helgaas, linux-pci, Mauro Carvalho Chehab,
	=?UTF-8?q?David=20H=C3=A4rdeman?=, linux-media

This driver does not use any PCI IDs, don't include
the pci_ids.h header.

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
 drivers/media/rc/fintek-cir.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/media/rc/fintek-cir.c b/drivers/media/rc/fintek-cir.c
index b516757..9ca168a 100644
--- a/drivers/media/rc/fintek-cir.c
+++ b/drivers/media/rc/fintek-cir.c
@@ -33,7 +33,6 @@
 #include <linux/sched.h>
 #include <linux/slab.h>
 #include <media/rc-core.h>
-#include <linux/pci_ids.h>
 
 #include "fintek-cir.h"
 
-- 
MST


^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [PATCH v2 4/6] brcm80211: drop pci dependency
  2015-03-30 10:59 [PATCH v2 0/6] pci.h/pci_ids.h related cleanups Michael S. Tsirkin
                   ` (2 preceding siblings ...)
  2015-03-30 10:59 ` [PATCH v2 3/6] media/fintek: " Michael S. Tsirkin
@ 2015-03-30 10:59 ` Michael S. Tsirkin
  2015-03-30 10:59 ` [PATCH v2 5/6] brcm80211: drop pci_ids include Michael S. Tsirkin
  2015-03-30 10:59 ` [PATCH v2 6/6] staging/olpc: drop pci dependencies Michael S. Tsirkin
  5 siblings, 0 replies; 9+ messages in thread
From: Michael S. Tsirkin @ 2015-03-30 10:59 UTC (permalink / raw)
  To: linux-kernel
  Cc: Bjorn Helgaas, linux-pci, Arend van Spriel, Brett Rudley,
	Franky (Zhenhui) Lin, Hante Meuleman, Kalle Valo,
	Pieter-Paul Giesberts, John W. Linville, Wolfram Sang,
	Hans de Goede, Mika Westerberg, linux-wireless,
	brcm80211-dev-list, netdev

This file does not use any pci APIs, drop
pci header includes.

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Acked-by: Arend van Spriel <arend@broadcom.com>
---
 drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c b/drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c
index 7944224..9331486 100644
--- a/drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c
+++ b/drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c
@@ -17,8 +17,6 @@
 
 #include <linux/types.h>
 #include <linux/netdevice.h>
-#include <linux/pci.h>
-#include <linux/pci_ids.h>
 #include <linux/sched.h>
 #include <linux/completion.h>
 #include <linux/scatterlist.h>
-- 
MST


^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [PATCH v2 5/6] brcm80211: drop pci_ids include
  2015-03-30 10:59 [PATCH v2 0/6] pci.h/pci_ids.h related cleanups Michael S. Tsirkin
                   ` (3 preceding siblings ...)
  2015-03-30 10:59 ` [PATCH v2 4/6] brcm80211: drop pci dependency Michael S. Tsirkin
@ 2015-03-30 10:59 ` Michael S. Tsirkin
  2015-03-30 10:59 ` [PATCH v2 6/6] staging/olpc: drop pci dependencies Michael S. Tsirkin
  5 siblings, 0 replies; 9+ messages in thread
From: Michael S. Tsirkin @ 2015-03-30 10:59 UTC (permalink / raw)
  To: linux-kernel
  Cc: Bjorn Helgaas, linux-pci, Arend van Spriel, Brett Rudley,
	Franky (Zhenhui) Lin, Hante Meuleman, Kalle Valo,
	Pieter-Paul Giesberts, John W. Linville, Daniel Kim,
	linux-wireless, brcm80211-dev-list, netdev

This file does not use any pci ids, drop
pci_ids.h include.

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Acked-by: Arend van Spriel <arend@broadcom.com>
---
 drivers/net/wireless/brcm80211/brcmfmac/sdio.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/net/wireless/brcm80211/brcmfmac/sdio.c b/drivers/net/wireless/brcm80211/brcmfmac/sdio.c
index faec35c..da479d4 100644
--- a/drivers/net/wireless/brcm80211/brcmfmac/sdio.c
+++ b/drivers/net/wireless/brcm80211/brcmfmac/sdio.c
@@ -18,7 +18,6 @@
 #include <linux/kernel.h>
 #include <linux/kthread.h>
 #include <linux/printk.h>
-#include <linux/pci_ids.h>
 #include <linux/netdevice.h>
 #include <linux/interrupt.h>
 #include <linux/sched.h>
-- 
MST


^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [PATCH v2 6/6] staging/olpc: drop pci dependencies
  2015-03-30 10:59 [PATCH v2 0/6] pci.h/pci_ids.h related cleanups Michael S. Tsirkin
                   ` (4 preceding siblings ...)
  2015-03-30 10:59 ` [PATCH v2 5/6] brcm80211: drop pci_ids include Michael S. Tsirkin
@ 2015-03-30 10:59 ` Michael S. Tsirkin
  5 siblings, 0 replies; 9+ messages in thread
From: Michael S. Tsirkin @ 2015-03-30 10:59 UTC (permalink / raw)
  To: linux-kernel
  Cc: Bjorn Helgaas, linux-pci, Jens Frederich, Daniel Drake,
	Jon Nettleton, Greg Kroah-Hartman, devel

This file does not use any pci APIs, drop
pci header includes.

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
 drivers/staging/olpc_dcon/olpc_dcon.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/staging/olpc_dcon/olpc_dcon.c b/drivers/staging/olpc_dcon/olpc_dcon.c
index bc7e664..d115f5c 100644
--- a/drivers/staging/olpc_dcon/olpc_dcon.c
+++ b/drivers/staging/olpc_dcon/olpc_dcon.c
@@ -18,8 +18,6 @@
 #include <linux/console.h>
 #include <linux/i2c.h>
 #include <linux/platform_device.h>
-#include <linux/pci.h>
-#include <linux/pci_ids.h>
 #include <linux/interrupt.h>
 #include <linux/delay.h>
 #include <linux/module.h>
-- 
MST


^ permalink raw reply related	[flat|nested] 9+ messages in thread

* Re: [PATCH v2 3/6] media/fintek: drop pci_ids dependency
  2015-03-30 10:59 ` [PATCH v2 3/6] media/fintek: " Michael S. Tsirkin
@ 2015-03-30 12:17   ` Mauro Carvalho Chehab
  0 siblings, 0 replies; 9+ messages in thread
From: Mauro Carvalho Chehab @ 2015-03-30 12:17 UTC (permalink / raw)
  To: Michael S. Tsirkin
  Cc: linux-kernel, Bjorn Helgaas, linux-pci, David Härdeman,
	linux-media

Em Mon, 30 Mar 2015 12:59:32 +0200
"Michael S. Tsirkin" <mst@redhat.com> escreveu:

> This driver does not use any PCI IDs, don't include
> the pci_ids.h header.
> 
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>

Yeah, someone just cut and paste the dependencies from some other IR driver
without checking.

Acked-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>

> ---
>  drivers/media/rc/fintek-cir.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/media/rc/fintek-cir.c b/drivers/media/rc/fintek-cir.c
> index b516757..9ca168a 100644
> --- a/drivers/media/rc/fintek-cir.c
> +++ b/drivers/media/rc/fintek-cir.c
> @@ -33,7 +33,6 @@
>  #include <linux/sched.h>
>  #include <linux/slab.h>
>  #include <media/rc-core.h>
> -#include <linux/pci_ids.h>
>  
>  #include "fintek-cir.h"
>  


-- 

Cheers,
Mauro

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH v2 2/6] input/serio: drop pci_ids dependency
  2015-03-30 10:59 ` [PATCH v2 2/6] input/serio: drop pci_ids dependency Michael S. Tsirkin
@ 2015-04-06 16:24   ` Dmitry Torokhov
  0 siblings, 0 replies; 9+ messages in thread
From: Dmitry Torokhov @ 2015-04-06 16:24 UTC (permalink / raw)
  To: Michael S. Tsirkin
  Cc: linux-kernel, Bjorn Helgaas, linux-pci, James E.J. Bottomley,
	Helge Deller, linux-parisc, linux-input

On Mon, Mar 30, 2015 at 12:59:27PM +0200, Michael S. Tsirkin wrote:
> This driver does not use any PCI IDs, don't include
> the pci_ids.h header.
> 
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>

Applied, thank you.

> ---
>  drivers/input/serio/gscps2.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/input/serio/gscps2.c b/drivers/input/serio/gscps2.c
> index 94ab494..ecba666 100644
> --- a/drivers/input/serio/gscps2.c
> +++ b/drivers/input/serio/gscps2.c
> @@ -31,7 +31,6 @@
>  #include <linux/spinlock.h>
>  #include <linux/delay.h>
>  #include <linux/ioport.h>
> -#include <linux/pci_ids.h>
>  
>  #include <asm/irq.h>
>  #include <asm/io.h>
> -- 
> MST
> 

-- 
Dmitry

^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2015-04-06 16:24 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-30 10:59 [PATCH v2 0/6] pci.h/pci_ids.h related cleanups Michael S. Tsirkin
2015-03-30 10:59 ` [PATCH v2 1/6] crypto/ccp: drop linux/pci dependencies Michael S. Tsirkin
2015-03-30 10:59 ` [PATCH v2 2/6] input/serio: drop pci_ids dependency Michael S. Tsirkin
2015-04-06 16:24   ` Dmitry Torokhov
2015-03-30 10:59 ` [PATCH v2 3/6] media/fintek: " Michael S. Tsirkin
2015-03-30 12:17   ` Mauro Carvalho Chehab
2015-03-30 10:59 ` [PATCH v2 4/6] brcm80211: drop pci dependency Michael S. Tsirkin
2015-03-30 10:59 ` [PATCH v2 5/6] brcm80211: drop pci_ids include Michael S. Tsirkin
2015-03-30 10:59 ` [PATCH v2 6/6] staging/olpc: drop pci dependencies Michael S. Tsirkin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).