From: Jean Delvare <jdelvare@suse.de>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Christoph Hellwig <hch@infradead.org>,
linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
Bjorn Helgaas <bhelgaas@google.com>,
Dave Jones <davej@redhat.com>,
Jesse Barnes <jbarnes@virtuousgeek.org>
Subject: Re: [PATCH 00/86] pci: export pci_ids.h and related cleanups
Date: Thu, 02 Apr 2015 13:15:30 +0200 [thread overview]
Message-ID: <1427973330.4063.1410.camel@chaos.site> (raw)
In-Reply-To: <20150402120711-mutt-send-email-mst@redhat.com>
Le Thursday 02 April 2015 à 12:09 +0200, Michael S. Tsirkin a écrit :
> On Thu, Apr 02, 2015 at 11:04:16AM +0200, Jean Delvare wrote:
> > Le Thursday 02 April 2015 à 01:23 -0700, Christoph Hellwig a écrit :
> > > The class ids are a hardware defintion, not a kernel API. Just use the
> > > definitions from libpci, or copy over the kernel header if you prefer
> > > it over the libpci definutions.
> >
> > I agree with Christoph, such defines would better come from
> > pciutils-devel, not the kernel.
>
> This just leads to code duplication. Projects that don't link with
> pciutils don't want to depend on it.
Well, they don't have to depend on anything then, they can keep defining
their own named IDs.
Please realize that 1* code duplication is impossible to avoid
completely and 2* this hardly qualifies as code duplication in the first
place (giving symbolic names to constants is not actual programming.)
--
Jean Delvare
SUSE L3 Support
next prev parent reply other threads:[~2015-04-02 11:15 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-29 13:36 [PATCH 00/86] pci: export pci_ids.h and related cleanups Michael S. Tsirkin
2015-03-29 13:37 ` [PATCH 01/86] pci: export pci_ids.h Michael S. Tsirkin
2015-03-29 15:49 ` Joe Perches
2015-03-29 20:40 ` Greg KH
2015-03-30 6:48 ` Michael S. Tsirkin
2015-03-30 6:55 ` Greg KH
2015-03-30 7:15 ` Michael S. Tsirkin
2015-03-30 7:53 ` Greg KH
2015-03-30 8:31 ` Michael S. Tsirkin
2015-03-30 10:07 ` Greg KH
2015-03-30 10:46 ` Michael S. Tsirkin
2015-03-30 10:57 ` Greg KH
2015-03-30 11:19 ` Michael S. Tsirkin
2015-03-30 11:35 ` Greg KH
2015-03-30 11:41 ` Michael S. Tsirkin
2015-03-29 13:38 ` [PATCH 12/86] x86/pci/sta2x11: use uapi/linux/pci_ids.h directly Michael S. Tsirkin
2015-03-29 13:41 ` [PATCH 58/86] pci-label: " Michael S. Tsirkin
2015-03-29 13:43 ` [PATCH 77/86] linux/pci: " Michael S. Tsirkin
2015-03-29 13:43 ` [PATCH 78/86] linux/pci: drop include/linux/pci_ids.h Michael S. Tsirkin
2015-03-29 17:59 ` [PATCH 00/86] pci: export pci_ids.h and related cleanups Joe Perches
2015-03-30 6:52 ` Michael S. Tsirkin
2015-03-29 23:15 ` Stefan Richter
2015-04-02 7:44 ` Jean Delvare
2015-04-02 7:49 ` Michael S. Tsirkin
2015-04-02 8:23 ` Christoph Hellwig
2015-04-02 9:04 ` Jean Delvare
2015-04-02 10:09 ` Michael S. Tsirkin
2015-04-02 11:15 ` Jean Delvare [this message]
2015-04-02 12:05 ` Michael S. Tsirkin
2015-04-02 13:17 ` Jean Delvare
2015-04-02 12:09 ` Michael S. Tsirkin
2015-04-02 14:34 ` Alex Williamson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1427973330.4063.1410.camel@chaos.site \
--to=jdelvare@suse.de \
--cc=bhelgaas@google.com \
--cc=davej@redhat.com \
--cc=hch@infradead.org \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mst@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).