From: Alex Williamson <alex.williamson@redhat.com>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] PCI: Export pci_probe_reset_function()
Date: Thu, 09 Apr 2015 14:11:26 -0600 [thread overview]
Message-ID: <1428610286.5567.606.camel@redhat.com> (raw)
In-Reply-To: <20150409200048.GM30967@google.com>
On Thu, 2015-04-09 at 15:00 -0500, Bjorn Helgaas wrote:
> On Thu, Apr 09, 2015 at 02:58:46PM -0500, Bjorn Helgaas wrote:
> > On Thu, Apr 09, 2015 at 09:51:43AM -0600, Alex Williamson wrote:
> > > The equivalent bus and slot versions of this are already exported and
> > > vfio-pci would like a function-probe available so we can expose
> > > function-level reset capabilities to the user without necessarily
> > > using it to perform a reset before enabling the device for the user.
> > >
> > > Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
> >
> > Applied to pci/virtualization for v4.1, thanks!
>
> Actually, maybe it makes more sense for you to apply this along with the
> vfio patch that uses it? So if you want:
>
> Acked-by: Bjorn Helgaas <bhelgaas@google.com>
That would be more convenient, I'll take it. Thanks!
Alex
> > > ---
> > > drivers/pci/pci.c | 1 +
> > > include/linux/pci.h | 1 +
> > > 2 files changed, 2 insertions(+)
> > >
> > > diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
> > > index 81f06e8..9f3e691 100644
> > > --- a/drivers/pci/pci.c
> > > +++ b/drivers/pci/pci.c
> > > @@ -3524,6 +3524,7 @@ int pci_probe_reset_function(struct pci_dev *dev)
> > > {
> > > return pci_dev_reset(dev, 1);
> > > }
> > > +EXPORT_SYMBOL_GPL(pci_probe_reset_function);
> > >
> > > /**
> > > * pci_reset_function - quiesce and reset a PCI device function
> > > diff --git a/include/linux/pci.h b/include/linux/pci.h
> > > index 211e9da..233d1ae 100644
> > > --- a/include/linux/pci.h
> > > +++ b/include/linux/pci.h
> > > @@ -986,6 +986,7 @@ int pcie_get_minimum_link(struct pci_dev *dev, enum pci_bus_speed *speed,
> > > enum pcie_link_width *width);
> > > int __pci_reset_function(struct pci_dev *dev);
> > > int __pci_reset_function_locked(struct pci_dev *dev);
> > > +int pci_probe_reset_function(struct pci_dev *dev);
> > > int pci_reset_function(struct pci_dev *dev);
> > > int pci_try_reset_function(struct pci_dev *dev);
> > > int pci_probe_reset_slot(struct pci_slot *slot);
> > >
prev parent reply other threads:[~2015-04-09 20:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-09 15:51 [PATCH] PCI: Export pci_probe_reset_function() Alex Williamson
2015-04-09 19:58 ` Bjorn Helgaas
2015-04-09 20:00 ` Bjorn Helgaas
2015-04-09 20:11 ` Alex Williamson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1428610286.5567.606.camel@redhat.com \
--to=alex.williamson@redhat.com \
--cc=bhelgaas@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).