From: Paul Bolle <pebolle@tiscali.nl>
To: Allen Hubbe <Allen.Hubbe@emc.com>
Cc: linux-ntb@googlegroups.com, linux-kernel@vger.kernel.org,
linux-pci@vger.kernel.org, Jon Mason <jdmason@kudzu.us>,
Dave Jiang <dave.jiang@intel.com>
Subject: Re: [PATCH 02/16] NTB Abstraction Layer
Date: Thu, 21 May 2015 10:51:56 +0200 [thread overview]
Message-ID: <1432198316.21715.135.camel@x220> (raw)
In-Reply-To: <d653819e0ebc03241fe073c9239be36a52f5e265.1432135631.git.Allen.Hubbe@emc.com>
On Wed, 2015-05-20 at 11:41 -0400, Allen Hubbe wrote:
> Documentation/ntb.txt | 58 +
> MAINTAINERS | 14 +-
> drivers/net/ntb_netdev.c | 58 +-
> drivers/ntb/Kconfig | 20 +-
> drivers/ntb/Makefile | 4 +-
> drivers/ntb/hw/Kconfig | 1 +
> drivers/ntb/hw/Makefile | 1 +
> drivers/ntb/hw/intel/Kconfig | 8 +
> drivers/ntb/hw/intel/Makefile | 1 +
> drivers/ntb/hw/intel/ntb_hw_intel.c | 3108 +++++++++++++++++++----------------
> drivers/ntb/hw/intel/ntb_hw_intel.h | 591 +++----
> drivers/ntb/ntb.c | 251 +++
> drivers/ntb/ntb_transport.c | 927 ++++++-----
> include/linux/ntb.h | 983 +++++++++++
> include/linux/ntb_transport.h | 25 +-
> 15 files changed, 3873 insertions(+), 2177 deletions(-)
> create mode 100644 Documentation/ntb.txt
> create mode 100644 drivers/ntb/hw/Kconfig
> create mode 100644 drivers/ntb/hw/Makefile
> create mode 100644 drivers/ntb/hw/intel/Kconfig
> create mode 100644 drivers/ntb/hw/intel/Makefile
> create mode 100644 drivers/ntb/ntb.c
> create mode 100644 include/linux/ntb.h
(My mailer tells me this message is over 200KB in size. Did you consider
offering bribes to get people to review this patch?)
I just spotted two nits.
> --- a/drivers/ntb/Kconfig
> +++ b/drivers/ntb/Kconfig
>
> +if NTB
> +
> +source "drivers/ntb/hw/Kconfig"
> +
> +config NTB_TRANSPORT
> + tristate "NTB Transport Client"
> + depends on NTB
Superfluous dependency.
> + help
> + This is a transport driver that enables connected systems to exchange
> + messages over the ntb hardware. The transport exposes a queue pair api
> + to client drivers.
> +
> + If unsure, say N.
> +
> +endif # NTB
> --- /dev/null
> +++ b/drivers/ntb/hw/intel/Kconfig
> +config NTB_INTEL
> + tristate "Intel Non-Transparent Bridge support"
> + depends on NTB
Ditto.
> + depends on X86
> + help
> + This driver supports Intel NTB on capable Xeon and Atom hardware.
> +
> + If unsure, say N.
Thanks,
Paul Bolle
next prev parent reply other threads:[~2015-05-21 8:52 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-20 15:41 [PATCH 00/16] ntb: NTB Abstraction Layer Allen Hubbe
2015-05-20 15:41 ` [PATCH 01/16] Move files in preparation for NTB Abstraction Allen Hubbe
2015-05-20 15:41 ` [PATCH 02/16] NTB Abstraction Layer Allen Hubbe
2015-05-21 8:51 ` Paul Bolle [this message]
2015-05-21 11:32 ` Hubbe, Allen
2015-05-20 15:41 ` [PATCH 03/16] ntb: Enable link training for RP mode in the driver probe Allen Hubbe
2015-05-20 21:21 ` Bjorn Helgaas
2015-05-20 21:46 ` Hubbe, Allen
2015-05-20 22:20 ` Bjorn Helgaas
2015-05-20 23:00 ` Hubbe, Allen
2015-05-21 12:06 ` Bjorn Helgaas
2015-05-21 12:49 ` Hubbe, Allen
2015-05-20 15:41 ` [PATCH 04/16] Check the DID for certain workaround error flags to be set Allen Hubbe
2015-05-20 21:11 ` Bjorn Helgaas
2015-05-20 21:15 ` Jiang, Dave
2015-05-20 21:26 ` Hubbe, Allen
2015-05-20 15:41 ` [PATCH 05/16] Intel NTB params for snb b2b addresses Allen Hubbe
2015-05-20 15:41 ` [PATCH 06/16] NTB Pingpong Client Allen Hubbe
2015-05-21 8:54 ` Paul Bolle
2015-05-20 15:41 ` [PATCH 07/16] NTB Tool Client Allen Hubbe
2015-05-21 9:02 ` Paul Bolle
2015-05-20 15:41 ` [PATCH 08/16] ntb_transport: rate limit ntb_qp_link_work Allen Hubbe
2015-05-20 15:41 ` [PATCH 09/16] ntb_transport: differentiate link down messages Allen Hubbe
2015-05-20 15:41 ` [PATCH 10/16] ntb_transport: don't advance rx on link down Allen Hubbe
2015-05-20 15:41 ` [PATCH 11/16] ntb_transport: reset qp link stats on down Allen Hubbe
2015-05-20 15:41 ` [PATCH 12/16] ntb_transport: numa aware memory and dma chan Allen Hubbe
2015-05-20 15:41 ` [PATCH 13/16] ntb_hw_intel: numa aware memory allocation Allen Hubbe
2015-05-20 15:41 ` [PATCH 14/16] ntb: performance improvement by write combining Allen Hubbe
2015-05-20 15:41 ` [PATCH 15/16] ntb: default to cpu memcpy for performance Allen Hubbe
2015-05-20 15:41 ` [PATCH 16/16] ntb_transport: fix small code format issues Allen Hubbe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1432198316.21715.135.camel@x220 \
--to=pebolle@tiscali.nl \
--cc=Allen.Hubbe@emc.com \
--cc=dave.jiang@intel.com \
--cc=jdmason@kudzu.us \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-ntb@googlegroups.com \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).