* [PATCH] ACPI / PCI: remove stale list_head in struct acpi_prt_entry
@ 2015-05-21 13:52 Hanjun Guo
2015-05-21 15:10 ` Bjorn Helgaas
0 siblings, 1 reply; 6+ messages in thread
From: Hanjun Guo @ 2015-05-21 13:52 UTC (permalink / raw)
To: Bjorn Helgaas, Rafael J. Wysocki
Cc: linux-acpi, linux-pci, Hanjun Guo, Yinghai Lu, Yijing Wang
list_head "list" in struct acpi_prt_entry was used to connect
_PRT entries for PCI irq, but after commit 181380b7 (PCI/ACPI:
Don't cache _PRT, and don't associate them with bus numbers),
the list head for _PRT entries was removed, but left "list" in
struct acpi_prt_entry which is useless and stale, remove it now.
Signed-off-by: Hanjun Guo <hanjun.guo@linaro.org>
CC: Yinghai Lu <yinghai@kernel.org>
CC: Yijing Wang <wangyijing@huawei.com>
---
drivers/acpi/pci_irq.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/acpi/pci_irq.c b/drivers/acpi/pci_irq.c
index b1def41..03e4b6c 100644
--- a/drivers/acpi/pci_irq.c
+++ b/drivers/acpi/pci_irq.c
@@ -44,7 +44,6 @@
ACPI_MODULE_NAME("pci_irq");
struct acpi_prt_entry {
- struct list_head list;
struct acpi_pci_id id;
u8 pin;
acpi_handle link;
--
1.7.12.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] ACPI / PCI: remove stale list_head in struct acpi_prt_entry
2015-05-21 13:52 [PATCH] ACPI / PCI: remove stale list_head in struct acpi_prt_entry Hanjun Guo
@ 2015-05-21 15:10 ` Bjorn Helgaas
2015-05-21 15:17 ` Hanjun Guo
0 siblings, 1 reply; 6+ messages in thread
From: Bjorn Helgaas @ 2015-05-21 15:10 UTC (permalink / raw)
To: Hanjun Guo
Cc: Rafael J. Wysocki, linux-acpi@vger.kernel.org,
linux-pci@vger.kernel.org, Yinghai Lu, Yijing Wang
On Thu, May 21, 2015 at 8:52 AM, Hanjun Guo <hanjun.guo@linaro.org> wrote:
> list_head "list" in struct acpi_prt_entry was used to connect
> _PRT entries for PCI irq, but after commit 181380b7 (PCI/ACPI:
> Don't cache _PRT, and don't associate them with bus numbers),
> the list head for _PRT entries was removed, but left "list" in
> struct acpi_prt_entry which is useless and stale, remove it now.
Please use the canonical commit reference format, i.e.,
181380b702ee ("PCI/ACPI: Don't cache _PRT, and don't associate them
with bus numbers")
> Signed-off-by: Hanjun Guo <hanjun.guo@linaro.org>
> CC: Yinghai Lu <yinghai@kernel.org>
> CC: Yijing Wang <wangyijing@huawei.com>
Acked-by: Bjorn Helgaas <bhelgaas@google.com>
> ---
> drivers/acpi/pci_irq.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/acpi/pci_irq.c b/drivers/acpi/pci_irq.c
> index b1def41..03e4b6c 100644
> --- a/drivers/acpi/pci_irq.c
> +++ b/drivers/acpi/pci_irq.c
> @@ -44,7 +44,6 @@
> ACPI_MODULE_NAME("pci_irq");
>
> struct acpi_prt_entry {
> - struct list_head list;
> struct acpi_pci_id id;
> u8 pin;
> acpi_handle link;
> --
> 1.7.12.4
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] ACPI / PCI: remove stale list_head in struct acpi_prt_entry
2015-05-21 15:10 ` Bjorn Helgaas
@ 2015-05-21 15:17 ` Hanjun Guo
2015-05-21 15:21 ` Bjorn Helgaas
0 siblings, 1 reply; 6+ messages in thread
From: Hanjun Guo @ 2015-05-21 15:17 UTC (permalink / raw)
To: Bjorn Helgaas
Cc: Rafael J. Wysocki, linux-acpi@vger.kernel.org,
linux-pci@vger.kernel.org, Yinghai Lu, Yijing Wang
On 2015年05月21日 23:10, Bjorn Helgaas wrote:
> On Thu, May 21, 2015 at 8:52 AM, Hanjun Guo <hanjun.guo@linaro.org> wrote:
>> list_head "list" in struct acpi_prt_entry was used to connect
>> _PRT entries for PCI irq, but after commit 181380b7 (PCI/ACPI:
>> Don't cache _PRT, and don't associate them with bus numbers),
>> the list head for _PRT entries was removed, but left "list" in
>> struct acpi_prt_entry which is useless and stale, remove it now.
>
> Please use the canonical commit reference format, i.e.,
>
> 181380b702ee ("PCI/ACPI: Don't cache _PRT, and don't associate them
> with bus numbers")
OK, now I know what is a canonical commit reference format :)
>
>> Signed-off-by: Hanjun Guo <hanjun.guo@linaro.org>
>> CC: Yinghai Lu <yinghai@kernel.org>
>> CC: Yijing Wang <wangyijing@huawei.com>
>
> Acked-by: Bjorn Helgaas <bhelgaas@google.com>
Thanks, will update the change log soon.
Hanjun
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] ACPI / PCI: remove stale list_head in struct acpi_prt_entry
2015-05-21 15:17 ` Hanjun Guo
@ 2015-05-21 15:21 ` Bjorn Helgaas
2015-05-21 15:53 ` Bjorn Helgaas
0 siblings, 1 reply; 6+ messages in thread
From: Bjorn Helgaas @ 2015-05-21 15:21 UTC (permalink / raw)
To: Hanjun Guo
Cc: Rafael J. Wysocki, linux-acpi@vger.kernel.org,
linux-pci@vger.kernel.org, Yinghai Lu, Yijing Wang
On Thu, May 21, 2015 at 10:17 AM, Hanjun Guo <hanjun.guo@linaro.org> wrote:
> On 2015年05月21日 23:10, Bjorn Helgaas wrote:
>>
>> On Thu, May 21, 2015 at 8:52 AM, Hanjun Guo <hanjun.guo@linaro.org> wrote:
>>>
>>> list_head "list" in struct acpi_prt_entry was used to connect
>>> _PRT entries for PCI irq, but after commit 181380b7 (PCI/ACPI:
>>> Don't cache _PRT, and don't associate them with bus numbers),
>>> the list head for _PRT entries was removed, but left "list" in
>>> struct acpi_prt_entry which is useless and stale, remove it now.
>>
>>
>> Please use the canonical commit reference format, i.e.,
>>
>> 181380b702ee ("PCI/ACPI: Don't cache _PRT, and don't associate them
>> with bus numbers")
>
>
> OK, now I know what is a canonical commit reference format :)
Yeah, it'd be nice if that were better documented. checkpatch
complains about it (d311cd44545f ("checkpatch: add test for commit id
formatting style in commit log")), but unfortunately I don't think
it's mentioned anywhere in Documentation/
Bjorn
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] ACPI / PCI: remove stale list_head in struct acpi_prt_entry
2015-05-21 15:21 ` Bjorn Helgaas
@ 2015-05-21 15:53 ` Bjorn Helgaas
2015-05-22 11:04 ` Hanjun Guo
0 siblings, 1 reply; 6+ messages in thread
From: Bjorn Helgaas @ 2015-05-21 15:53 UTC (permalink / raw)
To: Hanjun Guo
Cc: Rafael J. Wysocki, linux-acpi@vger.kernel.org,
linux-pci@vger.kernel.org, Yinghai Lu, Yijing Wang
On Thu, May 21, 2015 at 10:21 AM, Bjorn Helgaas <bhelgaas@google.com> wrote:
> On Thu, May 21, 2015 at 10:17 AM, Hanjun Guo <hanjun.guo@linaro.org> wrote:
>> On 2015年05月21日 23:10, Bjorn Helgaas wrote:
>>>
>>> On Thu, May 21, 2015 at 8:52 AM, Hanjun Guo <hanjun.guo@linaro.org> wrote:
>>>>
>>>> list_head "list" in struct acpi_prt_entry was used to connect
>>>> _PRT entries for PCI irq, but after commit 181380b7 (PCI/ACPI:
>>>> Don't cache _PRT, and don't associate them with bus numbers),
>>>> the list head for _PRT entries was removed, but left "list" in
>>>> struct acpi_prt_entry which is useless and stale, remove it now.
>>>
>>>
>>> Please use the canonical commit reference format, i.e.,
>>>
>>> 181380b702ee ("PCI/ACPI: Don't cache _PRT, and don't associate them
>>> with bus numbers")
>>
>>
>> OK, now I know what is a canonical commit reference format :)
>
> Yeah, it'd be nice if that were better documented. checkpatch
> complains about it (d311cd44545f ("checkpatch: add test for commit id
> formatting style in commit log")), but unfortunately I don't think
> it's mentioned anywhere in Documentation/
I guess it actually *is* mentioned:
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/SubmittingPatches#n171,
but it's a little bit wishy-washy. I'll propose a tweak.
Bjorn
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] ACPI / PCI: remove stale list_head in struct acpi_prt_entry
2015-05-21 15:53 ` Bjorn Helgaas
@ 2015-05-22 11:04 ` Hanjun Guo
0 siblings, 0 replies; 6+ messages in thread
From: Hanjun Guo @ 2015-05-22 11:04 UTC (permalink / raw)
To: Bjorn Helgaas
Cc: Rafael J. Wysocki, linux-acpi@vger.kernel.org,
linux-pci@vger.kernel.org, Yinghai Lu, Yijing Wang
On 2015年05月21日 23:53, Bjorn Helgaas wrote:
> On Thu, May 21, 2015 at 10:21 AM, Bjorn Helgaas <bhelgaas@google.com> wrote:
>> On Thu, May 21, 2015 at 10:17 AM, Hanjun Guo <hanjun.guo@linaro.org> wrote:
>>> On 2015年05月21日 23:10, Bjorn Helgaas wrote:
>>>>
>>>> On Thu, May 21, 2015 at 8:52 AM, Hanjun Guo <hanjun.guo@linaro.org> wrote:
>>>>>
>>>>> list_head "list" in struct acpi_prt_entry was used to connect
>>>>> _PRT entries for PCI irq, but after commit 181380b7 (PCI/ACPI:
>>>>> Don't cache _PRT, and don't associate them with bus numbers),
>>>>> the list head for _PRT entries was removed, but left "list" in
>>>>> struct acpi_prt_entry which is useless and stale, remove it now.
>>>>
>>>>
>>>> Please use the canonical commit reference format, i.e.,
>>>>
>>>> 181380b702ee ("PCI/ACPI: Don't cache _PRT, and don't associate them
>>>> with bus numbers")
>>>
>>>
>>> OK, now I know what is a canonical commit reference format :)
>>
>> Yeah, it'd be nice if that were better documented. checkpatch
>> complains about it (d311cd44545f ("checkpatch: add test for commit id
>> formatting style in commit log")), but unfortunately I don't think
>> it's mentioned anywhere in Documentation/
>
> I guess it actually *is* mentioned:
> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/SubmittingPatches#n171,
> but it's a little bit wishy-washy. I'll propose a tweak.
Thanks for the guidance :)
Hanjun
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-05-22 11:04 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-05-21 13:52 [PATCH] ACPI / PCI: remove stale list_head in struct acpi_prt_entry Hanjun Guo
2015-05-21 15:10 ` Bjorn Helgaas
2015-05-21 15:17 ` Hanjun Guo
2015-05-21 15:21 ` Bjorn Helgaas
2015-05-21 15:53 ` Bjorn Helgaas
2015-05-22 11:04 ` Hanjun Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).