From: Jiang Liu <jiang.liu@linux.intel.com>
To: Thomas Gleixner <tglx@linutronix.de>,
Bjorn Helgaas <bhelgaas@google.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
Randy Dunlap <rdunlap@infradead.org>,
Yinghai Lu <yinghai@kernel.org>, Borislav Petkov <bp@alien8.de>
Cc: Jiang Liu <jiang.liu@linux.intel.com>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
Tony Luck <tony.luck@intel.com>,
x86@kernel.org, linux-kernel@vger.kernel.org,
linux-pci@vger.kernel.org, linux-acpi@vger.kernel.org
Subject: [RFT v2 19/48] genirq: Change prototypes of register_irq_proc() and friends
Date: Thu, 4 Jun 2015 12:13:29 +0800 [thread overview]
Message-ID: <1433391238-19471-20-git-send-email-jiang.liu@linux.intel.com> (raw)
In-Reply-To: <1433391238-19471-1-git-send-email-jiang.liu@linux.intel.com>
Change prototypes of register_irq_proc() and friends, so we either
passing 'irq' or 'irq_desc', but not both.
Signed-off-by: Jiang Liu <jiang.liu@linux.intel.com>
---
kernel/irq/internals.h | 18 ++++++++++--------
kernel/irq/irqdesc.c | 2 +-
kernel/irq/manage.c | 8 ++++----
kernel/irq/proc.c | 16 ++++++++--------
4 files changed, 23 insertions(+), 21 deletions(-)
diff --git a/kernel/irq/internals.h b/kernel/irq/internals.h
index 3d274e2fe605..ed0388b754fa 100644
--- a/kernel/irq/internals.h
+++ b/kernel/irq/internals.h
@@ -94,16 +94,18 @@ bool irq_wait_for_poll(struct irq_desc *desc);
void __irq_wake_thread(struct irq_desc *desc, struct irqaction *action);
#ifdef CONFIG_PROC_FS
-extern void register_irq_proc(unsigned int irq, struct irq_desc *desc);
-extern void unregister_irq_proc(unsigned int irq, struct irq_desc *desc);
-extern void register_handler_proc(unsigned int irq, struct irqaction *action);
-extern void unregister_handler_proc(unsigned int irq, struct irqaction *action);
+extern void register_irq_proc(struct irq_desc *desc);
+extern void unregister_irq_proc(struct irq_desc *desc);
+extern void register_handler_proc(struct irq_desc *desc,
+ struct irqaction *action);
+extern void unregister_handler_proc(struct irq_desc *desc,
+ struct irqaction *action);
#else
-static inline void register_irq_proc(unsigned int irq, struct irq_desc *desc) { }
-static inline void unregister_irq_proc(unsigned int irq, struct irq_desc *desc) { }
-static inline void register_handler_proc(unsigned int irq,
+static inline void register_irq_proc(struct irq_desc *desc) { }
+static inline void unregister_irq_proc(struct irq_desc *desc) { }
+static inline void register_handler_proc(struct irq_desc *desc,
struct irqaction *action) { }
-static inline void unregister_handler_proc(unsigned int irq,
+static inline void unregister_handler_proc(struct irq_desc *desc,
struct irqaction *action) { }
#endif
diff --git a/kernel/irq/irqdesc.c b/kernel/irq/irqdesc.c
index 500e6fd11d78..969f7e252846 100644
--- a/kernel/irq/irqdesc.c
+++ b/kernel/irq/irqdesc.c
@@ -175,7 +175,7 @@ static void free_desc(unsigned int irq)
{
struct irq_desc *desc = irq_to_desc(irq);
- unregister_irq_proc(irq, desc);
+ unregister_irq_proc(desc);
/*
* sparse_irq_lock protects also show_interrupts() and
diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c
index 32567d4d7031..e478a0f25bd6 100644
--- a/kernel/irq/manage.c
+++ b/kernel/irq/manage.c
@@ -1293,9 +1293,9 @@ __setup_irq(unsigned int irq, struct irq_desc *desc, struct irqaction *new)
if (new->thread)
wake_up_process(new->thread);
- register_irq_proc(irq, desc);
+ register_irq_proc(desc);
new->dir = NULL;
- register_handler_proc(irq, new);
+ register_handler_proc(desc, new);
free_cpumask_var(mask);
return 0;
@@ -1405,7 +1405,7 @@ static struct irqaction *__free_irq(unsigned int irq, void *dev_id)
raw_spin_unlock_irqrestore(&desc->lock, flags);
- unregister_handler_proc(irq, action);
+ unregister_handler_proc(desc, action);
/* Make sure it's not being used on another CPU: */
synchronize_irq(irq);
@@ -1712,7 +1712,7 @@ static struct irqaction *__free_percpu_irq(unsigned int irq, void __percpu *dev_
raw_spin_unlock_irqrestore(&desc->lock, flags);
- unregister_handler_proc(irq, action);
+ unregister_handler_proc(desc, action);
module_put(desc->owner);
return action;
diff --git a/kernel/irq/proc.c b/kernel/irq/proc.c
index e3a8c9577ba6..3e2514b47367 100644
--- a/kernel/irq/proc.c
+++ b/kernel/irq/proc.c
@@ -301,13 +301,12 @@ static int name_unique(unsigned int irq, struct irqaction *new_action)
return ret;
}
-void register_handler_proc(unsigned int irq, struct irqaction *action)
+void register_handler_proc(struct irq_desc *desc, struct irqaction *action)
{
char name [MAX_NAMELEN];
- struct irq_desc *desc = irq_to_desc(irq);
if (!desc->dir || action->dir || !action->name ||
- !name_unique(irq, action))
+ !name_unique(irq_desc_get_irq(desc), action))
return;
memset(name, 0, MAX_NAMELEN);
@@ -321,9 +320,10 @@ void register_handler_proc(unsigned int irq, struct irqaction *action)
#define MAX_NAMELEN 10
-void register_irq_proc(unsigned int irq, struct irq_desc *desc)
+void register_irq_proc(struct irq_desc *desc)
{
char name [MAX_NAMELEN];
+ unsigned int irq = irq_desc_get_irq(desc);
if (!root_irq_dir || (desc->irq_data.chip == &no_irq_chip) || desc->dir)
return;
@@ -357,7 +357,7 @@ void register_irq_proc(unsigned int irq, struct irq_desc *desc)
&irq_spurious_proc_fops, (void *)(long)irq);
}
-void unregister_irq_proc(unsigned int irq, struct irq_desc *desc)
+void unregister_irq_proc(struct irq_desc *desc)
{
char name [MAX_NAMELEN];
@@ -372,13 +372,13 @@ void unregister_irq_proc(unsigned int irq, struct irq_desc *desc)
remove_proc_entry("spurious", desc->dir);
memset(name, 0, MAX_NAMELEN);
- sprintf(name, "%u", irq);
+ sprintf(name, "%u", irq_desc_get_irq(desc));
remove_proc_entry(name, root_irq_dir);
}
#undef MAX_NAMELEN
-void unregister_handler_proc(unsigned int irq, struct irqaction *action)
+void unregister_handler_proc(struct irq_desc *desc, struct irqaction *action)
{
proc_remove(action->dir);
}
@@ -410,7 +410,7 @@ void init_irq_proc(void)
if (!desc)
continue;
- register_irq_proc(irq, desc);
+ register_irq_proc(desc);
}
}
--
1.7.10.4
next prev parent reply other threads:[~2015-06-04 4:13 UTC|newest]
Thread overview: 76+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-04 4:13 [RFT v2 00/48] Refine irq interfaces to reduce number of parameters Jiang Liu
2015-06-04 4:13 ` [RFT v2 01/48] genirq: Clean up outdated comments related to include/linux/irqdesc.h Jiang Liu
2015-06-04 4:13 ` [RFT v2 02/48] genirq: Kill never used irq_node() Jiang Liu
2015-06-04 4:13 ` [RFT v2 03/48] MIPS, irq: Use irq_desc_get_xxx() to avoid redundant lookup of irq_desc Jiang Liu
2015-06-04 12:15 ` Sergey Ryazanov
2015-06-04 4:13 ` [RFT v2 04/48] powerpc, " Jiang Liu
2015-06-04 4:13 ` [RFT v2 05/48] gpio: " Jiang Liu
2015-06-04 6:20 ` Javier Martinez Canillas
2015-06-04 4:13 ` [RFT v2 06/48] pinctrl: " Jiang Liu
2015-06-05 3:06 ` Tomasz Figa
2015-06-10 8:39 ` Heiko Stübner
2015-06-10 10:29 ` Matthias Brugger
2015-06-04 4:13 ` [RFT v2 07/48] avr32, irq: " Jiang Liu
2015-06-04 4:13 ` [RFT v2 08/48] mfd: " Jiang Liu
2015-06-04 4:13 ` [RFT v2 09/48] ARM, irq: " Jiang Liu
2015-06-04 4:13 ` [RFT v2 10/48] irqchip: " Jiang Liu
2015-06-04 4:50 ` Krzysztof Kozlowski
2015-06-04 4:13 ` [RFT v2 11/48] ipu: " Jiang Liu
2015-06-08 11:16 ` Vinod Koul
2015-06-08 11:37 ` Jiang Liu
2015-06-04 4:13 ` [RFT v2 12/48] sh: intc: " Jiang Liu
2015-06-04 4:13 ` [RFT v2 13/48] keystone, irq: Use irq_data_get_xxx() to avoid redundant lookup of irq_data Jiang Liu
2015-06-04 4:13 ` [RFT v2 14/48] spmi: Use irq_desc_get_xxx() to avoid redundant lookup of irq_desc Jiang Liu
2015-06-04 4:13 ` [RFT v2 15/48] genirq: Kill the parameter 'irq' of kstat_incr_irqs_this_cpu() Jiang Liu
2015-06-04 4:13 ` [RFT v2 16/48] genirq: Introduce helper irq_desc_get_irq() Jiang Liu
2015-06-04 4:13 ` [RFT v2 17/48] genirq: Kill the parameter 'irq' of check_irq_resend() Jiang Liu
2015-06-04 4:13 ` [RFT v2 18/48] genirq: Kill the parameter 'irq' of note_interrupt() Jiang Liu
2015-06-04 4:13 ` Jiang Liu [this message]
2015-06-04 4:13 ` [RFT v2 20/48] genirq: Kill the parameter 'irq' of setup_affinity() Jiang Liu
2015-06-04 4:13 ` [RFT v2 21/48] ARM, irq: Prepare for killing the first parameter 'irq' of irq_flow_handler_t Jiang Liu
2015-06-04 4:13 ` [RFT v2 22/48] blackfin, " Jiang Liu
2015-06-04 4:13 ` [RFT v2 23/48] c6x, " Jiang Liu
2015-06-05 14:14 ` Mark Salter
2015-06-04 4:13 ` [RFT v2 24/48] m68k, " Jiang Liu
2015-06-04 4:13 ` [RFT v2 25/48] mips, " Jiang Liu
2015-06-05 8:34 ` Ralf Baechle
2015-06-04 4:13 ` [RFT v2 26/48] powerpc, " Jiang Liu
2015-06-04 4:13 ` [RFT v2 27/48] sh, " Jiang Liu
2015-06-04 4:13 ` [RFT v2 28/48] unicore32, " Jiang Liu
2015-06-04 4:13 ` [RFT v2 29/48] ipu: " Jiang Liu
2015-06-04 4:13 ` [RFT v2 30/48] gpio: " Jiang Liu
2015-06-04 11:27 ` Linus Walleij
2015-06-04 4:13 ` [RFT v2 31/48] irqchip: " Jiang Liu
2015-06-05 8:36 ` Ralf Baechle
2015-06-04 4:13 ` [RFT v2 32/48] mfd: " Jiang Liu
2015-06-04 7:14 ` Lee Jones
2015-06-04 4:13 ` [RFT v2 33/48] PCI/keystone: " Jiang Liu
2015-06-04 4:13 ` [RFT v2 34/48] pinctrl: " Jiang Liu
2015-06-10 8:39 ` Heiko Stübner
2015-06-10 13:14 ` Linus Walleij
2015-06-04 4:13 ` [RFT v2 35/48] genirq: Kill " Jiang Liu
2015-06-04 4:13 ` [RFT v2 36/48] genirq, arm: " Jiang Liu
2015-06-04 4:52 ` Krzysztof Kozlowski
2015-06-04 4:13 ` [RFT v2 37/48] genirq, blackfin: " Jiang Liu
2015-06-04 4:13 ` [RFT v2 38/48] genirq, powerpc: " Jiang Liu
2015-06-04 4:13 ` [RFT v2 39/48] genirq, mips: " Jiang Liu
2015-06-04 12:21 ` Sergey Ryazanov
2015-06-04 4:13 ` [RFT v2 40/48] genirq, m68k: " Jiang Liu
2015-06-04 4:13 ` [RFT v2 41/48] genirq, x86: " Jiang Liu
2015-06-04 4:13 ` [RFT v2 42/48] genirq, sh: " Jiang Liu
2015-06-04 4:13 ` [RFT v2 43/48] genirq, arch: " Jiang Liu
2015-06-05 14:16 ` Mark Salter
2015-06-04 4:13 ` [RFT v2 44/48] genirq, pinctrl: " Jiang Liu
2015-06-10 8:40 ` Heiko Stübner
2015-06-04 4:13 ` [RFT v2 45/48] genirq, gpio: " Jiang Liu
2015-06-04 6:20 ` Javier Martinez Canillas
2015-06-04 11:28 ` Linus Walleij
2015-06-04 4:13 ` [RFT v2 46/48] genirq, irqchip: " Jiang Liu
2015-06-04 4:52 ` Krzysztof Kozlowski
2015-06-04 4:13 ` [RFT v2 47/48] genirq, mfd: " Jiang Liu
2015-06-04 4:13 ` [RFT v2 48/48] genirq, drivers: " Jiang Liu
2015-06-04 6:59 ` [RFT v2 00/48] Refine irq interfaces to reduce number of parameters Geert Uytterhoeven
2015-06-04 7:23 ` Jiang Liu
2015-06-05 3:53 ` Fengguang Wu
2015-06-05 0:22 ` Daniel Axtens
2015-06-05 1:15 ` Jiang Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1433391238-19471-20-git-send-email-jiang.liu@linux.intel.com \
--to=jiang.liu@linux.intel.com \
--cc=benh@kernel.crashing.org \
--cc=bhelgaas@google.com \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rdunlap@infradead.org \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).