Re: [PATCH] ARM: imx6: Fix non-working MSI interrupts if PCIe switch is attached

[Lucas Stach <l.stach@pengutronix.de>]

Am Donnerstag, den 18.06.2015, 09:59 +0200 schrieb David Müller:
> This problem has already been reported as 
> https://bugzilla.kernel.org/show_bug.cgi?id=100051
> 

I need more explanation for this one. MSI interrupts were certainly
working fine even with a PCIe switchin between some time back. I think I
personally tested things with 3.19.

In the bug report you mention that the MSI_ADDR registers are
overwritten. Where does the write come from and why is it done?

Regards,
Lucas

> Signed-off-by: David Müller <dave.mueller@gmx.ch>
> ---
>  drivers/pci/host/pci-imx6.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/pci/host/pci-imx6.c b/drivers/pci/host/pci-imx6.c
> index c63691c..53f8dea 100644
> --- a/drivers/pci/host/pci-imx6.c
> +++ b/drivers/pci/host/pci-imx6.c
> @@ -433,9 +433,6 @@ static void imx6_pcie_host_init(struct pcie_port *pp)
>  	dw_pcie_setup_rc(pp);
>  
>  	imx6_pcie_start_link(pp);
> -
> -	if (IS_ENABLED(CONFIG_PCI_MSI))
> -		dw_pcie_msi_init(pp);
>  }
>  
>  static void imx6_pcie_reset_phy(struct pcie_port *pp)
> @@ -550,6 +547,9 @@ static int __init imx6_add_pcie_port(struct pcie_port *pp,
>  		return ret;
>  	}
>  
> +	if (IS_ENABLED(CONFIG_PCI_MSI))
> +		dw_pcie_msi_init(pp);
> +
>  	return 0;
>  }
>  

-- 
Pengutronix e.K.             | Lucas Stach                 |
Industrial Linux Solutions   | http://www.pengutronix.de/  |