From: Marc Zyngier <marc.zyngier@arm.com>
To: Bjorn Helgaas <bhelgaas@google.com>,
Thomas Gleixner <tglx@linutronix.de>,
Jiang Liu <jiang.liu@linux.intel.com>,
Jason Cooper <jason@lakedaemon.net>
Cc: <linux-arm-kernel@lists.infradead.org>,
<linux-pci@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
Yijing Wang <wangyijing@huawei.com>, Ma Jun <majun258@huawei.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Duc Dang <dhdang@apm.com>
Subject: [PATCH v5 17/19] irqchip: GICv2m: Add platform MSI support
Date: Thu, 23 Jul 2015 10:26:36 +0100 [thread overview]
Message-ID: <1437643598-19795-18-git-send-email-marc.zyngier@arm.com> (raw)
In-Reply-To: <1437643598-19795-1-git-send-email-marc.zyngier@arm.com>
In order to support non-PCI MSI with GICv2m, add the minimal
required entry points for the MSI domain, which is actually almost
nothing (we just use the defaults provided by the core code).
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
---
drivers/irqchip/irq-gic-v2m.c | 33 +++++++++++++++++++++++++--------
1 file changed, 25 insertions(+), 8 deletions(-)
diff --git a/drivers/irqchip/irq-gic-v2m.c b/drivers/irqchip/irq-gic-v2m.c
index ec9c376..db04fc1 100644
--- a/drivers/irqchip/irq-gic-v2m.c
+++ b/drivers/irqchip/irq-gic-v2m.c
@@ -50,7 +50,6 @@ struct v2m_data {
u32 spi_start; /* The SPI number that MSIs start */
u32 nr_spis; /* The number of SPIs for MSIs */
unsigned long *bm; /* MSI vector bitmap */
- struct irq_domain *domain;
};
static void gicv2m_mask_msi_irq(struct irq_data *d)
@@ -212,12 +211,25 @@ static bool is_msi_spi_valid(u32 base, u32 num)
return true;
}
+static struct irq_chip gicv2m_pmsi_irq_chip = {
+ .name = "pMSI",
+};
+
+static struct msi_domain_ops gicv2m_pmsi_ops = {
+};
+
+static struct msi_domain_info gicv2m_pmsi_domain_info = {
+ .flags = (MSI_FLAG_USE_DEF_DOM_OPS | MSI_FLAG_USE_DEF_CHIP_OPS),
+ .ops = &gicv2m_pmsi_ops,
+ .chip = &gicv2m_pmsi_irq_chip,
+};
+
static int __init gicv2m_init_one(struct device_node *node,
struct irq_domain *parent)
{
int ret;
struct v2m_data *v2m;
- struct irq_domain *inner_domain;
+ struct irq_domain *inner_domain, *pci_domain, *plat_domain;
v2m = kzalloc(sizeof(struct v2m_data), GFP_KERNEL);
if (!v2m) {
@@ -270,10 +282,13 @@ static int __init gicv2m_init_one(struct device_node *node,
inner_domain->bus_token = DOMAIN_BUS_NEXUS;
inner_domain->parent = parent;
- v2m->domain = pci_msi_create_irq_domain(node, &gicv2m_msi_domain_info,
- inner_domain);
- if (!v2m->domain) {
- pr_err("Failed to create MSI domain\n");
+ pci_domain = pci_msi_create_irq_domain(node, &gicv2m_msi_domain_info,
+ inner_domain);
+ plat_domain = platform_msi_create_irq_domain(node,
+ &gicv2m_pmsi_domain_info,
+ inner_domain);
+ if (!pci_domain || !plat_domain) {
+ pr_err("Failed to create MSI domains\n");
ret = -ENOMEM;
goto err_free_domains;
}
@@ -287,8 +302,10 @@ static int __init gicv2m_init_one(struct device_node *node,
return 0;
err_free_domains:
- if (v2m->domain)
- irq_domain_remove(v2m->domain);
+ if (plat_domain)
+ irq_domain_remove(plat_domain);
+ if (pci_domain)
+ irq_domain_remove(pci_domain);
if (inner_domain)
irq_domain_remove(inner_domain);
err_free_bm:
--
2.1.4
next prev parent reply other threads:[~2015-07-23 9:27 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-23 9:26 [PATCH v5 00/19] Per-device MSI domain & platform MSI Marc Zyngier
2015-07-23 9:26 ` [PATCH v5 01/19] genirq: irqdomain: Allow irq domain aliasing Marc Zyngier
2015-07-25 7:15 ` Hanjun Guo
2015-07-23 9:26 ` [PATCH v5 02/19] PCI: MSI: Register irq domain with specific token Marc Zyngier
2015-07-23 13:05 ` Bjorn Helgaas
2015-07-25 8:02 ` Hanjun Guo
2015-07-23 9:26 ` [PATCH v5 03/19] device core: Introduce per-device MSI domain pointer Marc Zyngier
2015-07-25 8:12 ` Hanjun Guo
2015-07-23 9:26 ` [PATCH v5 04/19] PCI/MSI: Add hooks to populate the msi_domain field Marc Zyngier
2015-07-23 13:06 ` Bjorn Helgaas
2015-07-23 14:52 ` Marc Zyngier
2015-07-23 15:36 ` Bjorn Helgaas
2015-07-25 8:20 ` Hanjun Guo
2015-07-23 9:26 ` [PATCH v5 05/19] PCI/MSI: of: Add support for OF-provided msi_domain Marc Zyngier
2015-07-23 13:12 ` Bjorn Helgaas
2015-07-23 9:26 ` [PATCH v5 06/19] PCI/MSI: of: Allow msi_domain lookup using the host bridge node Marc Zyngier
2015-07-23 13:13 ` Bjorn Helgaas
2015-07-23 9:26 ` [PATCH v5 07/19] PCI/MSI: Let pci_msi_get_domain use struct device's msi_domain Marc Zyngier
2015-07-23 13:14 ` Bjorn Helgaas
2015-07-25 8:25 ` Hanjun Guo
2015-07-23 9:26 ` [PATCH v5 08/19] platform: of: Assign MSI domain to platform device Marc Zyngier
2015-07-23 9:26 ` [PATCH v5 09/19] drivers: base: Add MSI domain support for non-PCI devices Marc Zyngier
2015-07-23 9:26 ` [PATCH v5 10/19] genirq: Add DOMAIN_BUS_NEXUS irqdomain property Marc Zyngier
2015-07-23 9:26 ` [PATCH v5 11/19] irqchip: gicv3-its: Split PCI/MSI code from the core ITS driver Marc Zyngier
2015-07-23 9:26 ` [PATCH v5 12/19] irqchip: gicv3-its: Register irq domain with NEXUS token Marc Zyngier
2015-07-23 9:26 ` [PATCH v5 13/19] irqchip: gicv3-its: Get rid of struct msi_controller Marc Zyngier
2015-07-23 9:26 ` [PATCH v5 14/19] irqchip: gicv3-its: Make the PCI/MSI code standalone Marc Zyngier
2015-07-23 9:26 ` [PATCH v5 15/19] irqchip: gicv3-its: Add platform MSI support Marc Zyngier
2015-07-23 9:26 ` [PATCH v5 16/19] irqchip: GICv2m: Get rid of struct msi_controller Marc Zyngier
2015-07-23 9:26 ` Marc Zyngier [this message]
2015-07-23 9:26 ` [PATCH v5 18/19] PCI/MSI: pci-xgene-msi: " Marc Zyngier
2015-07-23 13:17 ` Bjorn Helgaas
2015-07-23 9:26 ` [PATCH v5 19/19] PCI/MSI: Drop domain field from msi_controller Marc Zyngier
2015-07-23 13:18 ` [PATCH v5 00/19] Per-device MSI domain & platform MSI Bjorn Helgaas
2015-07-23 14:54 ` Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1437643598-19795-18-git-send-email-marc.zyngier@arm.com \
--to=marc.zyngier@arm.com \
--cc=bhelgaas@google.com \
--cc=dhdang@apm.com \
--cc=jason@lakedaemon.net \
--cc=jiang.liu@linux.intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=majun258@huawei.com \
--cc=tglx@linutronix.de \
--cc=wangyijing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).