From: Kevin Hao <haokexin@gmail.com>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: linux-pci@vger.kernel.org, Pratyush Anand <pratyush.anand@gmail.com>
Subject: [PATCH 4/4] PCI: spear: Mark the msi cascade handler IRQF_NO_THREAD
Date: Fri, 24 Jul 2015 13:29:36 +0800 [thread overview]
Message-ID: <1437715776-2243-5-git-send-email-haokexin@gmail.com> (raw)
In-Reply-To: <1437715776-2243-1-git-send-email-haokexin@gmail.com>
The cascade handler must run in hard interrupt context, otherwise
it will cause dead lock if we force threading of all the interrupt
handlers via kernel command parameter "threadirqs".
Signed-off-by: Kevin Hao <haokexin@gmail.com>
---
drivers/pci/host/pcie-spear13xx.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/pci/host/pcie-spear13xx.c b/drivers/pci/host/pcie-spear13xx.c
index c49fbdc0f6e4..338788b28631 100644
--- a/drivers/pci/host/pcie-spear13xx.c
+++ b/drivers/pci/host/pcie-spear13xx.c
@@ -280,7 +280,8 @@ static int spear13xx_add_pcie_port(struct pcie_port *pp,
return -ENODEV;
}
ret = devm_request_irq(dev, pp->irq, spear13xx_pcie_irq_handler,
- IRQF_SHARED, "spear1340-pcie", pp);
+ IRQF_SHARED | IRQF_NO_THREAD,
+ "spear1340-pcie", pp);
if (ret) {
dev_err(dev, "failed to request irq %d\n", pp->irq);
return ret;
--
2.1.0
prev parent reply other threads:[~2015-07-24 5:30 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-24 5:29 [PATCH 0/4] PCI: Mark the msi cascade handler IRQF_NO_THREAD Kevin Hao
2015-07-24 5:29 ` [PATCH 1/4] PCI: imx6: " Kevin Hao
2015-07-24 8:00 ` Lucas Stach
2015-07-24 8:19 ` Kevin Hao
2015-07-24 8:22 ` Lucas Stach
2015-07-24 8:23 ` Lucas Stach
2015-08-10 23:26 ` Bjorn Helgaas
2015-08-11 8:01 ` Lucas Stach
2015-08-11 8:03 ` Kevin Hao
2015-08-11 14:38 ` Bjorn Helgaas
2015-08-11 20:07 ` Bjorn Helgaas
2015-08-12 1:25 ` Kevin Hao
2015-07-24 5:29 ` [PATCH 2/4] PCI: dra7xx: " Kevin Hao
2015-07-24 5:29 ` [PATCH 3/4] PCI: exynos: " Kevin Hao
2015-07-24 5:29 ` Kevin Hao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1437715776-2243-5-git-send-email-haokexin@gmail.com \
--to=haokexin@gmail.com \
--cc=bhelgaas@google.com \
--cc=linux-pci@vger.kernel.org \
--cc=pratyush.anand@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).