linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Lucas Stach <l.stach@pengutronix.de>
To: Kevin Hao <haokexin@gmail.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
	linux-pci@vger.kernel.org,
	Richard Zhu <Richard.Zhu@freescale.com>
Subject: Re: [PATCH 1/4] PCI: imx6: Mark the msi cascade handler IRQF_NO_THREAD
Date: Fri, 24 Jul 2015 10:22:47 +0200	[thread overview]
Message-ID: <1437726167.3071.43.camel@pengutronix.de> (raw)
In-Reply-To: <20150724081917.GC29472@pek-khao-d1.corp.ad.wrs.com>

Am Freitag, den 24.07.2015, 16:19 +0800 schrieb Kevin Hao:
> On Fri, Jul 24, 2015 at 10:00:59AM +0200, Lucas Stach wrote:
> > Hi Kevin,
> > 
> > Am Freitag, den 24.07.2015, 13:29 +0800 schrieb Kevin Hao:
> > > The cascade handler must run in hard interrupt context, otherwise
> > > it will cause the following kernel warning if we force threading
> > > of all the interrupt handlers via kernel command parameter
> > > "threadirqs":
> > 
> > The change looks good, but there are a few other designware drivers that
> > use the same logic to trigger the cascaded MSI handler. Can you please
> > make sure to change them, too?
> 
> I have made the same change for the following drivers:
> Kevin Hao (4):
>   PCI: imx6: Mark the msi cascade handler IRQF_NO_THREAD
>   PCI: dra7xx: Mark the msi cascade handler IRQF_NO_THREAD
>   PCI: exynos: Mark the msi cascade handler IRQF_NO_THREAD
>   PCI: spear: Mark the msi cascade handler IRQF_NO_THREAD
> 
>  drivers/pci/host/pci-dra7xx.c     | 3 ++-
>  drivers/pci/host/pci-exynos.c     | 3 ++-
>  drivers/pci/host/pci-imx6.c       | 3 ++-
>  drivers/pci/host/pcie-spear13xx.c | 3 ++-
>  4 files changed, 8 insertions(+), 4 deletions(-)
> 
> Did I miss something?

Sorry, I did miss that the patch CC'ed to me was part of a series. I was
under the impression that such a trivial change could be done in one
patch for all drivers. But it's up to Bjorn to decide if he wants to
take this as individual patches.

Regards,
Lucas
-- 
Pengutronix e.K.             | Lucas Stach                 |
Industrial Linux Solutions   | http://www.pengutronix.de/  |


  reply	other threads:[~2015-07-24  8:22 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-24  5:29 [PATCH 0/4] PCI: Mark the msi cascade handler IRQF_NO_THREAD Kevin Hao
2015-07-24  5:29 ` [PATCH 1/4] PCI: imx6: " Kevin Hao
2015-07-24  8:00   ` Lucas Stach
2015-07-24  8:19     ` Kevin Hao
2015-07-24  8:22       ` Lucas Stach [this message]
2015-07-24  8:23   ` Lucas Stach
2015-08-10 23:26   ` Bjorn Helgaas
2015-08-11  8:01     ` Lucas Stach
2015-08-11  8:03     ` Kevin Hao
2015-08-11 14:38       ` Bjorn Helgaas
2015-08-11 20:07       ` Bjorn Helgaas
2015-08-12  1:25         ` Kevin Hao
2015-07-24  5:29 ` [PATCH 2/4] PCI: dra7xx: " Kevin Hao
2015-07-24  5:29 ` [PATCH 3/4] PCI: exynos: " Kevin Hao
2015-07-24  5:29 ` [PATCH 4/4] PCI: spear: " Kevin Hao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1437726167.3071.43.camel@pengutronix.de \
    --to=l.stach@pengutronix.de \
    --cc=Richard.Zhu@freescale.com \
    --cc=bhelgaas@google.com \
    --cc=haokexin@gmail.com \
    --cc=linux-pci@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).