* [PATCH 1/2] pci_ids: Add Pericom vendor and device ids
@ 2015-08-03 4:33 Adam Lee
2015-08-03 4:33 ` [PATCH 2/2] serial: 8250_pci: Add support for Pericom PI7C9X795[1248] Adam Lee
2015-08-03 4:36 ` [PATCH 1/2] pci_ids: Add Pericom vendor and device ids Greg Kroah-Hartman
0 siblings, 2 replies; 5+ messages in thread
From: Adam Lee @ 2015-08-03 4:33 UTC (permalink / raw)
To: linux-pci, linux-serial; +Cc: Bjorn Helgaas, Greg Kroah-Hartman
This patch add Pericom's vendor id and Pericom PI7C9X795[1248] chips'
device ids.
Signed-off-by: Adam Lee <adam.lee@canonical.com>
---
include/linux/pci_ids.h | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h
index fcff8f8..c4a93cf 100644
--- a/include/linux/pci_ids.h
+++ b/include/linux/pci_ids.h
@@ -2995,4 +2995,10 @@
#define PCI_VENDOR_ID_OCZ 0x1b85
+#define PCI_VENDOR_ID_PERICOM 0x12D8
+#define PCI_DEVICE_ID_PERICOM_PI7C9X7951 0x7951
+#define PCI_DEVICE_ID_PERICOM_PI7C9X7952 0x7952
+#define PCI_DEVICE_ID_PERICOM_PI7C9X7954 0x7954
+#define PCI_DEVICE_ID_PERICOM_PI7C9X7958 0x7958
+
#endif /* _LINUX_PCI_IDS_H */
--
2.5.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 2/2] serial: 8250_pci: Add support for Pericom PI7C9X795[1248]
2015-08-03 4:33 [PATCH 1/2] pci_ids: Add Pericom vendor and device ids Adam Lee
@ 2015-08-03 4:33 ` Adam Lee
2015-08-03 4:36 ` [PATCH 1/2] pci_ids: Add Pericom vendor and device ids Greg Kroah-Hartman
1 sibling, 0 replies; 5+ messages in thread
From: Adam Lee @ 2015-08-03 4:33 UTC (permalink / raw)
To: linux-pci, linux-serial; +Cc: Bjorn Helgaas, Greg Kroah-Hartman
Pericom PI7C9X795[1248] are Uno/Dual/Quad/Octal UART devices, this
patch enables them.
Signed-off-by: Adam Lee <adam.lee@canonical.com>
---
drivers/tty/serial/8250/8250_pci.c | 76 +++++++++++++++++++++++++++-----------
1 file changed, 55 insertions(+), 21 deletions(-)
diff --git a/drivers/tty/serial/8250/8250_pci.c b/drivers/tty/serial/8250/8250_pci.c
index e55f18b..353112c 100644
--- a/drivers/tty/serial/8250/8250_pci.c
+++ b/drivers/tty/serial/8250/8250_pci.c
@@ -2331,27 +2331,12 @@ static struct pci_serial_quirk pci_serial_quirks[] __refdata = {
* Pericom
*/
{
- .vendor = 0x12d8,
- .device = 0x7952,
- .subvendor = PCI_ANY_ID,
- .subdevice = PCI_ANY_ID,
- .setup = pci_pericom_setup,
- },
- {
- .vendor = 0x12d8,
- .device = 0x7954,
- .subvendor = PCI_ANY_ID,
- .subdevice = PCI_ANY_ID,
- .setup = pci_pericom_setup,
- },
- {
- .vendor = 0x12d8,
- .device = 0x7958,
- .subvendor = PCI_ANY_ID,
- .subdevice = PCI_ANY_ID,
- .setup = pci_pericom_setup,
+ .vendor = PCI_VENDOR_ID_PERICOM,
+ .device = PCI_ANY_ID,
+ .subvendor = PCI_ANY_ID,
+ .subdevice = PCI_ANY_ID,
+ .setup = pci_pericom_setup,
},
-
/*
* PLX
*/
@@ -3056,6 +3041,10 @@ enum pci_board_num_t {
pbn_fintek_8,
pbn_fintek_12,
pbn_wch384_4,
+ pbn_pericom_PI7C9X7951,
+ pbn_pericom_PI7C9X7952,
+ pbn_pericom_PI7C9X7954,
+ pbn_pericom_PI7C9X7958,
};
/*
@@ -3881,7 +3870,6 @@ static struct pciserial_board pci_boards[] = {
.base_baud = 115200,
.first_offset = 0x40,
},
-
[pbn_wch384_4] = {
.flags = FL_BASE0,
.num_ports = 4,
@@ -3889,6 +3877,33 @@ static struct pciserial_board pci_boards[] = {
.uart_offset = 8,
.first_offset = 0xC0,
},
+ /*
+ * Pericom PI7C9X795[1248] Uno/Dual/Quad/Octal UART
+ */
+ [pbn_pericom_PI7C9X7951] = {
+ .flags = FL_BASE0,
+ .num_ports = 1,
+ .base_baud = 921600,
+ .uart_offset = 0x8,
+ },
+ [pbn_pericom_PI7C9X7952] = {
+ .flags = FL_BASE0,
+ .num_ports = 2,
+ .base_baud = 921600,
+ .uart_offset = 0x8,
+ },
+ [pbn_pericom_PI7C9X7954] = {
+ .flags = FL_BASE0,
+ .num_ports = 4,
+ .base_baud = 921600,
+ .uart_offset = 0x8,
+ },
+ [pbn_pericom_PI7C9X7958] = {
+ .flags = FL_BASE0,
+ .num_ports = 8,
+ .base_baud = 921600,
+ .uart_offset = 0x8,
+ },
};
static const struct pci_device_id blacklist[] = {
@@ -5154,6 +5169,25 @@ static struct pci_device_id serial_pci_tbl[] = {
0,
0, pbn_exar_XR17V8358 },
/*
+ * Pericom PI7C9X795[1248] Uno/Dual/Quad/Octal UART
+ */
+ { PCI_VENDOR_ID_PERICOM, PCI_DEVICE_ID_PERICOM_PI7C9X7951,
+ PCI_ANY_ID, PCI_ANY_ID,
+ 0,
+ 0, pbn_pericom_PI7C9X7951 },
+ { PCI_VENDOR_ID_PERICOM, PCI_DEVICE_ID_PERICOM_PI7C9X7952,
+ PCI_ANY_ID, PCI_ANY_ID,
+ 0,
+ 0, pbn_pericom_PI7C9X7952 },
+ { PCI_VENDOR_ID_PERICOM, PCI_DEVICE_ID_PERICOM_PI7C9X7954,
+ PCI_ANY_ID, PCI_ANY_ID,
+ 0,
+ 0, pbn_pericom_PI7C9X7954 },
+ { PCI_VENDOR_ID_PERICOM, PCI_DEVICE_ID_PERICOM_PI7C9X7958,
+ PCI_ANY_ID, PCI_ANY_ID,
+ 0,
+ 0, pbn_pericom_PI7C9X7958 },
+ /*
* Topic TP560 Data/Fax/Voice 56k modem (reported by Evan Clarke)
*/
{ PCI_VENDOR_ID_TOPIC, PCI_DEVICE_ID_TOPIC_TP560,
--
2.5.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] pci_ids: Add Pericom vendor and device ids
2015-08-03 4:33 [PATCH 1/2] pci_ids: Add Pericom vendor and device ids Adam Lee
2015-08-03 4:33 ` [PATCH 2/2] serial: 8250_pci: Add support for Pericom PI7C9X795[1248] Adam Lee
@ 2015-08-03 4:36 ` Greg Kroah-Hartman
2015-08-03 4:44 ` Adam Lee
1 sibling, 1 reply; 5+ messages in thread
From: Greg Kroah-Hartman @ 2015-08-03 4:36 UTC (permalink / raw)
To: Adam Lee; +Cc: linux-pci, linux-serial, Bjorn Helgaas
On Mon, Aug 03, 2015 at 12:33:20PM +0800, Adam Lee wrote:
> This patch add Pericom's vendor id and Pericom PI7C9X795[1248] chips'
> device ids.
>
> Signed-off-by: Adam Lee <adam.lee@canonical.com>
> ---
> include/linux/pci_ids.h | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h
> index fcff8f8..c4a93cf 100644
> --- a/include/linux/pci_ids.h
> +++ b/include/linux/pci_ids.h
> @@ -2995,4 +2995,10 @@
>
> #define PCI_VENDOR_ID_OCZ 0x1b85
>
> +#define PCI_VENDOR_ID_PERICOM 0x12D8
> +#define PCI_DEVICE_ID_PERICOM_PI7C9X7951 0x7951
> +#define PCI_DEVICE_ID_PERICOM_PI7C9X7952 0x7952
> +#define PCI_DEVICE_ID_PERICOM_PI7C9X7954 0x7954
> +#define PCI_DEVICE_ID_PERICOM_PI7C9X7958 0x7958
Please read the top of this file, this isn't needed...
thanks,
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] pci_ids: Add Pericom vendor and device ids
2015-08-03 4:36 ` [PATCH 1/2] pci_ids: Add Pericom vendor and device ids Greg Kroah-Hartman
@ 2015-08-03 4:44 ` Adam Lee
2015-08-03 5:14 ` Greg Kroah-Hartman
0 siblings, 1 reply; 5+ messages in thread
From: Adam Lee @ 2015-08-03 4:44 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: linux-pci, linux-serial, Bjorn Helgaas
On Sun, Aug 02, 2015 at 09:36:47PM -0700, Greg Kroah-Hartman wrote:
> On Mon, Aug 03, 2015 at 12:33:20PM +0800, Adam Lee wrote:
> > This patch add Pericom's vendor id and Pericom PI7C9X795[1248] chips'
> > device ids.
> >
> > Signed-off-by: Adam Lee <adam.lee@canonical.com>
> > ---
> > include/linux/pci_ids.h | 6 ++++++
> > 1 file changed, 6 insertions(+)
> >
> > diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h
> > index fcff8f8..c4a93cf 100644
> > --- a/include/linux/pci_ids.h
> > +++ b/include/linux/pci_ids.h
> > @@ -2995,4 +2995,10 @@
> >
> > #define PCI_VENDOR_ID_OCZ 0x1b85
> >
> > +#define PCI_VENDOR_ID_PERICOM 0x12D8
> > +#define PCI_DEVICE_ID_PERICOM_PI7C9X7951 0x7951
> > +#define PCI_DEVICE_ID_PERICOM_PI7C9X7952 0x7952
> > +#define PCI_DEVICE_ID_PERICOM_PI7C9X7954 0x7954
> > +#define PCI_DEVICE_ID_PERICOM_PI7C9X7958 0x7958
>
> Please read the top of this file, this isn't needed...
>
> thanks,
>
> greg k-h
Oops. Pericom also has other products than serial card, so is it OK if I
still leave PCI_VENDOR_ID_PERICOM in pci_ids.h and move device ids to
particular driver? Thanks.
--
Adam Lee
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] pci_ids: Add Pericom vendor and device ids
2015-08-03 4:44 ` Adam Lee
@ 2015-08-03 5:14 ` Greg Kroah-Hartman
0 siblings, 0 replies; 5+ messages in thread
From: Greg Kroah-Hartman @ 2015-08-03 5:14 UTC (permalink / raw)
To: Adam Lee; +Cc: linux-pci, linux-serial, Bjorn Helgaas
On Mon, Aug 03, 2015 at 12:44:28PM +0800, Adam Lee wrote:
> On Sun, Aug 02, 2015 at 09:36:47PM -0700, Greg Kroah-Hartman wrote:
> > On Mon, Aug 03, 2015 at 12:33:20PM +0800, Adam Lee wrote:
> > > This patch add Pericom's vendor id and Pericom PI7C9X795[1248] chips'
> > > device ids.
> > >
> > > Signed-off-by: Adam Lee <adam.lee@canonical.com>
> > > ---
> > > include/linux/pci_ids.h | 6 ++++++
> > > 1 file changed, 6 insertions(+)
> > >
> > > diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h
> > > index fcff8f8..c4a93cf 100644
> > > --- a/include/linux/pci_ids.h
> > > +++ b/include/linux/pci_ids.h
> > > @@ -2995,4 +2995,10 @@
> > >
> > > #define PCI_VENDOR_ID_OCZ 0x1b85
> > >
> > > +#define PCI_VENDOR_ID_PERICOM 0x12D8
> > > +#define PCI_DEVICE_ID_PERICOM_PI7C9X7951 0x7951
> > > +#define PCI_DEVICE_ID_PERICOM_PI7C9X7952 0x7952
> > > +#define PCI_DEVICE_ID_PERICOM_PI7C9X7954 0x7954
> > > +#define PCI_DEVICE_ID_PERICOM_PI7C9X7958 0x7958
> >
> > Please read the top of this file, this isn't needed...
> >
> > thanks,
> >
> > greg k-h
>
> Oops. Pericom also has other products than serial card, so is it OK if I
> still leave PCI_VENDOR_ID_PERICOM in pci_ids.h and move device ids to
> particular driver? Thanks.
Until it's needed, I wouldn't recommend added anything to pci_ids.h
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-08-03 5:14 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-08-03 4:33 [PATCH 1/2] pci_ids: Add Pericom vendor and device ids Adam Lee
2015-08-03 4:33 ` [PATCH 2/2] serial: 8250_pci: Add support for Pericom PI7C9X795[1248] Adam Lee
2015-08-03 4:36 ` [PATCH 1/2] pci_ids: Add Pericom vendor and device ids Greg Kroah-Hartman
2015-08-03 4:44 ` Adam Lee
2015-08-03 5:14 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).