From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: David Miller <davem@davemloft.net>,
Yijing Wang <wangyijing@huawei.com>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
Meelis Roos <mroos@linux.ee>,
"sparclinux@vger.kernel.org" <sparclinux@vger.kernel.org>,
Eric Snowberg <eric.snowberg@oracle.com>
Subject: Re: [PATCH] PCI/ASPM: Fix a NULL pointer crash on sparc64
Date: Thu, 20 Aug 2015 16:38:22 +1000 [thread overview]
Message-ID: <1440052702.9177.8.camel@kernel.crashing.org> (raw)
In-Reply-To: <CAErSpo7JtRLWRAUPBdsoKauHNmftsb6fST317V9Sg4PkTV91pg@mail.gmail.com>
On Wed, 2015-08-19 at 23:01 -0700, Bjorn Helgaas wrote:
> Easier said than done. AFAIK, we won't crash after we add Yijing's
> patch. But it's unreasonable to expect people writing to the spec to
> know the peculiarities of sparc64/powerpc, so there may be future
> things we discover the hard way. We'll just have to deal with them as
> we find them.
I agree in general, you can't plan for all possible spec violations but
it's also pretty standard defensive coding to now blow up if stuff
doesn't look expected :)
Anyway, this one is sorted.
Cheers,
Ben.
next prev parent reply other threads:[~2015-08-20 6:38 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-17 10:47 [PATCH] PCI/ASPM: Fix a NULL pointer crash on sparc64 Yijing Wang
2015-08-18 18:49 ` Bjorn Helgaas
2015-08-18 19:10 ` David Miller
2015-08-19 22:16 ` Bjorn Helgaas
2015-08-19 22:29 ` Benjamin Herrenschmidt
2015-08-20 6:01 ` Bjorn Helgaas
2015-08-20 6:38 ` Benjamin Herrenschmidt [this message]
2015-08-20 6:44 ` Kjetil Oftedal
2015-08-20 17:51 ` David Miller
2015-08-20 17:50 ` David Miller
2015-08-20 5:48 ` Bjorn Helgaas
2015-08-20 17:47 ` David Miller
2015-08-20 18:23 ` Bjorn Helgaas
2015-08-20 18:40 ` David Miller
2015-08-20 20:21 ` Bjorn Helgaas
2015-08-20 20:58 ` David Miller
2015-08-20 21:21 ` Bjorn Helgaas
2015-08-20 21:38 ` David Miller
2015-08-21 1:48 ` wangyijing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1440052702.9177.8.camel@kernel.crashing.org \
--to=benh@kernel.crashing.org \
--cc=bhelgaas@google.com \
--cc=davem@davemloft.net \
--cc=eric.snowberg@oracle.com \
--cc=linux-pci@vger.kernel.org \
--cc=mroos@linux.ee \
--cc=sparclinux@vger.kernel.org \
--cc=wangyijing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).