From: Fabio Estevam <festevam@gmail.com>
To: bhelgaas@google.com
Cc: pratyush.anand@gmail.com, m-karicheri2@ti.com,
l.stach@pengutronix.de, linux-pci@vger.kernel.org,
Fabio Estevam <fabio.estevam@freescale.com>
Subject: [PATCH v2 2/2] PCI: imx6: Use define instead of hard coded value
Date: Thu, 8 Oct 2015 22:48:26 -0300 [thread overview]
Message-ID: <1444355306-21486-2-git-send-email-festevam@gmail.com> (raw)
In-Reply-To: <1444355306-21486-1-git-send-email-festevam@gmail.com>
From: Fabio Estevam <fabio.estevam@freescale.com>
Use LTSSM_STATE_RCVRY_LOCK define instead of hard coded value in order
to improve the code readability;
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
Changes since v1:
- None
drivers/pci/host/pci-imx6.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pci/host/pci-imx6.c b/drivers/pci/host/pci-imx6.c
index 6f43086..4e7b577 100644
--- a/drivers/pci/host/pci-imx6.c
+++ b/drivePCIE_PHY_DEBUG_R0_LTSSM_MASKrs/pci/host/pci-imx6.c
@@ -508,7 +508,7 @@ static int imx6_pcie_link_up(struct pcie_port *pp)
if (rx_valid & PCIE_PHY_RX_ASIC_OUT_VALID)
return 0;
- if ((debug_r0 & PCIE_PHY_DEBUG_R0_LTSSM_MASK) != 0x0d)
+ if ((debug_r0 & PCIE_PHY_DEBUG_R0_LTSSM_MASK) != LTSSM_STATE_RCVRY_LOCK)
return 0;
dev_err(pp->dev, "transition to gen2 is stuck, reset PHY!\n");
--
1.9.1
next prev parent reply other threads:[~2015-10-09 1:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-09 1:48 [PATCH v2 1/2] PCI: designware: Move LTSSM state definitions to pcie-designware.h Fabio Estevam
2015-10-09 1:48 ` Fabio Estevam [this message]
2015-10-12 10:29 ` [PATCH v2 2/2] PCI: imx6: Use define instead of hard coded value Lucas Stach
2015-10-12 10:19 ` [PATCH v2 1/2] PCI: designware: Move LTSSM state definitions to pcie-designware.h Lucas Stach
2015-10-12 10:28 ` Lucas Stach
2015-10-12 12:31 ` Fabio Estevam
2015-10-12 13:34 ` Lucas Stach
2015-10-12 14:04 ` Fabio Estevam
2015-10-12 14:11 ` Lucas Stach
2015-10-12 15:47 ` Fabio Estevam
2015-10-12 12:26 ` Fabio Estevam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1444355306-21486-2-git-send-email-festevam@gmail.com \
--to=festevam@gmail.com \
--cc=bhelgaas@google.com \
--cc=fabio.estevam@freescale.com \
--cc=l.stach@pengutronix.de \
--cc=linux-pci@vger.kernel.org \
--cc=m-karicheri2@ti.com \
--cc=pratyush.anand@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).