From: Lucas Stach <l.stach@pengutronix.de>
To: Fabio Estevam <festevam@gmail.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
Pratyush Anand Thakur <pratyush.anand@gmail.com>,
m-karicheri2 <m-karicheri2@ti.com>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
Fabio Estevam <fabio.estevam@freescale.com>
Subject: Re: [PATCH v2 1/2] PCI: designware: Move LTSSM state definitions to pcie-designware.h
Date: Mon, 12 Oct 2015 16:11:42 +0200 [thread overview]
Message-ID: <1444659102.3364.19.camel@pengutronix.de> (raw)
In-Reply-To: <CAOMZO5CKWj9tWCOZV65xwFCB7b120weq3Aq7_de-aMdEYAZWpA@mail.gmail.com>
Am Montag, den 12.10.2015, 11:04 -0300 schrieb Fabio Estevam:
> On Mon, Oct 12, 2015 at 10:34 AM, Lucas Stach <l.stach@pengutronix.de> wrote:
> > Am Montag, den 12.10.2015, 09:31 -0300 schrieb Fabio Estevam:
> >> On Mon, Oct 12, 2015 at 7:28 AM, Lucas Stach <l.stach@pengutronix.de> wrote:
> >>
> >> > Actually the TRM states that i.MX6 is using the same narrower mask of
> >> > 0x1f for the LTSSM state, so another reason to just use that.
> >>
> >> The manual I have seems to tell a different value :-)
> >>
> >> Please check: http://cache.freescale.com/files/32bit/doc/ref_manual/IMX6DQRM.pdf
> >>
> >> "48.12.11
> >> Debug Register 0 (PCIE_PL_DEBUG0)"
> >>
> >> says "[5:0]: xmlh_ltssm_state LTSSM current state. See source for encodings"
> >>
> > Urgh. Seems we got confused by all the different defines.
> >
> > In fact [5:0] is 0x1f, so i.MX6 uses the same mask as Keystone, yet the
>
> No, bits [5..0] means 0x3f. What am I missing here?
That you have to deal with people who are apparently unable to count to
5. *me puts on the brown paper bag*
Still I would love to have a definition in the common header that's
usable for all drivers. So unless there is a reason to use 0x3f (and we
don't have any LTSSM state defines which would use the extra bit) keep
it at 0x1f. Simpler, cleaner... IMHO.
Regards,
Lucas
--
Pengutronix e.K. | Lucas Stach |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2015-10-12 14:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-09 1:48 [PATCH v2 1/2] PCI: designware: Move LTSSM state definitions to pcie-designware.h Fabio Estevam
2015-10-09 1:48 ` [PATCH v2 2/2] PCI: imx6: Use define instead of hard coded value Fabio Estevam
2015-10-12 10:29 ` Lucas Stach
2015-10-12 10:19 ` [PATCH v2 1/2] PCI: designware: Move LTSSM state definitions to pcie-designware.h Lucas Stach
2015-10-12 10:28 ` Lucas Stach
2015-10-12 12:31 ` Fabio Estevam
2015-10-12 13:34 ` Lucas Stach
2015-10-12 14:04 ` Fabio Estevam
2015-10-12 14:11 ` Lucas Stach [this message]
2015-10-12 15:47 ` Fabio Estevam
2015-10-12 12:26 ` Fabio Estevam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1444659102.3364.19.camel@pengutronix.de \
--to=l.stach@pengutronix.de \
--cc=bhelgaas@google.com \
--cc=fabio.estevam@freescale.com \
--cc=festevam@gmail.com \
--cc=linux-pci@vger.kernel.org \
--cc=m-karicheri2@ti.com \
--cc=pratyush.anand@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).