* [PATCH] PCI: designware: Remove unused variable
@ 2016-01-11 11:41 Fabio Estevam
2016-01-11 14:43 ` Bjorn Helgaas
0 siblings, 1 reply; 4+ messages in thread
From: Fabio Estevam @ 2016-01-11 11:41 UTC (permalink / raw)
To: bhelgaas; +Cc: jingoohan1, linux-pci, Fabio Estevam
Commit 50a1a3b06dddaa5b ("PCI: designware: Simplify control flow")
causes the following build warning:
drivers/pci/host/pcie-designware.c:683:6: warning: unused variable 'ret' [-Wunused-variable]
Remove the unused 'ret' varaible.
Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
---
drivers/pci/host/pcie-designware.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/pci/host/pcie-designware.c b/drivers/pci/host/pcie-designware.c
index 9a666db..2171682 100644
--- a/drivers/pci/host/pcie-designware.c
+++ b/drivers/pci/host/pcie-designware.c
@@ -680,7 +680,6 @@ static int dw_pcie_wr_conf(struct pci_bus *bus, u32 devfn,
int where, int size, u32 val)
{
struct pcie_port *pp = bus->sysdata;
- int ret;
if (dw_pcie_valid_config(pp, bus, PCI_SLOT(devfn)) == 0)
return PCIBIOS_DEVICE_NOT_FOUND;
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] PCI: designware: Remove unused variable
2016-01-11 11:41 [PATCH] PCI: designware: Remove unused variable Fabio Estevam
@ 2016-01-11 14:43 ` Bjorn Helgaas
0 siblings, 0 replies; 4+ messages in thread
From: Bjorn Helgaas @ 2016-01-11 14:43 UTC (permalink / raw)
To: Fabio Estevam; +Cc: bhelgaas, jingoohan1, linux-pci
On Mon, Jan 11, 2016 at 09:41:10AM -0200, Fabio Estevam wrote:
> Commit 50a1a3b06dddaa5b ("PCI: designware: Simplify control flow")
> causes the following build warning:
>
> drivers/pci/host/pcie-designware.c:683:6: warning: unused variable 'ret' [-Wunused-variable]
>
> Remove the unused 'ret' varaible.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
Thanks guys, sorry about this oversight. I folded this into the original
patch.
> ---
> drivers/pci/host/pcie-designware.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/pci/host/pcie-designware.c b/drivers/pci/host/pcie-designware.c
> index 9a666db..2171682 100644
> --- a/drivers/pci/host/pcie-designware.c
> +++ b/drivers/pci/host/pcie-designware.c
> @@ -680,7 +680,6 @@ static int dw_pcie_wr_conf(struct pci_bus *bus, u32 devfn,
> int where, int size, u32 val)
> {
> struct pcie_port *pp = bus->sysdata;
> - int ret;
>
> if (dw_pcie_valid_config(pp, bus, PCI_SLOT(devfn)) == 0)
> return PCIBIOS_DEVICE_NOT_FOUND;
> --
> 1.9.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pci" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] PCI: designware: remove unused variable
@ 2016-01-11 12:11 Arnd Bergmann
0 siblings, 0 replies; 4+ messages in thread
From: Arnd Bergmann @ 2016-01-11 12:11 UTC (permalink / raw)
To: Bjorn Helgaas
Cc: Jingoo Han, Pratyush Anand, linux-pci, linux-kernel,
linux-arm-kernel
A cleanup patch removed the only use of the 'ret' variable
in wr_conf but forgot to remove the variable:
pci/host/pcie-designware.c: In function 'dw_pcie_wr_conf':
pci/host/pcie-designware.c:683:6: warning: unused variable 'ret' [-Wunused-variable]
This cleans that part up as well.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 50a1a3b06ddd ("PCI: designware: Simplify control flow")
---
This came up this morning on linux-next with ARM randconfig builds
diff --git a/drivers/pci/host/pcie-designware.c b/drivers/pci/host/pcie-designware.c
index 9a666dbff127..21716827847a 100644
--- a/drivers/pci/host/pcie-designware.c
+++ b/drivers/pci/host/pcie-designware.c
@@ -680,7 +680,6 @@ static int dw_pcie_wr_conf(struct pci_bus *bus, u32 devfn,
int where, int size, u32 val)
{
struct pcie_port *pp = bus->sysdata;
- int ret;
if (dw_pcie_valid_config(pp, bus, PCI_SLOT(devfn)) == 0)
return PCIBIOS_DEVICE_NOT_FOUND;
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH] PCI: designware: Remove unused variable
@ 2016-01-11 12:15 Thierry Reding
0 siblings, 0 replies; 4+ messages in thread
From: Thierry Reding @ 2016-01-11 12:15 UTC (permalink / raw)
To: Bjorn Helgaas; +Cc: linux-pci, linux-next
From: Thierry Reding <treding@nvidia.com>
Commit 50a1a3b06ddd ("PCI: designware: Simplify control flow") removed
all uses of the "ret" variable in the dw_pcie_wr_conf() function but not
the variable itself. Do so now to get rid of an unused variable warning.
Signed-off-by: Thierry Reding <treding@nvidia.com>
---
drivers/pci/host/pcie-designware.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/pci/host/pcie-designware.c b/drivers/pci/host/pcie-designware.c
index 9a666dbff127..21716827847a 100644
--- a/drivers/pci/host/pcie-designware.c
+++ b/drivers/pci/host/pcie-designware.c
@@ -680,7 +680,6 @@ static int dw_pcie_wr_conf(struct pci_bus *bus, u32 devfn,
int where, int size, u32 val)
{
struct pcie_port *pp = bus->sysdata;
- int ret;
if (dw_pcie_valid_config(pp, bus, PCI_SLOT(devfn)) == 0)
return PCIBIOS_DEVICE_NOT_FOUND;
--
2.5.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-01-11 14:43 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-01-11 11:41 [PATCH] PCI: designware: Remove unused variable Fabio Estevam
2016-01-11 14:43 ` Bjorn Helgaas
-- strict thread matches above, loose matches on Subject: below --
2016-01-11 12:11 [PATCH] PCI: designware: remove " Arnd Bergmann
2016-01-11 12:15 [PATCH] PCI: designware: Remove " Thierry Reding
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).