linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Woodhouse <dwmw2@infradead.org>
To: Bjorn Helgaas <helgaas@kernel.org>,
	"Lawrynowicz, Jacek" <jacek.lawrynowicz@intel.com>
Cc: Alex Williamson <alex.williamson@redhat.com>,
	"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
	"bhelgaas@google.com" <bhelgaas@google.com>,
	"jroedel@suse.de" <jroedel@suse.de>
Subject: Re: [PATCH] pci: Add support for multiple DMA aliases
Date: Thu, 21 Jan 2016 09:39:01 +0000	[thread overview]
Message-ID: <1453369141.4639.73.camel@infradead.org> (raw)
In-Reply-To: <20160120174622.GC7973@localhost>

[-- Attachment #1: Type: text/plain, Size: 1127 bytes --]

On Wed, 2016-01-20 at 11:46 -0600, Bjorn Helgaas wrote:
> 
> I don't really want to merge things that only exist to enable
> out-of-tree development, because (1) they're an extra maintenance
> burden for which we get risk without benefit, and (2) we can't see
> the out-of-tree code, so it's easy for people to make changes that
> accidentally break that code.
> 
> Looking at the patch again, I see that even without the export,
> there's no current benefit,

This is just a PCI quirk; I'm not sure it should be considered part of
the driver code at all. With this patch, even without a Linux driver,
we could correctly handle assignment to VM guests (which *might* have a
driver), and also theoretically we should be able to handle fault
storms and shoot the right device in the head if it was left in an odd
state and misbehaves (not that I've hooked that up yet).

So I'm not sure it makes sense to tie this patch to the existence of a
driver.
 
-- 
David Woodhouse                            Open Source Technology Centre
David.Woodhouse@intel.com                              Intel Corporation


[-- Attachment #2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 5691 bytes --]

  reply	other threads:[~2016-01-21  9:39 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-18 11:59 [PATCH] pci: Add support for multiple DMA aliases Jacek Lawrynowicz
2016-01-18 16:07 ` Jacek Lawrynowicz
2016-01-19  3:33   ` Bjorn Helgaas
2016-01-19  9:21     ` Lawrynowicz, Jacek
2016-01-19 20:12     ` Bjorn Helgaas
2016-01-19 21:04       ` Alex Williamson
2016-01-19 21:39         ` Bjorn Helgaas
2016-01-20 15:02           ` Lawrynowicz, Jacek
2016-01-20 17:46             ` Bjorn Helgaas
2016-01-21  9:39               ` David Woodhouse [this message]
2016-01-21 15:22                 ` Bjorn Helgaas
2016-01-21 15:32                   ` David Woodhouse
2016-01-26 10:15                     ` Lawrynowicz, Jacek
2016-01-21 12:43               ` Lawrynowicz, Jacek
  -- strict thread matches above, loose matches on Subject: below --
2016-02-29 22:44 [PATCH v4 3/6] PCI: " Bjorn Helgaas
2016-03-03 14:22 ` [PATCH] " Jacek Lawrynowicz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1453369141.4639.73.camel@infradead.org \
    --to=dwmw2@infradead.org \
    --cc=alex.williamson@redhat.com \
    --cc=bhelgaas@google.com \
    --cc=helgaas@kernel.org \
    --cc=jacek.lawrynowicz@intel.com \
    --cc=jroedel@suse.de \
    --cc=linux-pci@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).