From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from metis.ext.4.pengutronix.de ([92.198.50.35]:34376 "EHLO metis.ext.4.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751251AbcCHOxx (ORCPT ); Tue, 8 Mar 2016 09:53:53 -0500 Message-ID: <1457448829.3207.22.camel@pengutronix.de> Subject: Re: iMX6q PCIe phy link never came up on kernel v4.4.x From: Lucas Stach To: Roberto Fichera Cc: Richard Zhu , Bjorn Helgaas , "linux-pci@vger.kernel.org" , Richard Zhu Date: Tue, 08 Mar 2016 15:53:49 +0100 In-Reply-To: <56DEE426.8030902@tekno-soft.it> References: <56D5E3DF.9030906@tekno-soft.it> <56D71F27.7070708@tekno-soft.it> <20160302195634.GA19223@localhost> <56D80435.90408@tekno-soft.it> <56D8180A.1050708@tekno-soft.it> <56D84B6D.1050800@tekno-soft.it> <56D883AD.5060601@tekno-soft.it> <56DEE426.8030902@tekno-soft.it> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Sender: linux-pci-owner@vger.kernel.org List-ID: Am Dienstag, den 08.03.2016, 15:39 +0100 schrieb Roberto Fichera: > On 03/03/2016 07:34 PM, Roberto Fichera wrote: > > On 03/03/2016 03:34 PM, Roberto Fichera wrote: > > > > I've also checked clock, pll, PMU_MISC1 and CCGR[45] registers, all looks fine > > and exactly equal to uboot settings. > > > > However I'm investigating a possible HW issue in the LDVS pad wiring against > > the bridge XIO2001. Let's see once this is also clarified. > > Our HW engineer has applied a fix to LVDS vs XIO2001 clock wiring. However I'm still getting the same problem. > > I've tried to boot a kernel with uboot not setting up the PCIe subsys and below there is the resulting kernel log. > Note that the CCGR5 doesn't set the CG2 field associated to sata_clk_enable. I think this field should be set all 1 to > enable the SATA ref at 100MHz, right? > No, the reference manual is a bit confusing about this, but the LVDS1 clock output is driven by sata_ref_100mhz, not the sata_clk gate. So the only thing that needs to be enabled for LVDS clock output is the 100MHz clock output from PLL ENET. (Register CCM_ANALOG_PLL_ENETn bit 20). Can you please try to revert the commit I pointed out in my last mail and see if it helps? We might be holding the PCI device reset gpio at the wrong level with this commit. Regards, Lucas