linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rob Groner <rgroner@rtd.com>
To: <linux-pci@vger.kernel.org>
Cc: <jiang.liu@linux.intel.com>, <bhelgaas@google.com>, <tglx@linutronix.de>
Subject: PCI IRQ issue since 4.2 kernel
Date: Thu, 31 Mar 2016 09:26:35 -0400	[thread overview]
Message-ID: <1459430795.1998.11.camel@rtd-VirtualBox> (raw)

Greetings,

We became aware of an issue with our Linux drivers when used with a 4.4
kernel.  These drivers had worked previously from 2.6.35 to 4.2 kernels.
The symptoms were that, even though the request_irq() call was
successful, we did not receive any IRQs.  IRQs did arrive on a different
IRQ line, however, and the kernel disabled that line because there was
no handler.

I can elaborate on this more if you'd like.

With Greg K-H's help, I found the commit where this issue first appears.
He told me to email the people listed in the commit and the pci mailing
list.

Is there something different I need to be doing when I request an IRQ
for my PCI device driver?  I checked the 4.2, 4.3, and 4.4 kernel change
logs and did not see anything obvious about the IRQ request process
changing.

Please let me know how to proceed next.

Thank you,

Rob

 -----------------------------------------------------------------------
 rtd@kernel-dev:~/git/kernels/linux$ git bisect good
 991de2e59090e55c65a7f59a049142e3c480f7bd is the first bad commit
 commit 991de2e59090e55c65a7f59a049142e3c480f7bd
 Author: Jiang Liu <jiang.liu@linux.intel.com>
 Date:   Wed Jun 10 16:54:59 2015 +0800
 
     PCI, x86: Implement pcibios_alloc_irq() and pcibios_free_irq()
     
     To support IOAPIC hotplug, we need to allocate PCI IRQ resources on
 demand
     and free them when not used anymore.
     
     Implement pcibios_alloc_irq() and pcibios_free_irq() to dynamically
     allocate and free PCI IRQs.
     
     Remove mp_should_keep_irq(), which is no longer used.
     
     [bhelgaas: changelog]
     Signed-off-by: Jiang Liu <jiang.liu@linux.intel.com>
     Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
     Acked-by: Thomas Gleixner <tglx@linutronix.de>
 
 :040000 040000 765e2d5232d53247ec260b34b51589c3bccb36ae
 f680234a27685e94b1a35ae2a7218f8eafa9071a M    arch
 :040000 040000 d55a682bcde72682e883365e88ad1df6186fd54d
 f82c470a04a6845fcf5e0aa934512c75628f798d M    drivers
 ----------------------------------------------------------------


             reply	other threads:[~2016-03-31 13:26 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-31 13:26 Rob Groner [this message]
2016-03-31 13:40 ` PCI IRQ issue since 4.2 kernel Bjorn Helgaas
2016-03-31 13:44   ` Rob Groner
2016-03-31 15:05   ` Rob Groner
2016-03-31 15:14     ` Bjorn Helgaas
2016-03-31 15:17       ` Rob Groner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1459430795.1998.11.camel@rtd-VirtualBox \
    --to=rgroner@rtd.com \
    --cc=bhelgaas@google.com \
    --cc=jiang.liu@linux.intel.com \
    --cc=linux-pci@vger.kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).