From: Jake Oshins <jakeo@microsoft.com>
To: linux-pci@vger.kernel.org, gregkh@linuxfoundation.org,
kys@microsoft.com, linux-kernel@vger.kernel.org,
devel@linuxdriverproject.org, olaf@aepfle.de, apw@canonical.com,
vkuznets@redhat.com, haiyangz@microsoft.com,
haddenh@microsoft.com
Cc: Jake Oshins <jakeo@microsoft.com>
Subject: [PATCH v4 0/7] drivers:hv: Ensure that bridge windows don't overlap
Date: Fri, 1 Apr 2016 17:47:40 -0700 [thread overview]
Message-ID: <1459558067-1725-1-git-send-email-jakeo@microsoft.com> (raw)
In-Reply-To: <y>
This series differs from v3 in that it folds in a patch suggested by
the kbuild test robot, substituting resource_size() for directly
calculating the size.
Hyper-V VMs expose paravirtual drivers through a mechanism called
VMBus, which is managed by hv_vmbus.ko. For each parvirtual service
instance, this driver exposes a new child device. Some of these child
devices need memory address space, into which Hyper-V will map things
like the virtual video frame buffer. This memory-mapped address space
is chosen by the guest OS, not the hypervisor.
This is difficult to map onto the Linux pnp layer, as the code in the
pnp layer to choose MMIO space keys off of bus type and it doesn't know
anything about VMBus. The maintainers of the pnp layer have asked that
we not offer patches to it that make it understand VMBus, but that we
rather find ways of using the code in its current state. So hv_vmbus.ko
exports a function, vmbus_allocate_mmio() for choosing the address space
for any child driver that needs this facility.
The recently introduced PCI front-end driver for Hyper-V VMs
(pci-hyperv.ko) uses vmbus_allocate_mmio() for choosing both the region
of memory space into which real PCI Express devices are mapped. The
regions allocated are made to look like root PCI bus bridge windows
to the PCI driver, reusing all the code in the PCI driver for the rest
of PCI device management.
The problem is that these bridge windows are marked in such a way that
devices can still allocate from the memory space spanned by them, and
this means that if two different PCI buses are created in the VM, each
with devices under them, they may allocate the same memory space, leading
to PCI Base Address Register which overlap.
This patch series fixes the problem by tracking allocations to child
devices in a separate resource tree, marking them such that the bridge
windows can't overlap. The main memory resource tree, iomem_resource,
contains resources properly marked as bridge windows, allowing their
children to overlap with them.
Jake Oshins (7):
drivers:hv: Lock access to hyperv_mmio resource tree
drivers:hv: Make a function to free mmio regions through vmbus
drivers:hv: Use new vmbus_mmio_free() from client drivers.
drivers:hv: Reverse order of resources in hyperv_mmio
drivers:hv: Track allocations of children of hv_vmbus in private
resource tree
drivers:hv: Record MMIO range in use by frame buffer
drivers:hv: Separate out frame buffer logic when picking MMIO range
drivers/hv/vmbus_drv.c | 143 +++++++++++++++++++++++++++++-----------
drivers/pci/host/pci-hyperv.c | 14 ++--
drivers/video/fbdev/hyperv_fb.c | 4 +-
include/linux/hyperv.h | 2 +-
4 files changed, 115 insertions(+), 48 deletions(-)
--
1.9.1
next reply other threads:[~2016-04-01 23:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-02 0:47 Jake Oshins [this message]
2016-04-02 0:47 ` [PATCH v4 1/7] drivers:hv: Lock access to hyperv_mmio resource tree Jake Oshins
2016-04-02 0:47 ` [PATCH v4 2/7] drivers:hv: Make a function to free mmio regions through vmbus Jake Oshins
2016-04-02 0:47 ` [PATCH v4 3/7] drivers:hv: Use new vmbus_mmio_free() from client drivers Jake Oshins
2016-04-05 17:59 ` Bjorn Helgaas
2016-04-05 18:20 ` KY Srinivasan
2016-04-05 20:13 ` Jake Oshins
2016-04-02 0:47 ` [PATCH v4 4/7] drivers:hv: Reverse order of resources in hyperv_mmio Jake Oshins
2016-04-02 0:47 ` [PATCH v4 5/7] drivers:hv: Track allocations of children of hv_vmbus in private resource tree Jake Oshins
2016-04-02 0:47 ` [PATCH v4 6/7] drivers:hv: Record MMIO range in use by frame buffer Jake Oshins
2016-04-02 0:47 ` [PATCH v4 7/7] drivers:hv: Separate out frame buffer logic when picking MMIO range Jake Oshins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1459558067-1725-1-git-send-email-jakeo@microsoft.com \
--to=jakeo@microsoft.com \
--cc=apw@canonical.com \
--cc=devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=haddenh@microsoft.com \
--cc=haiyangz@microsoft.com \
--cc=kys@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=olaf@aepfle.de \
--cc=vkuznets@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).