From: Andreas Noever <andreas.noever@gmail.com>
To: helgaas@kernel.org, linux-pci@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
Andreas Noever <andreas.noever@gmail.com>,
Lukas Wunner <lukas@wunner.de>,
stable@vger.kernel.org
Subject: [PATCH] thunderbolt: Fix double free of drom buffer
Date: Sun, 10 Apr 2016 12:48:27 +0200 [thread overview]
Message-ID: <1460285307-3557-1-git-send-email-andreas.noever@gmail.com> (raw)
If tb_drom_read fails sw->drom is freed but not set to NULL. sw->drom
is then freed again in the error path of sw_switch_alloc.
The bug can be triggered by unplugging a thunderbolt device shortly
after it is detected by the thunderbolt driver.
Signed-off-by: Andreas Noever <andreas.noever@gmail.com>
Cc: Lukas Wunner <lukas@wunner.de>
Cc: stable@vger.kernel.org
---
drivers/thunderbolt/eeprom.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/thunderbolt/eeprom.c b/drivers/thunderbolt/eeprom.c
index 0dde34e..545c60c 100644
--- a/drivers/thunderbolt/eeprom.c
+++ b/drivers/thunderbolt/eeprom.c
@@ -444,6 +444,7 @@ int tb_drom_read(struct tb_switch *sw)
return tb_drom_parse_entries(sw);
err:
kfree(sw->drom);
+ sw->drom = NULL;
return -EIO;
}
--
2.8.0
next reply other threads:[~2016-04-10 10:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-10 10:48 Andreas Noever [this message]
2016-05-02 17:30 ` [PATCH] thunderbolt: Fix double free of drom buffer Bjorn Helgaas
2016-05-02 23:18 ` Andreas Noever
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1460285307-3557-1-git-send-email-andreas.noever@gmail.com \
--to=andreas.noever@gmail.com \
--cc=helgaas@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).