From: Keith Busch <keith.busch@intel.com>
To: linux-pci@vger.kernel.org, Bjorn Helgaas <bhelgaas@google.com>,
linux-nvme@lists.infradead.org, Jens Axboe <axboe@fb.com>,
Christoph Hellwig <hch@infradead.org>
Cc: Keith Busch <keith.busch@intel.com>
Subject: [PATCH 1/2] pci: Error disabling SR-IOV if in VFs assigned
Date: Tue, 17 May 2016 15:39:58 -0600 [thread overview]
Message-ID: <1463521199-16604-1-git-send-email-keith.busch@intel.com> (raw)
Every sriov capable driver has to check if any guest is using a virtual
function prior to disabling, so let's make it common code.
Signed-off-by: Keith Busch <keith.busch@intel.com>
---
drivers/pci/pci-sysfs.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/pci/pci-sysfs.c b/drivers/pci/pci-sysfs.c
index 342b691..5011fa9 100644
--- a/drivers/pci/pci-sysfs.c
+++ b/drivers/pci/pci-sysfs.c
@@ -487,6 +487,11 @@ static ssize_t sriov_numvfs_store(struct device *dev,
if (num_vfs == 0) {
/* disable VFs */
+ if (pci_vfs_assigned(pdev)) {
+ dev_warn(&pdev->dev,
+ "Cannot disable SR-IOV VFs while assigned\n");
+ return -EPERM;
+ }
ret = pdev->driver->sriov_configure(pdev, 0);
if (ret < 0)
return ret;
--
2.7.2
next reply other threads:[~2016-05-17 21:40 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-17 21:39 Keith Busch [this message]
2016-05-17 21:39 ` [PATCH 2/2] nvme/pci: Enable SR-IOV capabilities Keith Busch
2016-05-23 10:52 ` Christoph Hellwig
2016-05-23 17:06 ` Bjorn Helgaas
2016-05-23 17:09 ` Christoph Hellwig
2016-05-23 17:21 ` Keith Busch
2016-05-23 21:51 ` Bjorn Helgaas
2016-05-17 22:08 ` [PATCH 1/2] pci: Error disabling SR-IOV if in VFs assigned Alex Williamson
2016-05-23 10:55 ` Christoph Hellwig
2016-05-23 15:07 ` Alex Williamson
2016-05-23 15:10 ` Christoph Hellwig
2016-06-13 21:14 ` Bjorn Helgaas
2016-06-13 21:28 ` Keith Busch
2016-06-13 21:57 ` Keith Busch
2016-06-13 22:26 ` Bjorn Helgaas
2016-06-13 22:35 ` Keith Busch
2016-06-15 10:26 ` Christoph Hellwig
2016-06-15 15:38 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1463521199-16604-1-git-send-email-keith.busch@intel.com \
--to=keith.busch@intel.com \
--cc=axboe@fb.com \
--cc=bhelgaas@google.com \
--cc=hch@infradead.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).