From: Rui Wang <rui.y.wang@intel.com>
To: tglx@linutronix.de
Cc: rjw@rjwysocki.net, tony.luck@intel.com, bhelgaas@google.com,
linux-acpi@vger.kernel.org, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org, rui.y.wang@intel.com
Subject: Re: [PATCH 2/2] x86/ioapic: Fix wrong pointers in ioapic_setup_resources()
Date: Wed, 8 Jun 2016 08:07:19 +0800 [thread overview]
Message-ID: <1465344439-3373-1-git-send-email-rui.y.wang@intel.com> (raw)
In-Reply-To: <alpine.DEB.2.11.1606071111100.28031@nanos>
On Tuesday, June 7, 2016 5:17 PM, Thomas Gleixner wrote:
> On Tue, 7 Jun 2016, Rui Wang wrote:
> > Also simplify the function by removing the redundant 'num' variable.
> Please don't do that. This makes the patch hard to read. Split this into a
> minimal bugfix, which can be backported and a cleanup patch which gets rid of
> the extra variable.
> > - ioapics[i].iomem_res = res;
> > + ioapics[i].iomem_res = &res[i];
>
> If I read the patch correctly, then this is the fix. Right? So please make it
> a one liner and send a cleanup patch seperately.
Hi Thomas,
Yes exactly. I'll send a v2.
Thanks
Rui
prev parent reply other threads:[~2016-06-08 0:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-07 7:21 [PATCH 0/2] ioapic hot-removal bugs Rui Wang
2016-06-07 7:21 ` [PATCH 1/2] x86/ioapic: Support hot-removal of IOAPICs present during boot Rui Wang
2016-06-07 7:21 ` [PATCH 2/2] x86/ioapic: Fix wrong pointers in ioapic_setup_resources() Rui Wang
2016-06-07 9:17 ` Thomas Gleixner
2016-06-08 0:07 ` Rui Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1465344439-3373-1-git-send-email-rui.y.wang@intel.com \
--to=rui.y.wang@intel.com \
--cc=bhelgaas@google.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).