* [PATCH] PCI: imx6: Add missing required clocks
@ 2016-06-08 13:27 Fabio Estevam
2016-06-09 11:43 ` Fabio Estevam
2016-06-13 10:59 ` Lucas Stach
0 siblings, 2 replies; 3+ messages in thread
From: Fabio Estevam @ 2016-06-08 13:27 UTC (permalink / raw)
To: bhelgaas; +Cc: l.stach, hongxing.zhu, linux-pci, Fabio Estevam
The PCI hardware on imx6 requires the following clocks:
"pcie", "pcie_bus" and "pcie_phy", so add the missing clocks
in the clock-names property.
Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
---
Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt
index 83aeb1f..94ab92c 100644
--- a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt
+++ b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt
@@ -10,8 +10,8 @@ Required properties:
entry for each entry in the interrupt-names property.
- interrupt-names: Must include the following entries:
- "msi": The interrupt that is asserted when an MSI is received
-- clock-names: Must include the following additional entries:
- - "pcie_phy"
+- clock-names: Must include the following entries:
+ - "pcie", "pcie_bus" and "pcie_phy".
Optional properties:
- fsl,tx-deemph-gen1: Gen1 De-emphasis value. Default: 0
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] PCI: imx6: Add missing required clocks
2016-06-08 13:27 [PATCH] PCI: imx6: Add missing required clocks Fabio Estevam
@ 2016-06-09 11:43 ` Fabio Estevam
2016-06-13 10:59 ` Lucas Stach
1 sibling, 0 replies; 3+ messages in thread
From: Fabio Estevam @ 2016-06-09 11:43 UTC (permalink / raw)
To: Fabio Estevam
Cc: Bjorn Helgaas, Lucas Stach, Richard Zhu,
linux-pci@vger.kernel.org
On Wed, Jun 8, 2016 at 10:27 AM, Fabio Estevam <fabio.estevam@nxp.com> wrote:
> The PCI hardware on imx6 requires the following clocks:
> "pcie", "pcie_bus" and "pcie_phy", so add the missing clocks
> in the clock-names property.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
> ---
> Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt
> index 83aeb1f..94ab92c 100644
> --- a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt
> +++ b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt
> @@ -10,8 +10,8 @@ Required properties:
> entry for each entry in the interrupt-names property.
> - interrupt-names: Must include the following entries:
> - "msi": The interrupt that is asserted when an MSI is received
> -- clock-names: Must include the following additional entries:
> - - "pcie_phy"
> +- clock-names: Must include the following entries:
> + - "pcie", "pcie_bus" and "pcie_phy".
Ah, just realized that the "pcie" and "pcie_bus" are already listed
in designware-pci.txt.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] PCI: imx6: Add missing required clocks
2016-06-08 13:27 [PATCH] PCI: imx6: Add missing required clocks Fabio Estevam
2016-06-09 11:43 ` Fabio Estevam
@ 2016-06-13 10:59 ` Lucas Stach
1 sibling, 0 replies; 3+ messages in thread
From: Lucas Stach @ 2016-06-13 10:59 UTC (permalink / raw)
To: Fabio Estevam; +Cc: bhelgaas, hongxing.zhu, linux-pci
Am Mittwoch, den 08.06.2016, 10:27 -0300 schrieb Fabio Estevam:
> The PCI hardware on imx6 requires the following clocks:
> "pcie", "pcie_bus" and "pcie_phy", so add the missing clocks
> in the clock-names property.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
> ---
> Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt
> index 83aeb1f..94ab92c 100644
> --- a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt
> +++ b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt
> @@ -10,8 +10,8 @@ Required properties:
> entry for each entry in the interrupt-names property.
> - interrupt-names: Must include the following entries:
> - "msi": The interrupt that is asserted when an MSI is received
> -- clock-names: Must include the following additional entries:
> - - "pcie_phy"
> +- clock-names: Must include the following entries:
> + - "pcie", "pcie_bus" and "pcie_phy".
NACK.
Both "pcie" and "pcie_bus" are inherited from the common
designware-pcie.txt binding. That's why it reads "must include the
following ADDITIONAL entries".
Regards,
Lucas
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-06-13 10:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-06-08 13:27 [PATCH] PCI: imx6: Add missing required clocks Fabio Estevam
2016-06-09 11:43 ` Fabio Estevam
2016-06-13 10:59 ` Lucas Stach
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).