From: Lucas Stach <l.stach@pengutronix.de>
To: Fabio Estevam <fabio.estevam@nxp.com>
Cc: bhelgaas@google.com, hongxing.zhu@nxp.com, linux-pci@vger.kernel.org
Subject: Re: [PATCH] PCI: imx6: Add missing required clocks
Date: Mon, 13 Jun 2016 12:59:03 +0200 [thread overview]
Message-ID: <1465815543.2313.9.camel@pengutronix.de> (raw)
In-Reply-To: <1465392461-3469-1-git-send-email-fabio.estevam@nxp.com>
Am Mittwoch, den 08.06.2016, 10:27 -0300 schrieb Fabio Estevam:
> The PCI hardware on imx6 requires the following clocks:
> "pcie", "pcie_bus" and "pcie_phy", so add the missing clocks
> in the clock-names property.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
> ---
> Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt
> index 83aeb1f..94ab92c 100644
> --- a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt
> +++ b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt
> @@ -10,8 +10,8 @@ Required properties:
> entry for each entry in the interrupt-names property.
> - interrupt-names: Must include the following entries:
> - "msi": The interrupt that is asserted when an MSI is received
> -- clock-names: Must include the following additional entries:
> - - "pcie_phy"
> +- clock-names: Must include the following entries:
> + - "pcie", "pcie_bus" and "pcie_phy".
NACK.
Both "pcie" and "pcie_bus" are inherited from the common
designware-pcie.txt binding. That's why it reads "must include the
following ADDITIONAL entries".
Regards,
Lucas
prev parent reply other threads:[~2016-06-13 10:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-08 13:27 [PATCH] PCI: imx6: Add missing required clocks Fabio Estevam
2016-06-09 11:43 ` Fabio Estevam
2016-06-13 10:59 ` Lucas Stach [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1465815543.2313.9.camel@pengutronix.de \
--to=l.stach@pengutronix.de \
--cc=bhelgaas@google.com \
--cc=fabio.estevam@nxp.com \
--cc=hongxing.zhu@nxp.com \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).