* [PATCH 9/9] [RFC] pci: include <asm/dma.h> for isa_dma_bridge_buggy [not found] <1466175913-19067-1-git-send-email-ben.dooks@codethink.co.uk> @ 2016-06-17 15:05 ` Ben Dooks 2016-07-19 22:05 ` Bjorn Helgaas 0 siblings, 1 reply; 2+ messages in thread From: Ben Dooks @ 2016-06-17 15:05 UTC (permalink / raw) To: linux-kernel Cc: Ben Dooks, Bjorn Helgaas, linux-pci, linux-kernel, linux-arm-kernel At least on arm, <asm/dma.h> does not get included when building drivers/pci/pci.o. This causes the following build warning which can be fixed by including <asm/dma.h>: drivers/pci/pci.c:37:5: warning: symbol 'isa_dma_bridge_buggy' was not declared. Should it be static? Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk> --- Cc: Bjorn Helgaas <bhelgaas@google.com> Cc: linux-pci@vger.kernel.org Cc: linux-kernel@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org --- drivers/pci/pci.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c index 9add285..86b538d 100644 --- a/drivers/pci/pci.c +++ b/drivers/pci/pci.c @@ -26,6 +26,7 @@ #include <linux/pm_runtime.h> #include <linux/pci_hotplug.h> #include <asm/setup.h> +#include <asm/dma.h> #include <linux/aer.h> #include "pci.h" -- 2.8.1 ^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 9/9] [RFC] pci: include <asm/dma.h> for isa_dma_bridge_buggy 2016-06-17 15:05 ` [PATCH 9/9] [RFC] pci: include <asm/dma.h> for isa_dma_bridge_buggy Ben Dooks @ 2016-07-19 22:05 ` Bjorn Helgaas 0 siblings, 0 replies; 2+ messages in thread From: Bjorn Helgaas @ 2016-07-19 22:05 UTC (permalink / raw) To: Ben Dooks Cc: linux-kernel, Bjorn Helgaas, linux-kernel, linux-arm-kernel, linux-pci On Fri, Jun 17, 2016 at 04:05:13PM +0100, Ben Dooks wrote: > At least on arm, <asm/dma.h> does not get included when building > drivers/pci/pci.o. This causes the following build warning which > can be fixed by including <asm/dma.h>: > > drivers/pci/pci.c:37:5: warning: symbol 'isa_dma_bridge_buggy' was not declared. Should it be static? > > Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk> Applied to pci/misc for v4.8, thanks, Ben! > --- > Cc: Bjorn Helgaas <bhelgaas@google.com> > Cc: linux-pci@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Cc: linux-arm-kernel@lists.infradead.org > --- > drivers/pci/pci.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c > index 9add285..86b538d 100644 > --- a/drivers/pci/pci.c > +++ b/drivers/pci/pci.c > @@ -26,6 +26,7 @@ > #include <linux/pm_runtime.h> > #include <linux/pci_hotplug.h> > #include <asm/setup.h> > +#include <asm/dma.h> > #include <linux/aer.h> > #include "pci.h" > > -- > 2.8.1 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-pci" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-07-19 22:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1466175913-19067-1-git-send-email-ben.dooks@codethink.co.uk>
2016-06-17 15:05 ` [PATCH 9/9] [RFC] pci: include <asm/dma.h> for isa_dma_bridge_buggy Ben Dooks
2016-07-19 22:05 ` Bjorn Helgaas
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).