* [PATCH] pciehp: Clear attention LED on device add
@ 2016-08-03 23:29 Keith Busch
2016-08-22 16:59 ` Bjorn Helgaas
0 siblings, 1 reply; 2+ messages in thread
From: Keith Busch @ 2016-08-03 23:29 UTC (permalink / raw)
To: linux-pci, Bjorn Helgaas; +Cc: Wei Zhang, Keith Busch
This patch clears the LED attention status after a successful device
add. It is possible the attention LED was on from a previous power fault
or link failure, and a subsequent successful device inserted in the slot
should clear it.
Signed-off-by: Keith Busch <keith.busch@intel.com>
---
drivers/pci/hotplug/pciehp_ctrl.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/pci/hotplug/pciehp_ctrl.c b/drivers/pci/hotplug/pciehp_ctrl.c
index 880978b..7ea3e61 100644
--- a/drivers/pci/hotplug/pciehp_ctrl.c
+++ b/drivers/pci/hotplug/pciehp_ctrl.c
@@ -120,6 +120,7 @@ static int board_added(struct slot *p_slot)
}
pciehp_green_led_on(p_slot);
+ pciehp_set_attention_status(p_slot, 0);
return 0;
err_exit:
--
2.7.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] pciehp: Clear attention LED on device add
2016-08-03 23:29 [PATCH] pciehp: Clear attention LED on device add Keith Busch
@ 2016-08-22 16:59 ` Bjorn Helgaas
0 siblings, 0 replies; 2+ messages in thread
From: Bjorn Helgaas @ 2016-08-22 16:59 UTC (permalink / raw)
To: Keith Busch; +Cc: linux-pci, Bjorn Helgaas, Wei Zhang
On Wed, Aug 03, 2016 at 05:29:45PM -0600, Keith Busch wrote:
> This patch clears the LED attention status after a successful device
> add. It is possible the attention LED was on from a previous power fault
> or link failure, and a subsequent successful device inserted in the slot
> should clear it.
>
> Signed-off-by: Keith Busch <keith.busch@intel.com>
Applied to pci/hotplug for v4.9, thanks, Keith!
> ---
> drivers/pci/hotplug/pciehp_ctrl.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/pci/hotplug/pciehp_ctrl.c b/drivers/pci/hotplug/pciehp_ctrl.c
> index 880978b..7ea3e61 100644
> --- a/drivers/pci/hotplug/pciehp_ctrl.c
> +++ b/drivers/pci/hotplug/pciehp_ctrl.c
> @@ -120,6 +120,7 @@ static int board_added(struct slot *p_slot)
> }
>
> pciehp_green_led_on(p_slot);
> + pciehp_set_attention_status(p_slot, 0);
> return 0;
>
> err_exit:
> --
> 2.7.2
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pci" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-08-22 16:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-08-03 23:29 [PATCH] pciehp: Clear attention LED on device add Keith Busch
2016-08-22 16:59 ` Bjorn Helgaas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).