From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Ingo Molnar <mingo@kernel.org>, Bjorn Helgaas <bhelgaas@google.com>
Cc: Lukas Wunner <lukas@wunner.de>,
linux-pci@vger.kernel.org, x86@kernel.org,
Ingo Molnar <mingo@redhat.com>
Subject: Re: [PATCH v2] x86/platform/intel-mid: Retrofit pci_platform_pm_ops ->get_state hook
Date: Wed, 19 Oct 2016 16:42:38 +0300 [thread overview]
Message-ID: <1476884558.11323.494.camel@linux.intel.com> (raw)
In-Reply-To: <20161011083744.GA7577@gmail.com>
On Tue, 2016-10-11 at 10:37 +0200, Ingo Molnar wrote:
> * Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
>
> >
> > On Sun, 2016-10-09 at 14:46 +0200, Lukas Wunner wrote:
> > >
> > > Commit cc7cc02bada8 ("PCI: Query platform firmware for device
> > > power
> > > state") augmented struct pci_platform_pm_ops with a ->get_state
> > > hook
> > > and
> > > implemented it for acpi_pci_platform_pm, the only
> > > pci_platform_pm_ops
> > > existing till v4.7.
> > >
> > > However v4.8 introduced another pci_platform_pm_ops for Intel
> > > Mobile
> > > Internet Devices with commit 5823d0893ec2 ("x86/platform/intel-
> > > mid:
> > > Add
> > > Power Management Unit driver"). It is missing the ->get_state
> > > hook,
> > > which is fatal since pci_set_platform_pm() enforces its presence.
> > >
> > > Retrofit mid_pci_platform_pm with the missing callback to fix the
> > > breakage.
> > >
> >
> > +Ingo.
> >
> > I guess it should go via tip/x86/urgent tree.
>
> Can do, if Bjorn is fine with it as well - the patch is touching
> drivers/pci/pci-mid.c.
Bjorn, we are at 4.9-rc1 already and it has this regression. Can you,
please, ACK it?
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
next prev parent reply other threads:[~2016-10-19 14:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-09 12:46 [PATCH v2] x86/platform/intel-mid: Retrofit pci_platform_pm_ops ->get_state hook Lukas Wunner
2016-10-09 15:01 ` Andy Shevchenko
2016-10-11 8:37 ` Ingo Molnar
2016-10-19 13:42 ` Andy Shevchenko [this message]
2016-10-19 15:10 ` Bjorn Helgaas
2016-10-19 15:48 ` Andy Shevchenko
2016-10-19 18:04 ` Lukas Wunner
2016-10-22 15:31 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1476884558.11323.494.camel@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=bhelgaas@google.com \
--cc=linux-pci@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).