From: Keith Busch <keith.busch@intel.com>
To: linux-pci@vger.kernel.org, Bjorn Helgaas <bhelgaas@google.com>
Cc: Lukas Wunner <lukas@wunner.de>, Wei Zhang <wzhang@fb.com>,
Keith Busch <keith.busch@intel.com>
Subject: [PATCHv4 next 3/3] pci/msix: Skip disabling removed devices
Date: Fri, 28 Oct 2016 18:58:17 -0400 [thread overview]
Message-ID: <1477695497-6207-4-git-send-email-keith.busch@intel.com> (raw)
In-Reply-To: <1477695497-6207-1-git-send-email-keith.busch@intel.com>
There is no need to disable MSIx interrupts or write message data on a
device that isn't present. This patch checks the device removed state
prior to executing device shutdown operations so that tear down on
removed devices completes quicker.
Signed-off-by: Keith Busch <keith.busch@intel.com>
Cc: Lukas Wunner <lukas@wunner.de>
---
drivers/pci/msi.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/pci/msi.c b/drivers/pci/msi.c
index bfdd074..9249ec1 100644
--- a/drivers/pci/msi.c
+++ b/drivers/pci/msi.c
@@ -317,7 +317,7 @@ void __pci_write_msi_msg(struct msi_desc *entry, struct msi_msg *msg)
{
struct pci_dev *dev = msi_desc_to_pci_dev(entry);
- if (dev->current_state != PCI_D0) {
+ if (dev->current_state != PCI_D0 || dev->is_removed) {
/* Don't touch the hardware now */
} else if (entry->msi_attrib.is_msix) {
void __iomem *base = pci_msix_desc_addr(entry);
@@ -1017,6 +1017,11 @@ void pci_msix_shutdown(struct pci_dev *dev)
if (!pci_msi_enable || !dev || !dev->msix_enabled)
return;
+ if (dev->is_removed) {
+ dev->msix_enabled = 0;
+ return;
+ }
+
/* Return the device with MSI-X masked as initial states */
for_each_pci_msi_entry(entry, dev) {
/* Keep cached states to be restored */
--
2.7.2
next prev parent reply other threads:[~2016-10-28 22:47 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-28 22:58 [PATCHv4 next 0/3] Limiting pci access Keith Busch
2016-10-28 22:58 ` [PATCHv4 next 1/3] pci: Add is_removed state Keith Busch
2016-10-31 10:41 ` Lukas Wunner
2016-12-13 20:56 ` Bjorn Helgaas
2016-12-13 23:07 ` Keith Busch
2016-12-14 2:50 ` Bjorn Helgaas
2016-12-14 2:54 ` Bjorn Helgaas
2016-12-13 23:54 ` Lukas Wunner
2016-10-28 22:58 ` [PATCHv4 next 2/3] pci: No config access for removed devices Keith Busch
2016-10-31 12:18 ` Lukas Wunner
2016-10-28 22:58 ` Keith Busch [this message]
2016-10-31 11:00 ` [PATCHv4 next 3/3] pci/msix: Skip disabling " Lukas Wunner
2016-10-31 13:54 ` Keith Busch
2016-12-13 21:18 ` Bjorn Helgaas
2016-12-13 23:01 ` Keith Busch
2016-11-18 23:25 ` [PATCHv4 next 0/3] Limiting pci access Keith Busch
2016-11-23 16:09 ` Bjorn Helgaas
2016-11-28 9:14 ` Wei Zhang
2016-11-28 10:22 ` Lukas Wunner
2016-11-28 18:02 ` Keith Busch
2016-12-08 17:54 ` Bjorn Helgaas
2016-12-08 19:32 ` Keith Busch
2016-12-12 23:42 ` Bjorn Helgaas
2016-12-13 0:55 ` Keith Busch
2016-12-13 20:50 ` Bjorn Helgaas
2016-12-13 23:18 ` Keith Busch
[not found] ` <B58D82457FDA0744A320A2FC5AC253B93D82F37D@fmsmsx104.amr.corp.intel.com>
[not found] ` <20170120213550.GA16618@localhost.localdomain>
2017-01-21 7:31 ` Lukas Wunner
2017-01-21 8:42 ` Greg Kroah-Hartman
2017-01-21 14:22 ` Lukas Wunner
2017-01-25 11:47 ` Greg Kroah-Hartman
2017-01-23 16:04 ` Keith Busch
2017-01-25 0:44 ` Austin.Bolen
2017-01-25 21:17 ` Bjorn Helgaas
2017-01-26 1:12 ` Austin.Bolen
2017-02-01 16:04 ` Bjorn Helgaas
2017-02-03 20:30 ` Austin.Bolen
2017-02-03 20:39 ` Greg KH
2017-02-03 21:43 ` Austin.Bolen
2017-01-25 11:48 ` Greg Kroah-Hartman
2017-01-28 7:36 ` Christoph Hellwig
2018-11-13 6:05 ` Bjorn Helgaas
2018-11-13 14:59 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1477695497-6207-4-git-send-email-keith.busch@intel.com \
--to=keith.busch@intel.com \
--cc=bhelgaas@google.com \
--cc=linux-pci@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=wzhang@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).