From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Bjorn Helgaas <helgaas@kernel.org>, Lukas Wunner <lukas@wunner.de>
Cc: linux-pci@vger.kernel.org, "Rafael J. Wysocki" <rjw@rjwysocki.net>
Subject: Re: [PATCH] x86/platform/intel-mid: Constify mid_pci_platform_pm
Date: Mon, 28 Nov 2016 21:43:13 +0200 [thread overview]
Message-ID: <1480362193.21899.35.camel@linux.intel.com> (raw)
In-Reply-To: <20161128192530.GO16033@bhelgaas-glaptop.roam.corp.google.com>
On Mon, 2016-11-28 at 13:25 -0600, Bjorn Helgaas wrote:
+Cc: Rafael
> I can't remember a discussion about having this code in drivers/pci in
> the first place. Would it make sense to move it to
> arch/x86/platform/intel-mid/?
>
> 8e522e1d321b ("x86/platform/intel-mid: Add Intel Penwell to ID table")
> fixed a sync issue and added a comment about staying in sync with
> arch/x86/platform/intel-mid/pwr.c. Maybe moving this code to arch/x86
> would help with that?
>
> Looks like we'd have to expose pci_platform_pm_ops and
> pci_set_platform_pm(), but setting platform-specific PM ops does seem
> like something that would fit in the arch directories, so maybe that
> wouldn't be a bad thing.
We have pci-acpi.c there which is used AFAIU by drivers/acpi. I'm not
sure that it's a good idea to spread users of pci_platform_pm_ops under
arch/x86 and drivers/acpi. OTOH I have no strong opinion. Whatever fits
better.
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
next prev parent reply other threads:[~2016-11-28 19:43 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-09 11:12 [PATCH] x86/platform/intel-mid: Constify mid_pci_platform_pm Lukas Wunner
2016-10-09 14:01 ` Andy Shevchenko
2016-11-28 11:29 ` Lukas Wunner
2016-11-28 19:25 ` Bjorn Helgaas
2016-11-28 19:43 ` Andy Shevchenko [this message]
2016-11-28 22:38 ` Lukas Wunner
2016-11-29 4:40 ` Bjorn Helgaas
-- strict thread matches above, loose matches on Subject: below --
2016-12-04 14:35 Lukas Wunner
2016-12-07 22:53 ` Bjorn Helgaas
2016-12-12 7:27 ` Ingo Molnar
2016-12-12 16:01 ` Bjorn Helgaas
2016-12-12 16:11 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1480362193.21899.35.camel@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=helgaas@kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).