From: Vaibhav Shankar <vaibhav.shankar@intel.com>
To: bhelgaas@google.com, vaibhav.shankar@intel.com
Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
venkateswarlu.v.vinjamuri@intel.com
Subject: [PATCH] PCI: pciehp: Optimize PCIe root resume time
Date: Fri, 9 Dec 2016 14:43:26 -0800 [thread overview]
Message-ID: <1481323406-12865-1-git-send-email-vaibhav.shankar@intel.com> (raw)
On Apollolake platforms, PCIe rootport takes a long time to resume
from S3. With 100ms delay before read pci conf, rootport takes
~200ms during resume.
commit 2f5d8e4ff947 ("PCI: pciehp: replace unconditional sleep with
config space access check") is the one that added the 100ms delay
before reading pci conf.
This patch removes the 100ms delay.By removing the delay, the
PCIe root port takes ~16ms during resume. As per PCIe spec, we
only require 1000ms delay. This delay is provide by
pci_bus_check_dev() function.
With 100ms delay:
[ 155.102713] calling 0000:00:14.0+ @ 70, parent: pci0000:00, cb: pci_pm_resume_noirq
[ 155.119337] call 0000:00:14.0+ returned 0 after 16231 usecs
[ 155.119467] calling 0000:01:00.0+ @ 5845, parent: 0000:00:14.0, cb: pci_pm_resume_noirq
[ 155.321670] call 0000:00:14.0+ returned 0 after 185327 usecs
[ 155.321743] calling 0000:01:00.0+ @ 5849, parent: 0000:00:14.0, cb: pci_pm_resume
After removing 100ms delay:
[ 36.624709] calling 0000:00:14.0+ @ 4434, parent: pci0000:00, cb: pci_pm_resume_noirq
[ 36.641367] call 0000:00:14.0+ returned 0 after 16263 usecs
[ 36.652458] calling 0000:00:14.0+ @ 4443, parent: pci0000:00, cb: pci_pm_resume
[ 36.652673] call 0000:00:14.0+ returned 0 after 208 usecs
[ 36.652863] calling 0000:01:00.0+ @ 4442, parent: 0000:00:14.0, cb: pci_pm_resume
Signed-off-by: Vaibhav Shankar <vaibhav.shankar@intel.com>
---
drivers/pci/hotplug/pciehp_hpc.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/pci/hotplug/pciehp_hpc.c b/drivers/pci/hotplug/pciehp_hpc.c
index 5c24e93..08357e7 100644
--- a/drivers/pci/hotplug/pciehp_hpc.c
+++ b/drivers/pci/hotplug/pciehp_hpc.c
@@ -311,8 +311,6 @@ int pciehp_check_link_status(struct controller *ctrl)
else
msleep(1000);
- /* wait 100ms before read pci conf, and try in 1s */
- msleep(100);
found = pci_bus_check_dev(ctrl->pcie->port->subordinate,
PCI_DEVFN(0, 0));
--
1.7.9.5
next reply other threads:[~2016-12-09 22:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-09 22:43 Vaibhav Shankar [this message]
2016-12-10 0:27 ` [PATCH] PCI: pciehp: Optimize PCIe root resume time Bjorn Helgaas
2016-12-11 1:19 ` Yinghai Lu
2016-12-13 0:32 ` [PATCH v2] " Vaibhav Shankar
2017-01-11 18:37 ` Bjorn Helgaas
2017-01-18 1:32 ` Shankar, Vaibhav
2017-01-18 5:13 ` Lukas Wunner
2017-01-19 2:57 ` Shankar, Vaibhav
2017-01-19 5:15 ` Lukas Wunner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1481323406-12865-1-git-send-email-vaibhav.shankar@intel.com \
--to=vaibhav.shankar@intel.com \
--cc=bhelgaas@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=venkateswarlu.v.vinjamuri@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).