From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Bjorn Helgaas <helgaas@kernel.org>, Ingo Molnar <mingo@kernel.org>
Cc: Lukas Wunner <lukas@wunner.de>,
x86@kernel.org, Bjorn Helgaas <bhelgaas@google.com>,
linux-pci@vger.kernel.org
Subject: Re: [PATCH] x86/platform/intel-mid: Constify mid_pci_platform_pm
Date: Mon, 12 Dec 2016 18:11:13 +0200 [thread overview]
Message-ID: <1481559073.7188.36.camel@linux.intel.com> (raw)
In-Reply-To: <20161212160155.GA29792@bhelgaas-glaptop.roam.corp.google.com>
On Mon, 2016-12-12 at 10:01 -0600, Bjorn Helgaas wrote:
> On Mon, Dec 12, 2016 at 08:27:33AM +0100, Ingo Molnar wrote:
> I can't remember why we decided to put pci-mid.c in drivers/pci.
In the first place there were no such comments like below.
> The
> obviously reason is that it uses pci_platform_pm_ops, which isn't
> visible outside drivers/pci, but pci-mid.c is clearly platform-
> specific, and even the name "pci_platform_pm_ops" sounds like
> something that should be implemented in the arch directories, so maybe
> pci_platform_pm_ops should be moved to include/linux/pci.h.
You are repeating yourself here. Last time I have referred to another
user of that struct which doesn't belong to arch, but to drivers/acpi.
And my opinion here is to keep things for now, until some common
solution would be developed.
> I have strange sense of déjà vu writing this, so sorry if I'm
> repeating something.
Yes, that's right.
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
next prev parent reply other threads:[~2016-12-12 16:11 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-04 14:35 [PATCH] x86/platform/intel-mid: Constify mid_pci_platform_pm Lukas Wunner
2016-12-07 22:53 ` Bjorn Helgaas
2016-12-12 7:27 ` Ingo Molnar
2016-12-12 16:01 ` Bjorn Helgaas
2016-12-12 16:11 ` Andy Shevchenko [this message]
-- strict thread matches above, loose matches on Subject: below --
2016-10-09 11:12 Lukas Wunner
2016-10-09 14:01 ` Andy Shevchenko
2016-11-28 11:29 ` Lukas Wunner
2016-11-28 19:25 ` Bjorn Helgaas
2016-11-28 19:43 ` Andy Shevchenko
2016-11-28 22:38 ` Lukas Wunner
2016-11-29 4:40 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1481559073.7188.36.camel@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=bhelgaas@google.com \
--cc=helgaas@kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=mingo@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).