From: Keith Busch <keith.busch@intel.com>
To: linux-pci@vger.kernel.org, Bjorn Helgaas <bhelgaas@google.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Lukas Wunner <lukas@wunner.de>, Wei Zhang <wzhang@fb.com>,
Austin Bolen <Austin.Bolen@dell.com>,
Christoph Hellwig <hch@infradead.org>,
Keith Busch <keith.busch@intel.com>
Subject: [PATCHv5 5/5] pci: Quick return for pci_device_is_present
Date: Fri, 3 Feb 2017 12:55:55 -0500 [thread overview]
Message-ID: <1486144555-5526-6-git-send-email-keith.busch@intel.com> (raw)
In-Reply-To: <1486144555-5526-1-git-send-email-keith.busch@intel.com>
If the pci device is disconnected, return false immediately for checking
presence. We can't rely on the pci device config accessors since
this function uses the bus accessors, so this patch has the explicit
disconnected check first.
Signed-off-by: Keith Busch <keith.busch@intel.com>
---
drivers/pci/pci.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
index a881c0d..b8d37e7 100644
--- a/drivers/pci/pci.c
+++ b/drivers/pci/pci.c
@@ -4932,6 +4932,8 @@ bool pci_device_is_present(struct pci_dev *pdev)
{
u32 v;
+ if (pci_dev_is_disconnected(pdev))
+ return false;
return pci_bus_read_dev_vendor_id(pdev->bus, pdev->devfn, &v, 0);
}
EXPORT_SYMBOL_GPL(pci_device_is_present);
--
2.7.2
next prev parent reply other threads:[~2017-02-03 17:47 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-03 17:55 [PATCHv5 0/5] Limiting PCI access Keith Busch
2017-02-03 17:55 ` [PATCHv5 1/5] pci: Export pci device config accessors Keith Busch
2017-02-06 17:30 ` Christoph Hellwig
2017-02-03 17:55 ` [PATCHv5 2/5] pci: Add device disconnected state Keith Busch
2017-02-03 20:53 ` Greg Kroah-Hartman
2017-02-06 17:32 ` Christoph Hellwig
2017-02-06 17:40 ` Greg Kroah-Hartman
2017-02-06 17:48 ` Christoph Hellwig
2017-02-06 17:54 ` Keith Busch
2017-02-06 17:33 ` Christoph Hellwig
2017-02-06 21:11 ` Keith Busch
2017-02-03 17:55 ` [PATCHv5 3/5] pci: No config access for disconnected devices Keith Busch
2017-02-06 17:34 ` Christoph Hellwig
2017-02-03 17:55 ` [PATCHv5 4/5] pci/msix: Skip disabling " Keith Busch
2017-02-06 17:35 ` Christoph Hellwig
2017-02-03 17:55 ` Keith Busch [this message]
2017-02-06 17:36 ` [PATCHv5 5/5] pci: Quick return for pci_device_is_present Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1486144555-5526-6-git-send-email-keith.busch@intel.com \
--to=keith.busch@intel.com \
--cc=Austin.Bolen@dell.com \
--cc=bhelgaas@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=hch@infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=wzhang@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).