linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sinan Kaya <okaya@codeaurora.org>
To: linux-pci@vger.kernel.org, timur@codeaurora.org
Cc: mayurkumar.patel@intel.com, linux-arm-msm@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Sinan Kaya <okaya@codeaurora.org>,
	Bjorn Helgaas <bhelgaas@google.com>,
	Rajat Jain <rajatja@google.com>,
	Shawn Lin <shawn.lin@rock-chips.com>,
	David Daney <david.daney@cavium.com>,
	Julia Lawall <Julia.Lawall@lip6.fr>,
	linux-kernel@vger.kernel.org
Subject: [PATCH V7 2/5] PCI/ASPM: split pci_aspm_init() into two
Date: Thu, 30 Mar 2017 09:30:33 -0400	[thread overview]
Message-ID: <1490880636-30542-3-git-send-email-okaya@codeaurora.org> (raw)
In-Reply-To: <1490880636-30542-1-git-send-email-okaya@codeaurora.org>

Split pci_aspm_init() body into pci_aspm_init_upstream()
and pci_aspm_init_downstream() for bridge and endpoint
specific code behavior.

Fixes: https://bugzilla.kernel.org/show_bug.cgi?id=194895
Signed-off-by: Sinan Kaya <okaya@codeaurora.org>
---
 drivers/pci/pcie/aspm.c | 15 ++++++++++++++-
 1 file changed, 14 insertions(+), 1 deletion(-)

diff --git a/drivers/pci/pcie/aspm.c b/drivers/pci/pcie/aspm.c
index dc36717..a80d64b 100644
--- a/drivers/pci/pcie/aspm.c
+++ b/drivers/pci/pcie/aspm.c
@@ -826,6 +826,16 @@ static struct pcie_link_state *alloc_pcie_link_state(struct pci_dev *pdev)
 	return link;
 }
 
+static int pci_aspm_init_downstream(struct pci_dev *pdev)
+{
+	return 0;
+}
+
+static int pci_aspm_init_upstream(struct pci_dev *pdev)
+{
+	return 0;
+}
+
 /*
  * pci_aspm_init: Initiate PCI express link state.
  * It is called from device_add for every single pci device.
@@ -833,7 +843,10 @@ static struct pcie_link_state *alloc_pcie_link_state(struct pci_dev *pdev)
  */
 int pci_aspm_init(struct pci_dev *pdev)
 {
-	return 0;
+	if (!pdev->has_secondary_link)
+		return pci_aspm_init_downstream(pdev);
+
+	return pci_aspm_init_upstream(pdev);
 }
 
 /*
-- 
1.9.1

  parent reply	other threads:[~2017-03-30 13:30 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-30 13:30 [PATCH V7 0/5] PCI/ASPM: reconfigure ASPM following hotplug for POLICY_DEFAULT Sinan Kaya
2017-03-30 13:30 ` [PATCH V7 1/5] PCI/ASPM: introduce pci_aspm_init() and add to pci_init_capabilities() Sinan Kaya
2017-03-30 13:30 ` Sinan Kaya [this message]
2017-03-30 13:30 ` [PATCH V7 3/5] PCI/ASPM: add init hook to device_add Sinan Kaya
2017-03-30 13:30 ` [PATCH V7 4/5] PCI/ASPM: save power on values during bridge init Sinan Kaya
2017-03-30 13:30 ` [PATCH V7 5/5] PCI/ASPM: move link_state cleanup to bridge remove Sinan Kaya
2017-04-04 13:13 ` [PATCH V7 0/5] PCI/ASPM: reconfigure ASPM following hotplug for POLICY_DEFAULT Sinan Kaya
2017-04-04 15:02   ` Patel, Mayurkumar
2017-04-06 13:23     ` Patel, Mayurkumar
2017-04-06 15:19       ` Sinan Kaya
2017-04-06 17:10         ` Rajat Jain
2017-04-07  0:34           ` Sinan Kaya
2017-04-07  9:03           ` Patel, Mayurkumar
2017-04-07 13:09             ` Sinan Kaya
2017-04-08  5:03               ` Sinan Kaya
     [not found]             ` <CACK8Z6Fg5fbYYeza2NfMbu5QhegVck0VNuqKKrFUNvAFoSC25g@mail.gmail.com>
2017-04-10 11:44               ` Patel, Mayurkumar
2017-04-06 15:36       ` Sinan Kaya
2017-04-06 15:56         ` Patel, Mayurkumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1490880636-30542-3-git-send-email-okaya@codeaurora.org \
    --to=okaya@codeaurora.org \
    --cc=Julia.Lawall@lip6.fr \
    --cc=bhelgaas@google.com \
    --cc=david.daney@cavium.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=mayurkumar.patel@intel.com \
    --cc=rajatja@google.com \
    --cc=shawn.lin@rock-chips.com \
    --cc=timur@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).