From: Sinan Kaya <okaya@codeaurora.org>
To: linux-pci@vger.kernel.org, timur@codeaurora.org
Cc: mayurkumar.patel@intel.com, David Daney <david.daney@cavium.com>,
linux-arm-msm@vger.kernel.org,
Shawn Lin <shawn.lin@rock-chips.com>,
linux-kernel@vger.kernel.org, Sinan Kaya <okaya@codeaurora.org>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Bjorn Helgaas <bhelgaas@google.com>,
Rajat Jain <rajatja@google.com>,
linux-arm-kernel@lists.infradead.org
Subject: [PATCH V8 2/5] PCI/ASPM: split pci_aspm_init() into two
Date: Sat, 8 Apr 2017 00:55:48 -0400 [thread overview]
Message-ID: <1491627351-1111-3-git-send-email-okaya@codeaurora.org> (raw)
In-Reply-To: <1491627351-1111-1-git-send-email-okaya@codeaurora.org>
Split pci_aspm_init() body into pci_aspm_init_upstream()
and pci_aspm_init_downstream() for bridge and endpoint
specific code behavior.
Fixes: https://bugzilla.kernel.org/show_bug.cgi?id=194895
Signed-off-by: Sinan Kaya <okaya@codeaurora.org>
---
drivers/pci/pcie/aspm.c | 15 ++++++++++++++-
1 file changed, 14 insertions(+), 1 deletion(-)
diff --git a/drivers/pci/pcie/aspm.c b/drivers/pci/pcie/aspm.c
index dc36717..a80d64b 100644
--- a/drivers/pci/pcie/aspm.c
+++ b/drivers/pci/pcie/aspm.c
@@ -826,6 +826,16 @@ static struct pcie_link_state *alloc_pcie_link_state(struct pci_dev *pdev)
return link;
}
+static int pci_aspm_init_downstream(struct pci_dev *pdev)
+{
+ return 0;
+}
+
+static int pci_aspm_init_upstream(struct pci_dev *pdev)
+{
+ return 0;
+}
+
/*
* pci_aspm_init: Initiate PCI express link state.
* It is called from device_add for every single pci device.
@@ -833,7 +843,10 @@ static struct pcie_link_state *alloc_pcie_link_state(struct pci_dev *pdev)
*/
int pci_aspm_init(struct pci_dev *pdev)
{
- return 0;
+ if (!pdev->has_secondary_link)
+ return pci_aspm_init_downstream(pdev);
+
+ return pci_aspm_init_upstream(pdev);
}
/*
--
1.9.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2017-04-08 4:55 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-08 4:55 [PATCH V8 0/5] PCI/ASPM: reconfigure ASPM following hotplug for POLICY_DEFAULT Sinan Kaya
2017-04-08 4:55 ` [PATCH V8 1/5] PCI/ASPM: introduce pci_aspm_init() and add to pci_init_capabilities() Sinan Kaya
2017-04-13 20:51 ` Bjorn Helgaas
2017-04-14 19:10 ` Sinan Kaya
2017-04-08 4:55 ` Sinan Kaya [this message]
[not found] ` <CACK8Z6EfUTDjCM=fmdHfWeu8UV5GN+i6PX9fKkR1H8K90TXozg@mail.gmail.com>
2017-04-13 18:25 ` [PATCH V8 2/5] PCI/ASPM: split pci_aspm_init() into two Bjorn Helgaas
2017-04-14 19:10 ` Sinan Kaya
2017-04-08 4:55 ` [PATCH V8 3/5] PCI/ASPM: add init hook to device_add Sinan Kaya
2017-04-13 20:48 ` Bjorn Helgaas
2017-04-13 21:02 ` Bjorn Helgaas
2017-04-14 1:19 ` Sinan Kaya
2017-04-14 1:30 ` Bjorn Helgaas
2017-04-08 4:55 ` [PATCH V8 4/5] PCI/ASPM: save power on values during bridge init Sinan Kaya
2017-04-12 19:19 ` Rajat Jain
2017-04-14 19:12 ` Sinan Kaya
2017-04-14 21:44 ` Bjorn Helgaas
2017-04-14 22:17 ` Sinan Kaya
2017-04-17 16:38 ` Bjorn Helgaas
2017-04-17 17:50 ` Sinan Kaya
2017-04-21 7:46 ` Patel, Mayurkumar
2017-04-21 13:50 ` Sinan Kaya
2017-04-21 14:13 ` Patel, Mayurkumar
2017-04-25 18:45 ` Bjorn Helgaas
2017-05-02 12:02 ` Patel, Mayurkumar
2017-05-03 21:10 ` Bjorn Helgaas
2017-05-15 9:10 ` Patel, Mayurkumar
2017-04-08 4:55 ` [PATCH V8 5/5] PCI/ASPM: move link_state cleanup to bridge remove Sinan Kaya
2017-04-10 11:37 ` [PATCH V8 0/5] PCI/ASPM: reconfigure ASPM following hotplug for POLICY_DEFAULT Patel, Mayurkumar
2017-04-10 13:07 ` Sinan Kaya
2017-04-10 13:11 ` Patel, Mayurkumar
2017-04-11 21:19 ` Bjorn Helgaas
2017-04-11 21:27 ` Sinan Kaya
2017-04-11 22:41 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1491627351-1111-3-git-send-email-okaya@codeaurora.org \
--to=okaya@codeaurora.org \
--cc=Julia.Lawall@lip6.fr \
--cc=bhelgaas@google.com \
--cc=david.daney@cavium.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mayurkumar.patel@intel.com \
--cc=rajatja@google.com \
--cc=shawn.lin@rock-chips.com \
--cc=timur@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).