From: Arnd Bergmann <arnd@arndb.de>
To: Liviu Dudau <liviu.dudau@arm.com>
Cc: Thierry Reding <thierry.reding@gmail.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Tomasz Nowicki <tn@semihalf.com>,
linux-pci@vger.kernel.org, linux-tegra@vger.kernel.org
Subject: Re: [PATCH v2 1/2] PCI: Add new method for registering PCI hosts
Date: Fri, 01 Jul 2016 17:17:11 +0200 [thread overview]
Message-ID: <14945085.QO6LcyFgTY@wuerfel> (raw)
In-Reply-To: <20160701145244.GD8609@e106497-lin.cambridge.arm.com>
On Friday, July 1, 2016 3:52:44 PM CEST Liviu Dudau wrote:
>
> >
> > or do you mean we should have extra alignment in there so the
> > private pointer has a minimum alignment higher than the
> > alignment of struct pci_host_bridge?
>
> but this ^. bridge pointer arithmetic means +1 is not necessarily +sizeof(struct pci_host_bridge)
> bytes. AFAIK that can be rounded to the nearest natural alignment for pointers on that
> architecture.
No, that's not how it works.
> > I'm absolutely fine with any of those suggestions, whichever
> > makes the nicest API.
>
> Does anyone need to subclass the pci_host_bridge structure? And is appending data right
> after the structure useful?
I was basically following the way alloc_etherdev() and a lot of other
subsystems handle it.
Arnd
next prev parent reply other threads:[~2016-07-01 15:23 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-30 15:19 [PATCH v2 1/2] PCI: Add new method for registering PCI hosts Thierry Reding
2016-06-30 15:19 ` [PATCH v2 2/2] PCI: tegra: Use new pci_register_host() interface Thierry Reding
2016-06-30 15:37 ` [PATCH v2 1/2] PCI: Add new method for registering PCI hosts Arnd Bergmann
2016-07-01 14:14 ` Liviu Dudau
2016-07-01 14:24 ` Arnd Bergmann
2016-07-01 14:52 ` Liviu Dudau
2016-07-01 15:17 ` Arnd Bergmann [this message]
2016-07-01 15:40 ` Liviu Dudau
2016-07-01 15:58 ` Arnd Bergmann
2016-07-01 14:46 ` Liviu Dudau
2016-07-01 15:44 ` Arnd Bergmann
2016-07-01 16:09 ` Liviu Dudau
2016-07-01 16:30 ` Arnd Bergmann
2016-07-04 9:56 ` Liviu Dudau
2016-07-04 13:46 ` Arnd Bergmann
2016-07-28 20:43 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=14945085.QO6LcyFgTY@wuerfel \
--to=arnd@arndb.de \
--cc=bhelgaas@google.com \
--cc=linux-pci@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=liviu.dudau@arm.com \
--cc=thierry.reding@gmail.com \
--cc=tn@semihalf.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox