linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] iommu: of: Fix check for returning EPROBE_DEFER
@ 2017-05-16  5:24 Sricharan R
  2017-05-16 14:09 ` Jonathan Neuschäfer
  0 siblings, 1 reply; 3+ messages in thread
From: Sricharan R @ 2017-05-16  5:24 UTC (permalink / raw)
  To: robin.murphy, will.deacon, joro, lorenzo.pieralisi, iommu,
	linux-arm-kernel, linux-arm-msm, m.szyprowski, bhelgaas,
	linux-pci, linux-acpi, tn, hanjun.guo, okaya, robh+dt,
	frowand.list, devicetree, linux-kernel, sudeep.holla, rjw, lenb,
	catalin.marinas, arnd, linux-arch, gregkh
  Cc: sricharan

While returning EPROBE_DEFER for iommu masters
take in to account of iommu nodes that could be
marked in DT as 'status=disabled', in which case
simply return NULL and let the master's probe
continue rather than deferring.

Signed-off-by: Sricharan R <sricharan@codeaurora.org>
Tested-by: Will Deacon <will.deacon@arm.com>
Acked-by: Will Deacon <will.deacon@arm.com>
---
 drivers/iommu/of_iommu.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/iommu/of_iommu.c b/drivers/iommu/of_iommu.c
index 9f44ee8..e6e9bec 100644
--- a/drivers/iommu/of_iommu.c
+++ b/drivers/iommu/of_iommu.c
@@ -118,6 +118,7 @@ static bool of_iommu_driver_present(struct device_node *np)
 
 	ops = iommu_ops_from_fwnode(fwnode);
 	if ((ops && !ops->of_xlate) ||
+	    !of_device_is_available(iommu_spec->np) ||
 	    (!ops && !of_iommu_driver_present(iommu_spec->np)))
 		return NULL;
 
-- 
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] iommu: of: Fix check for returning EPROBE_DEFER
  2017-05-16  5:24 [PATCH] iommu: of: Fix check for returning EPROBE_DEFER Sricharan R
@ 2017-05-16 14:09 ` Jonathan Neuschäfer
  2017-05-17  5:17   ` Sricharan R
  0 siblings, 1 reply; 3+ messages in thread
From: Jonathan Neuschäfer @ 2017-05-16 14:09 UTC (permalink / raw)
  To: Sricharan R
  Cc: catalin.marinas, will.deacon, okaya, frowand.list, m.szyprowski,
	linux-arch, lorenzo.pieralisi, tn, joro, linux-acpi, linux-pci,
	lenb, devicetree, arnd, linux-arm-msm, robh+dt, bhelgaas,
	linux-arm-kernel, gregkh, rjw, linux-kernel, iommu, hanjun.guo,
	sudeep.holla, robin.murphy

SGksIEkgaGF2ZSBhIGZldyBzdWdnZXN0aW9ucyBvbiBob3cgdG8gbWFrZSB0aGlzIGNvbW1pdCBt
ZXNzYWdlIG1vcmUKcmVhZGFibGU6CgpPbiBUdWUsIE1heSAxNiwgMjAxNyBhdCAxMDo1NDoxM0FN
ICswNTMwLCBTcmljaGFyYW4gUiB3cm90ZToKPiBXaGlsZSByZXR1cm5pbmcgRVBST0JFX0RFRkVS
IGZvciBpb21tdSBtYXN0ZXJzCgpBZGQgYSBjb21tYSBhdCB0aGUgZW5kIG9mIHRoaXMgbGluZQoK
PiB0YWtlIGluIHRvIGFjY291bnQgb2YgaW9tbXUgbm9kZXMgdGhhdCBjb3VsZCBiZQoKcy9pbiB0
by9pbnRvLwpzL29mIGlvbW11L29mX2lvbW11LwoKPiBtYXJrZWQgaW4gRFQgYXMgJ3N0YXR1cz1k
aXNhYmxlZCcsIGluIHdoaWNoIGNhc2UKPiBzaW1wbHkgcmV0dXJuIE5VTEwgYW5kIGxldCB0aGUg
bWFzdGVyJ3MgcHJvYmUKPiBjb250aW51ZSByYXRoZXIgdGhhbiBkZWZlcnJpbmcuCj4gCj4gU2ln
bmVkLW9mZi1ieTogU3JpY2hhcmFuIFIgPHNyaWNoYXJhbkBjb2RlYXVyb3JhLm9yZz4KPiBUZXN0
ZWQtYnk6IFdpbGwgRGVhY29uIDx3aWxsLmRlYWNvbkBhcm0uY29tPgo+IEFja2VkLWJ5OiBXaWxs
IERlYWNvbiA8d2lsbC5kZWFjb25AYXJtLmNvbT4KCgpUaGFua3MsCkpvbmF0aGFuIE5ldXNjaMOk
ZmVyCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51
eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVh
ZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1h
cm0ta2VybmVsCg==

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] iommu: of: Fix check for returning EPROBE_DEFER
  2017-05-16 14:09 ` Jonathan Neuschäfer
@ 2017-05-17  5:17   ` Sricharan R
  0 siblings, 0 replies; 3+ messages in thread
From: Sricharan R @ 2017-05-17  5:17 UTC (permalink / raw)
  To: Jonathan Neuschäfer
  Cc: catalin.marinas, will.deacon, okaya, frowand.list, m.szyprowski,
	linux-arch, lorenzo.pieralisi, tn, joro, linux-acpi, linux-pci,
	lenb, devicetree, arnd, linux-arm-msm, robh+dt, bhelgaas,
	linux-arm-kernel, gregkh, rjw, linux-kernel, iommu, hanjun.guo,
	sudeep.holla, robin.murphy

SGksCgpPbiA1LzE2LzIwMTcgNzozOSBQTSwgSm9uYXRoYW4gTmV1c2Now6RmZXIgd3JvdGU6Cj4g
SGksIEkgaGF2ZSBhIGZldyBzdWdnZXN0aW9ucyBvbiBob3cgdG8gbWFrZSB0aGlzIGNvbW1pdCBt
ZXNzYWdlIG1vcmUKPiByZWFkYWJsZToKPiAKPiBPbiBUdWUsIE1heSAxNiwgMjAxNyBhdCAxMDo1
NDoxM0FNICswNTMwLCBTcmljaGFyYW4gUiB3cm90ZToKPj4gV2hpbGUgcmV0dXJuaW5nIEVQUk9C
RV9ERUZFUiBmb3IgaW9tbXUgbWFzdGVycwo+IAo+IEFkZCBhIGNvbW1hIGF0IHRoZSBlbmQgb2Yg
dGhpcyBsaW5lCj4gCj4+IHRha2UgaW4gdG8gYWNjb3VudCBvZiBpb21tdSBub2RlcyB0aGF0IGNv
dWxkIGJlCj4gCj4gcy9pbiB0by9pbnRvLwo+IHMvb2YgaW9tbXUvb2ZfaW9tbXUvCj4gCgpvaywg
d2lsbCBjb3JyZWN0IHRoZSBhYm92ZS4KClJlZ2FyZHMsCiBTcmljaGFyYW4KCj4+IG1hcmtlZCBp
biBEVCBhcyAnc3RhdHVzPWRpc2FibGVkJywgaW4gd2hpY2ggY2FzZQo+PiBzaW1wbHkgcmV0dXJu
IE5VTEwgYW5kIGxldCB0aGUgbWFzdGVyJ3MgcHJvYmUKPj4gY29udGludWUgcmF0aGVyIHRoYW4g
ZGVmZXJyaW5nLgo+Pgo+PiBTaWduZWQtb2ZmLWJ5OiBTcmljaGFyYW4gUiA8c3JpY2hhcmFuQGNv
ZGVhdXJvcmEub3JnPgo+PiBUZXN0ZWQtYnk6IFdpbGwgRGVhY29uIDx3aWxsLmRlYWNvbkBhcm0u
Y29tPgo+PiBBY2tlZC1ieTogV2lsbCBEZWFjb24gPHdpbGwuZGVhY29uQGFybS5jb20+Cj4gCj4g
Cj4gVGhhbmtzLAo+IEpvbmF0aGFuIE5ldXNjaMOkZmVyCj4gCgotLSAKIlFVQUxDT01NIElORElB
LCBvbiBiZWhhbGYgb2YgUXVhbGNvbW0gSW5ub3ZhdGlvbiBDZW50ZXIsIEluYy4gaXMgYSBtZW1i
ZXIgb2YgQ29kZSBBdXJvcmEgRm9ydW0sIGhvc3RlZCBieSBUaGUgTGludXggRm91bmRhdGlvbgoK
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJt
LWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3Jn
Cmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtl
cm5lbAo=

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-05-17  5:17 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-05-16  5:24 [PATCH] iommu: of: Fix check for returning EPROBE_DEFER Sricharan R
2017-05-16 14:09 ` Jonathan Neuschäfer
2017-05-17  5:17   ` Sricharan R

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).