* [PATCH 0/3] constify pci attribute_group structures.
@ 2017-07-11 9:28 Arvind Yadav
2017-07-11 9:28 ` [PATCH 3/3] PCI: hotplug: constify " Arvind Yadav
0 siblings, 1 reply; 3+ messages in thread
From: Arvind Yadav @ 2017-07-11 9:28 UTC (permalink / raw)
To: bhelgaas, paulus, mpe, benh; +Cc: linux-pci, linux-kernel, linuxppc-dev
attribute_groups are not supposed to change at runtime. All functions
working with attribute_groups provided by <linux/sysfs.h> work
with const attribute_group. So mark the non-const structs as const.
Arvind Yadav (3):
[PATCH 1/3] PCI: pci-sysfs: constify attribute_group structures.
[PATCH 2/3] PCI: pci-label: constify attribute_group structures.
[PATCH 3/3] PCI: hotplug: constify attribute_group structures.
drivers/pci/hotplug/rpadlpar_sysfs.c | 2 +-
drivers/pci/pci-label.c | 4 ++--
drivers/pci/pci-sysfs.c | 10 +++++-----
3 files changed, 8 insertions(+), 8 deletions(-)
--
1.9.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH 3/3] PCI: hotplug: constify attribute_group structures.
2017-07-11 9:28 [PATCH 0/3] constify pci attribute_group structures Arvind Yadav
@ 2017-07-11 9:28 ` Arvind Yadav
2017-07-11 18:55 ` Tyrel Datwyler
0 siblings, 1 reply; 3+ messages in thread
From: Arvind Yadav @ 2017-07-11 9:28 UTC (permalink / raw)
To: bhelgaas, paulus, mpe, benh; +Cc: linux-pci, linux-kernel, linuxppc-dev
attribute_groups are not supposed to change at runtime. All functions
working with attribute_groups provided by <linux/sysfs.h> work
with const attribute_group. So mark the non-const structs as const.
File size before:
text data bss dec hex filename
418 160 8 586 24a drivers/pci/hotplug/rpadlpar_sysfs.o
File size After adding 'const':
text data bss dec hex filename
482 96 8 586 232 drivers/pci/hotplug/rpadlpar_sysfs.o
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/pci/hotplug/rpadlpar_sysfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pci/hotplug/rpadlpar_sysfs.c b/drivers/pci/hotplug/rpadlpar_sysfs.c
index a796301..edb5d8a 100644
--- a/drivers/pci/hotplug/rpadlpar_sysfs.c
+++ b/drivers/pci/hotplug/rpadlpar_sysfs.c
@@ -102,7 +102,7 @@ static ssize_t remove_slot_show(struct kobject *kobj,
NULL,
};
-static struct attribute_group dlpar_attr_group = {
+static const struct attribute_group dlpar_attr_group = {
.attrs = default_attrs,
};
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH 3/3] PCI: hotplug: constify attribute_group structures.
2017-07-11 9:28 ` [PATCH 3/3] PCI: hotplug: constify " Arvind Yadav
@ 2017-07-11 18:55 ` Tyrel Datwyler
0 siblings, 0 replies; 3+ messages in thread
From: Tyrel Datwyler @ 2017-07-11 18:55 UTC (permalink / raw)
To: Arvind Yadav, bhelgaas, paulus, mpe, benh
Cc: linux-pci, linuxppc-dev, linux-kernel
On 07/11/2017 02:28 AM, Arvind Yadav wrote:
> attribute_groups are not supposed to change at runtime. All functions
> working with attribute_groups provided by <linux/sysfs.h> work
> with const attribute_group. So mark the non-const structs as const.
>
> File size before:
> text data bss dec hex filename
> 418 160 8 586 24a drivers/pci/hotplug/rpadlpar_sysfs.o
>
> File size After adding 'const':
> text data bss dec hex filename
> 482 96 8 586 232 drivers/pci/hotplug/rpadlpar_sysfs.o
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Reviewed-by: Tyrel Datwyler <tyreld@linux.vnet.ibm.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-07-11 18:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-07-11 9:28 [PATCH 0/3] constify pci attribute_group structures Arvind Yadav
2017-07-11 9:28 ` [PATCH 3/3] PCI: hotplug: constify " Arvind Yadav
2017-07-11 18:55 ` Tyrel Datwyler
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).