linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Aleksandr Bezzubikov <zuban32s@gmail.com>
To: linux-pci@vger.kernel.org
Cc: bhelgaas@google.com, marcel@redhat.com,
	Aleksandr Bezzubikov <zuban32s@gmail.com>
Subject: [PATCH] pci: shpchp: set the bridge busmaster if MSI are enabled
Date: Tue, 18 Jul 2017 17:12:25 +0300	[thread overview]
Message-ID: <1500387145-4216-1-git-send-email-zuban32s@gmail.com> (raw)

An MSI-based SHPC built in PCI bridges can configure hotplugged devices
only if they notify the bridge with MSI.
But they can't trigger interrupt without the bridge being busmaster,
that's why it should be enabled.

Signed-off-by: Aleksandr Bezzubikov <zuban32s@gmail.com>
---
 drivers/pci/hotplug/shpchp_hpc.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/pci/hotplug/shpchp_hpc.c b/drivers/pci/hotplug/shpchp_hpc.c
index de0ea47..e5824c7 100644
--- a/drivers/pci/hotplug/shpchp_hpc.c
+++ b/drivers/pci/hotplug/shpchp_hpc.c
@@ -1062,6 +1062,8 @@ int shpc_init(struct controller *ctrl, struct pci_dev *pdev)
 		if (rc) {
 			ctrl_info(ctrl, "Can't get msi for the hotplug controller\n");
 			ctrl_info(ctrl, "Use INTx for the hotplug controller\n");
+		} else {
+			pci_set_master(pdev);
 		}
 
 		rc = request_irq(ctrl->pci_dev->irq, shpc_isr, IRQF_SHARED,
-- 
2.7.4

             reply	other threads:[~2017-07-18 14:13 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-18 14:12 Aleksandr Bezzubikov [this message]
2017-07-19 13:36 ` [PATCH] pci: shpchp: set the bridge busmaster if MSI are enabled Marcel Apfelbaum
2017-08-01 15:56   ` Marcel Apfelbaum
2017-07-23 20:18 ` Alexander Bezzubikov
2017-07-24 14:56   ` Alex Williamson
2017-07-24 15:07     ` Alexander Bezzubikov
2017-08-01 15:57 ` Michael S. Tsirkin
2017-08-02 22:35 ` [PATCH] " Bjorn Helgaas
2017-08-02 22:48   ` Alexander Bezzubikov
2017-08-03 16:34     ` Bjorn Helgaas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1500387145-4216-1-git-send-email-zuban32s@gmail.com \
    --to=zuban32s@gmail.com \
    --cc=bhelgaas@google.com \
    --cc=linux-pci@vger.kernel.org \
    --cc=marcel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).