* [PATCH] PCI: Add const to bin_attribute structures
@ 2017-08-02 15:27 Bhumika Goyal
2017-08-03 23:23 ` Bjorn Helgaas
0 siblings, 1 reply; 2+ messages in thread
From: Bhumika Goyal @ 2017-08-02 15:27 UTC (permalink / raw)
To: julia.lawall, bhelgaas, linux-pci, linux-kernel; +Cc: Bhumika Goyal
Add const to bin_attribute structures as they are only passed to the
functions sysfs_{remove/create}_bin_file. The corresponding arguments
are of type const, so declare the structures to be const.
Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
---
drivers/pci/pci-sysfs.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/pci/pci-sysfs.c b/drivers/pci/pci-sysfs.c
index 2f3780b..2fc358c 100644
--- a/drivers/pci/pci-sysfs.c
+++ b/drivers/pci/pci-sysfs.c
@@ -1431,7 +1431,7 @@ static ssize_t pci_read_rom(struct file *filp, struct kobject *kobj,
return count;
}
-static struct bin_attribute pci_config_attr = {
+static const struct bin_attribute pci_config_attr = {
.attr = {
.name = "config",
.mode = S_IRUGO | S_IWUSR,
@@ -1441,7 +1441,7 @@ static ssize_t pci_read_rom(struct file *filp, struct kobject *kobj,
.write = pci_write_config,
};
-static struct bin_attribute pcie_config_attr = {
+static const struct bin_attribute pcie_config_attr = {
.attr = {
.name = "config",
.mode = S_IRUGO | S_IWUSR,
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] PCI: Add const to bin_attribute structures
2017-08-02 15:27 [PATCH] PCI: Add const to bin_attribute structures Bhumika Goyal
@ 2017-08-03 23:23 ` Bjorn Helgaas
0 siblings, 0 replies; 2+ messages in thread
From: Bjorn Helgaas @ 2017-08-03 23:23 UTC (permalink / raw)
To: Bhumika Goyal; +Cc: julia.lawall, bhelgaas, linux-pci, linux-kernel
On Wed, Aug 02, 2017 at 08:57:27PM +0530, Bhumika Goyal wrote:
> Add const to bin_attribute structures as they are only passed to the
> functions sysfs_{remove/create}_bin_file. The corresponding arguments
> are of type const, so declare the structures to be const.
>
> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
Applied to pci/misc for v4.14, thanks!
> ---
> drivers/pci/pci-sysfs.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pci/pci-sysfs.c b/drivers/pci/pci-sysfs.c
> index 2f3780b..2fc358c 100644
> --- a/drivers/pci/pci-sysfs.c
> +++ b/drivers/pci/pci-sysfs.c
> @@ -1431,7 +1431,7 @@ static ssize_t pci_read_rom(struct file *filp, struct kobject *kobj,
> return count;
> }
>
> -static struct bin_attribute pci_config_attr = {
> +static const struct bin_attribute pci_config_attr = {
> .attr = {
> .name = "config",
> .mode = S_IRUGO | S_IWUSR,
> @@ -1441,7 +1441,7 @@ static ssize_t pci_read_rom(struct file *filp, struct kobject *kobj,
> .write = pci_write_config,
> };
>
> -static struct bin_attribute pcie_config_attr = {
> +static const struct bin_attribute pcie_config_attr = {
> .attr = {
> .name = "config",
> .mode = S_IRUGO | S_IWUSR,
> --
> 1.9.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-08-03 23:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-08-02 15:27 [PATCH] PCI: Add const to bin_attribute structures Bhumika Goyal
2017-08-03 23:23 ` Bjorn Helgaas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).