From: Arvind Yadav <arvind.yadav.cs@gmail.com>
To: bhelgaas@google.com, scott@spiteful.org
Cc: linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org
Subject: [PATCH 5/5] PCI: hotplug: cpqphp: constify pci_device_id.
Date: Thu, 3 Aug 2017 22:39:16 +0530 [thread overview]
Message-ID: <1501780156-24708-6-git-send-email-arvind.yadav.cs@gmail.com> (raw)
In-Reply-To: <1501780156-24708-1-git-send-email-arvind.yadav.cs@gmail.com>
pci_device_id are not supposed to change at runtime. All functions
working with pci_device_id provided by <linux/pci.h> work with
const pci_device_id. So mark the non-const structs as const.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/pci/hotplug/cpqphp_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pci/hotplug/cpqphp_core.c b/drivers/pci/hotplug/cpqphp_core.c
index 33d300d..4d06b84 100644
--- a/drivers/pci/hotplug/cpqphp_core.c
+++ b/drivers/pci/hotplug/cpqphp_core.c
@@ -1417,7 +1417,7 @@ static void __exit unload_cpqphpd(void)
iounmap(smbios_start);
}
-static struct pci_device_id hpcd_pci_tbl[] = {
+static const struct pci_device_id hpcd_pci_tbl[] = {
{
/* handle any PCI Hotplug controller */
.class = ((PCI_CLASS_SYSTEM_PCI_HOTPLUG << 8) | 0x00),
--
2.7.4
next prev parent reply other threads:[~2017-08-03 17:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-03 17:09 [PATCH 0/5] constify hotplug pci_device_id Arvind Yadav
2017-08-03 17:09 ` [PATCH 1/5] PCI: hotplug: shpchp: constify pci_device_id Arvind Yadav
2017-08-03 17:09 ` [PATCH 2/5] PCI: hotplug: ibmphp: " Arvind Yadav
2017-08-03 17:09 ` [PATCH 3/5] PCI: hotplug: bmphp_ebda: " Arvind Yadav
2017-08-03 17:09 ` [PATCH 4/5] PCI: hotplug: cpcihp_zt5550: " Arvind Yadav
2017-08-03 17:09 ` Arvind Yadav [this message]
2017-08-03 22:57 ` [PATCH 0/5] constify hotplug pci_device_id Bjorn Helgaas
2017-08-03 23:22 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1501780156-24708-6-git-send-email-arvind.yadav.cs@gmail.com \
--to=arvind.yadav.cs@gmail.com \
--cc=bhelgaas@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=scott@spiteful.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).