* [PATCH] PCI: dwc: make dw_pcie_host_ops const
@ 2017-08-09 7:48 Bhumika Goyal
2017-08-19 21:25 ` Bjorn Helgaas
0 siblings, 1 reply; 2+ messages in thread
From: Bhumika Goyal @ 2017-08-09 7:48 UTC (permalink / raw)
To: julia.lawall, wangzhou1, gabriele.paoloni, bhelgaas, songxiaowei,
wangbinghui, linux-pci, linux-kernel
Cc: Bhumika Goyal
Make these structures const as they are only stored in the ops field of
a pcie_port structure, which is of type const.
Done using Coccinelle.
Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
---
drivers/pci/dwc/pcie-hisi.c | 2 +-
drivers/pci/dwc/pcie-kirin.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/pci/dwc/pcie-hisi.c b/drivers/pci/dwc/pcie-hisi.c
index e51acee..518cd7e 100644
--- a/drivers/pci/dwc/pcie-hisi.c
+++ b/drivers/pci/dwc/pcie-hisi.c
@@ -223,7 +223,7 @@ static int hisi_pcie_link_up(struct dw_pcie *pci)
return hisi_pcie->soc_ops->hisi_pcie_link_up(hisi_pcie);
}
-static struct dw_pcie_host_ops hisi_pcie_host_ops = {
+static const struct dw_pcie_host_ops hisi_pcie_host_ops = {
.rd_own_conf = hisi_pcie_cfg_read,
.wr_own_conf = hisi_pcie_cfg_write,
};
diff --git a/drivers/pci/dwc/pcie-kirin.c b/drivers/pci/dwc/pcie-kirin.c
index 33fddb9..a623f96 100644
--- a/drivers/pci/dwc/pcie-kirin.c
+++ b/drivers/pci/dwc/pcie-kirin.c
@@ -441,7 +441,7 @@ static void kirin_pcie_host_init(struct pcie_port *pp)
.link_up = kirin_pcie_link_up,
};
-static struct dw_pcie_host_ops kirin_pcie_host_ops = {
+static const struct dw_pcie_host_ops kirin_pcie_host_ops = {
.rd_own_conf = kirin_pcie_rd_own_conf,
.wr_own_conf = kirin_pcie_wr_own_conf,
.host_init = kirin_pcie_host_init,
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] PCI: dwc: make dw_pcie_host_ops const
2017-08-09 7:48 [PATCH] PCI: dwc: make dw_pcie_host_ops const Bhumika Goyal
@ 2017-08-19 21:25 ` Bjorn Helgaas
0 siblings, 0 replies; 2+ messages in thread
From: Bjorn Helgaas @ 2017-08-19 21:25 UTC (permalink / raw)
To: Bhumika Goyal
Cc: julia.lawall, wangzhou1, gabriele.paoloni, bhelgaas, songxiaowei,
wangbinghui, linux-pci, linux-kernel
On Wed, Aug 09, 2017 at 01:18:48PM +0530, Bhumika Goyal wrote:
> Make these structures const as they are only stored in the ops field of
> a pcie_port structure, which is of type const.
> Done using Coccinelle.
>
> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
Applied to pci/host-hisi and pci/host-kirin for v4.14, thanks!
> ---
> drivers/pci/dwc/pcie-hisi.c | 2 +-
> drivers/pci/dwc/pcie-kirin.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pci/dwc/pcie-hisi.c b/drivers/pci/dwc/pcie-hisi.c
> index e51acee..518cd7e 100644
> --- a/drivers/pci/dwc/pcie-hisi.c
> +++ b/drivers/pci/dwc/pcie-hisi.c
> @@ -223,7 +223,7 @@ static int hisi_pcie_link_up(struct dw_pcie *pci)
> return hisi_pcie->soc_ops->hisi_pcie_link_up(hisi_pcie);
> }
>
> -static struct dw_pcie_host_ops hisi_pcie_host_ops = {
> +static const struct dw_pcie_host_ops hisi_pcie_host_ops = {
> .rd_own_conf = hisi_pcie_cfg_read,
> .wr_own_conf = hisi_pcie_cfg_write,
> };
> diff --git a/drivers/pci/dwc/pcie-kirin.c b/drivers/pci/dwc/pcie-kirin.c
> index 33fddb9..a623f96 100644
> --- a/drivers/pci/dwc/pcie-kirin.c
> +++ b/drivers/pci/dwc/pcie-kirin.c
> @@ -441,7 +441,7 @@ static void kirin_pcie_host_init(struct pcie_port *pp)
> .link_up = kirin_pcie_link_up,
> };
>
> -static struct dw_pcie_host_ops kirin_pcie_host_ops = {
> +static const struct dw_pcie_host_ops kirin_pcie_host_ops = {
> .rd_own_conf = kirin_pcie_rd_own_conf,
> .wr_own_conf = kirin_pcie_wr_own_conf,
> .host_init = kirin_pcie_host_init,
> --
> 1.9.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-08-19 21:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-08-09 7:48 [PATCH] PCI: dwc: make dw_pcie_host_ops const Bhumika Goyal
2017-08-19 21:25 ` Bjorn Helgaas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).