From: Faiz Abbas <faiz_abbas@ti.com>
To: <jingoohan1@gmail.com>, <Joao.Pinto@synopsys.com>
Cc: <bhelgaas@google.com>, <linux-pci@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, Faiz Abbas <faiz_abbas@ti.com>
Subject: [PATCH] pci: dwc: Clear MSI interrupt status after it is handled
Date: Thu, 10 Aug 2017 16:54:55 +0530 [thread overview]
Message-ID: <1502364295-3786-1-git-send-email-faiz_abbas@ti.com> (raw)
If the interrupt status is cleared before it is handled, it is possible
that another interrupt will trigger while servicing the previous one.
This is causing timeouts in some wireless lan cards which use pcie.
Therefore, clear MSI interrupt status after it gets serviced instead
of before calling generic_handler.
Signed-off-by: Faiz Abbas <faiz_abbas@ti.com>
---
drivers/pci/dwc/pcie-designware-host.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pci/dwc/pcie-designware-host.c b/drivers/pci/dwc/pcie-designware-host.c
index 28ed32b..78b2584 100644
--- a/drivers/pci/dwc/pcie-designware-host.c
+++ b/drivers/pci/dwc/pcie-designware-host.c
@@ -71,9 +71,9 @@ irqreturn_t dw_handle_msi_irq(struct pcie_port *pp)
while ((pos = find_next_bit((unsigned long *) &val, 32,
pos)) != 32) {
irq = irq_find_mapping(pp->irq_domain, i * 32 + pos);
+ generic_handle_irq(irq);
dw_pcie_wr_own_conf(pp, PCIE_MSI_INTR0_STATUS + i * 12,
4, 1 << pos);
- generic_handle_irq(irq);
pos++;
}
}
--
2.7.4
next reply other threads:[~2017-08-10 11:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-10 11:24 Faiz Abbas [this message]
2017-08-18 11:43 ` [PATCH] pci: dwc: Clear MSI interrupt status after it is handled Joao Pinto
2017-08-22 20:51 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1502364295-3786-1-git-send-email-faiz_abbas@ti.com \
--to=faiz_abbas@ti.com \
--cc=Joao.Pinto@synopsys.com \
--cc=bhelgaas@google.com \
--cc=jingoohan1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).