From: Jan Glauber <jglauber@cavium.com>
To: Bjorn Helgaas <bhelgaas@google.com>,
linux-pci@vger.kernel.org,
Alex Williamson <alex.williamson@redhat.com>
Cc: kvm@vger.kernel.org, david.daney@cavium.com,
Jon Masters <jcm@redhat.com>,
linux-kernel@vger.kernel.org,
Robert Richter <robert.richter@cavium.com>,
Jan Glauber <jglauber@cavium.com>,
linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/3] PCI: Allow PCI_DEV_FLAGS_NO_BUS_RESET to be used on bus device
Date: Thu, 17 Aug 2017 10:14:21 +0200 [thread overview]
Message-ID: <1502957663-5527-2-git-send-email-jglauber@cavium.com> (raw)
In-Reply-To: <1502957663-5527-1-git-send-email-jglauber@cavium.com>
From: David Daney <david.daney@cavium.com>
When checking to see if a PCI bus can safely be reset, we check to see
if any of the children have their PCI_DEV_FLAGS_NO_BUS_RESET flag set.
As these devices are known not to behave well after a bus reset.
Some PCIe root port bridges also do not behave well after a bus reset,
sometimes causing the devices behind the bridge to become unusable.
Add a check for the PCI_DEV_FLAGS_NO_BUS_RESET flag being set in the
bridge device to allow these bridges to be flagged, and prevent their
buses from being reset.
A follow on patch will add a quirk for this type of bridge.
Signed-off-by: David Daney <david.daney@cavium.com>
[jglauber@cavium.com: fixed typo]
Signed-off-by: Jan Glauber <jglauber@cavium.com>
---
drivers/pci/pci.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
index af0cc34..d9abbc9 100644
--- a/drivers/pci/pci.c
+++ b/drivers/pci/pci.c
@@ -4290,6 +4290,10 @@ static bool pci_bus_resetable(struct pci_bus *bus)
{
struct pci_dev *dev;
+
+ if (bus->self && (bus->self->dev_flags & PCI_DEV_FLAGS_NO_BUS_RESET))
+ return false;
+
list_for_each_entry(dev, &bus->devices, bus_list) {
if (dev->dev_flags & PCI_DEV_FLAGS_NO_BUS_RESET ||
(dev->subordinate && !pci_bus_resetable(dev->subordinate)))
--
2.9.0.rc0.21.g7777322
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2017-08-17 8:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-17 8:14 [PATCH v2 0/3] Workaround for bus reset on Cavium cn8xxx root ports Jan Glauber
2017-08-17 8:14 ` Jan Glauber [this message]
2017-08-17 8:14 ` [PATCH v2 2/3] PCI: Avoid bus reset for " Jan Glauber
2017-08-17 8:14 ` [PATCH v2 3/3] vfio/pci: Don't probe devices that can't be reset Jan Glauber
2017-08-17 13:00 ` Alex Williamson
2017-08-18 13:42 ` Jan Glauber
2017-08-18 14:12 ` Alex Williamson
2017-08-18 15:57 ` David Daney
2017-08-19 3:55 ` Alex Williamson
2017-08-23 8:06 ` Jan Glauber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1502957663-5527-2-git-send-email-jglauber@cavium.com \
--to=jglauber@cavium.com \
--cc=alex.williamson@redhat.com \
--cc=bhelgaas@google.com \
--cc=david.daney@cavium.com \
--cc=jcm@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=robert.richter@cavium.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).